Bug 218320 – games-emulation/dosbox-0.72 fails w/ gcc-4.3.0

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Peter Alfredsen (RETIRED) 2008-04-18 20:05:00 UTC]

i686-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I. -I../..  -I../../include -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT  -O2 -march=i686 -mtune=athlon-xp -msse -mmmx -pipe -ggdb3  -c -o cdrom_image.o `test -f 'cdrom_image.cpp' || echo './'`cdrom_image.cpp
i686-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I. -I../..  -I../../include -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT  -O2 -march=i686 -mtune=athlon-xp -msse -mmmx -pipe -ggdb3  -c -o cdrom_ioctl_os2.o `test -f 'cdrom_ioctl_os2.cpp' || echo './'`cdrom_ioctl_os2.cpp
In file included from drives.h:27,
                 from cdrom_image.cpp:32:
../../include/dos_system.h:132: warning: ‘typedef’ was ignored in this declaration
cdrom_image.cpp: In member function ‘virtual int CDROM_Interface_Image::AudioFile::getLength()’:
cdrom_image.cpp:121: error: ‘numeric_limits’ was not declared in this scope
cdrom_image.cpp:121: error: expected primary-expression before ‘int’
cdrom_image.cpp:121: error: expected `)' before ‘int’
cdrom_image.cpp:121: error: expected `)' before ‘;’ token
cdrom_image.cpp:121: error: expected `)' before ‘;’ token
make[3]: *** [cdrom_image.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory `/var/tmp/portage/games-emulation/dosbox-0.72/work/dosbox-0.72/src/dos'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/var/tmp/portage/games-emulation/dosbox-0.72/work/dosbox-0.72/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/games-emulation/dosbox-0.72/work/dosbox-0.72'
make: *** [all] Error 2


Reproducible: Always

Steps to Reproduce:

[Comment 1 Peter Alfredsen (RETIRED) 2008-04-18 20:05:43 UTC]

Created attachment 150220 [details, diff]
dosbox-0.72-gcc43.patch

Fixes the problem. Adapted from Debian.

[Comment 2 Mr. Bones. (RETIRED) 2008-04-18 20:32:51 UTC]

Was this patch sent upstream?

[Comment 3 Peter Alfredsen (RETIRED) 2008-04-18 20:54:13 UTC]

(In reply to comment #2)
> Was this patch sent upstream?

I have no knowledge of that.

[Comment 4 Diego Elio Pettenò (RETIRED) 2008-05-23 16:33:14 UTC]

Upstream applied a very similar patch in their CVS already, can I apply this? (I have applied locally in the mean time).

Also, the alsa USE flag (sorry for the pun) is not doing anything anymore, mind if I get that working again disabling ALSA midi support if that is not enabled?

[Comment 5 Mr. Bones. (RETIRED) 2008-05-23 20:51:35 UTC]

I'd take a patch for the alsa-midi stuff in a separate bug.

[Comment 6 Diego Elio Pettenò (RETIRED) 2008-06-13 16:35:04 UTC]

Thanks Peter, committed now.