Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 215776 - [new version] games-simulation/openttd-0.6.3
Summary: [new version] games-simulation/openttd-0.6.3
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: High enhancement with 2 votes (vote)
Assignee: Gentoo Games
URL: http://www.openttd.org/
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks: CVE-2008-3547
  Show dependency tree
 
Reported: 2008-04-01 21:42 UTC by Denis Pesotsky
Modified: 2008-11-10 20:40 UTC (History)
12 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild draft (openttd-0.6.0.ebuild,5.60 KB, text/plain)
2008-04-02 19:44 UTC, Tomáš Chvátal (RETIRED)
Details
rc version updates (openttd-0.6.1_rc1.ebuild,5.65 KB, text/plain)
2008-05-08 04:15 UTC, Eion Robb
Details
openttd 0.6.2 (openttd-0.6.2.ebuild,5.56 KB, text/plain)
2008-08-08 16:45 UTC, Tomáš Chvátal (RETIRED)
Details
libiconv patch (libiconv.patch,338 bytes, patch)
2008-08-08 16:47 UTC, Tomáš Chvátal (RETIRED)
Details | Diff
Ebuild for version 0.6.3 (openttd-0.6.3.ebuild,5.00 KB, text/plain)
2008-10-02 10:00 UTC, Tomáš Chvátal (RETIRED)
Details
Modified the 'make install' to work with Gentoo (install.patch,5.34 KB, patch)
2008-10-16 12:37 UTC, Patric Stout
Details | Diff
Makes a Gentoo valid menu-desktop-thingy (menu_name.patch,439 bytes, patch)
2008-10-16 12:38 UTC, Patric Stout
Details | Diff
0.6.3 ebuild (openttd-0.6.3.ebuild,4.19 KB, text/plain)
2008-10-16 12:39 UTC, Patric Stout
Details
openttd-0.6.3 (openttd-0.6.3-r1.ebuild,4.03 KB, text/plain)
2008-10-17 19:02 UTC, Tomáš Chvátal (RETIRED)
Details
openttd-0.6.3 (openttd-0.6.3-r1.ebuild,4.02 KB, text/plain)
2008-10-19 11:47 UTC, Patric Stout
Details
openttd-0.6.3 (openttd-0.6.3-r2.ebuild,3.92 KB, text/plain)
2008-10-19 12:14 UTC, Patric Stout
Details
openttd-0.6.3 (openttd-0.6.3-r2.ebuild,3.98 KB, text/plain)
2008-10-19 20:11 UTC, Patric Stout
Details
openttd-0.6.3 (openttd-0.6.3.ebuild,3.99 KB, text/plain)
2008-10-22 19:48 UTC, Tomáš Chvátal (RETIRED)
Details
libiconv.patch (libiconv.patch,540 bytes, text/plain)
2008-10-22 20:04 UTC, Tomáš Chvátal (RETIRED)
Details
openttd-0.6.3 (openttd-0.6.3.ebuild,3.97 KB, text/plain)
2008-10-22 21:35 UTC, Tomáš Chvátal (RETIRED)
Details
libiconv.patch (libiconv.patch,1.43 KB, text/plain)
2008-10-22 22:05 UTC, Tomáš Chvátal (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Denis Pesotsky 2008-04-01 21:42:06 UTC
0.6.0 is out. Currently there is 0.5.3 in portage tree.
Comment 1 Denis Pesotsky 2008-04-01 21:42:55 UTC
This should help with writing new ebuild: http://bugs.gentoo.org/show_bug.cgi?id=189303
Comment 2 Tomáš Chvátal (RETIRED) gentoo-dev 2008-04-02 19:43:31 UTC
god killed one kitten beacause of you :]
good for you is that i really don't like kittens ;)
standard policy is at least wait 2 days so somebody have a chance to fix this

starting from: http://bugs.gentoo.org/show_bug.cgi?id=206337
as libiconv.patch use this: http://bugs.gentoo.org/attachment.cgi?id=141134
ebuild attachment is comming
Comment 3 Tomáš Chvátal (RETIRED) gentoo-dev 2008-04-02 19:44:51 UTC
Created attachment 148128 [details]
ebuild draft

from bug mentioned in previous post 
compiles fine
runs, try with various use
Comment 4 Denis Pesotsky 2008-04-02 21:24:45 UTC
(In reply to comment #2)
> god killed one kitten beacause of you :]
> good for you is that i really don't like kittens ;)
> standard policy is at least wait 2 days so somebody have a chance to fix this
 
Oh... sorry. Time to read rules. Btw, where can i get them? :)
Comment 5 Denis Pesotsky 2008-04-02 21:29:41 UTC
damntux openttd # ebuild openttd-0.6.0.ebuild digest                                                                                                       
>>> Downloading 'http://mesh.dl.sourceforge.net/sourceforge/openttd/openttd-0.6.0-source.tar.bz2'
--2008-04-03 01:27:08--  http://mesh.dl.sourceforge.net/sourceforge/openttd/openttd-0.6.0-source.tar.bz2
Resolving mesh.dl.sourceforge.net... 213.203.218.122
Connecting to mesh.dl.sourceforge.net|213.203.218.122|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 3688002 (3,5M) [application/x-bzip2]
Saving to: `/usr/portage/distfiles/openttd-0.6.0-source.tar.bz2'

100%[===========================================================================================================================>] 3 688 002    195K/s   in 16s

2008-04-03 01:27:23 (232 KB/s) - `/usr/portage/distfiles/openttd-0.6.0-source.tar.bz2' saved [3688002/3688002]

>>> Creating Manifest for /usr/local/portage/my/games-simulation/openttd
damntux openttd # emerge -auDN world                                                                                                                       

These are the packages that would be merged, in order:

Calculating world dependencies... done!
[ebuild     U ] games-simulation/openttd-0.6.0 [0.5.3]

Would you like to merge these packages? [Yes/No]
>>> Verifying ebuild Manifests...

>>> Emerging (1 of 1) games-simulation/openttd-0.6.0 to /
 * openttd-0.5.0-scenarios.tar.bz2 RMD160 SHA1 SHA256 size ;-) ...                                                                                             [ ok ]
 * openttd-0.4.8-scenarios.tar.bz2 RMD160 SHA1 SHA256 size ;-) ...                                                                                             [ ok ]
 * openttd-0.6.0-source.tar.bz2 RMD160 SHA1 SHA256 size ;-) ...                                                                                                [ ok ]
 * checking ebuild checksums ;-) ...                                                                                                                           [ ok ]
 * checking auxfile checksums ;-) ...                                                                                                                          [ ok ]
 * checking miscfile checksums ;-) ...                                                                                                                         [ ok ]
 * checking openttd-0.6.0-source.tar.bz2 ;-) ...                                                                                                               [ ok ]
 * checking openttd-0.4.8-scenarios.tar.bz2 ;-) ...                                                                                                            [ ok ]
 * checking openttd-0.5.0-scenarios.tar.bz2 ;-) ...                                                                                                            [ ok ]
>>> Unpacking source...
>>> Unpacking openttd-0.6.0-source.tar.bz2 to /var/tmp/portage/games-simulation/openttd-0.6.0/work
>>> Unpacking openttd-0.4.8-scenarios.tar.bz2 to /var/tmp/portage/games-simulation/openttd-0.6.0/work/openttd-0.6.0/bin/scenario
>>> Unpacking openttd-0.5.0-scenarios.tar.bz2 to /var/tmp/portage/games-simulation/openttd-0.6.0/work/openttd-0.6.0/bin/scenario

 * Cannot find $EPATCH_SOURCE!  Value for $EPATCH_SOURCE is:
 *
 *   /usr/local/portage/my/games-simulation/openttd/files/libiconv.patch
 *   ( libiconv.patch )

 *
 * ERROR: games-simulation/openttd-0.6.0 failed.
 * Call stack:
 *               ebuild.sh, line   49:  Called src_unpack
 *             environment, line 2415:  Called epatch 'src_unpack'
 *             environment, line 1073:  Called die
 * The specific snippet of code:
 *                   die "Cannot find \$EPATCH_SOURCE!";
 *  The die message:
 *   Cannot find $EPATCH_SOURCE!
 *
 * If you need support, post the topmost build error, and the call stack if relevant.
 * A complete build log is located at '/var/tmp/portage/games-simulation/openttd-0.6.0/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/games-simulation/openttd-0.6.0/temp/environment'.
 * This ebuild is from an overlay: '/usr/local/portage/my/'
Comment 6 Denis Pesotsky 2008-04-02 21:31:02 UTC
*delete this comment plz*
Comment 7 Denis Pesotsky 2008-04-02 21:33:24 UTC
Oh god... i'm drunk idiot... please delete last 3 comments.
Comment 8 Nathan Sullivan 2008-04-03 09:05:06 UTC
im happy with this being ~amd64... tested so far with no issues
Comment 9 Tomáš Chvátal (RETIRED) gentoo-dev 2008-04-03 09:34:49 UTC
(In reply to comment #4)
> (In reply to comment #2)
> > god killed one kitten beacause of you :]
> > good for you is that i really don't like kittens ;)
> > standard policy is at least wait 2 days so somebody have a chance to fix this
> 
> Oh... sorry. Time to read rules. Btw, where can i get them? :)
> 
a) Try to google it or go throught gentoo.org sites :] (long time since i needed them)

b) about that problem i can see you already fixed that and you show nice example of that people should really start reading carefully :]
Comment 10 Piotr Szymaniak 2008-04-06 13:02:38 UTC
Works fine for me (x86), and I just *love* trams. (:
Comment 11 Constantin Baranov 2008-05-01 14:21:55 UTC
(In reply to comment #8)
> im happy with this being ~amd64... tested so far with no issues
> 

Yet one vote for amd64: compiles cleanly and works fine on default/linux/amd64/2008.0/desktop profile with USE="alsa iconv png scenarios timidity zlib".
Comment 12 Vladimir Loose 2008-05-06 20:17:36 UTC
compiles perfectly on my x86, and works fine.

USE="alsa iconv png scenarios timidity zlib"

Thanks for ebuild :)
Comment 13 Eion Robb 2008-05-08 04:15:22 UTC
Created attachment 152417 [details]
rc version updates

The 0.6.0 ebuild above does not deal well with release-candidate versions of the game.  Merged some changes from 0.5.3.ebuild to handle different source tarball names.
Comment 14 Jan Stępień 2008-05-31 21:20:24 UTC
openttd-0.6.0.ebuild <http://bugs.gentoo.org/attachment.cgi?id=148128> with libiconv.patch <http://bugs.gentoo.org/attachment.cgi?id=141134> works fine on x86. Multiplayer has been tested - everything's running properly.
Comment 15 Tomáš Chvátal (RETIRED) gentoo-dev 2008-06-01 19:32:45 UTC
so there is version .6.1 works as previous version
as ebuild use: http://bugs.gentoo.org/attachment.cgi?id=148128
and as libconv.patch use: http://bugs.gentoo.org/attachment.cgi?id=141134

test, report problems and enjoy your game :]
Comment 16 Piotr Szymaniak 2008-06-01 19:50:42 UTC
Builds and works fine here. If someone is interested this ebuild is in roslin overlay. (;
Comment 17 Lukasz Ligowski 2008-07-25 19:10:23 UTC
I've built version .6.1 on amd64 and it works fine. Thanks!
Comment 18 Denis Pesotsky 2008-08-02 10:19:18 UTC
0.6.2 is out
Comment 19 Piotr Szymaniak 2008-08-02 17:00:12 UTC
(In reply to comment #18)
> 0.6.2 is out

Again:

> If someone is interested this ebuild is in roslin
> overlay. (;

Don't know if it makes any sense to put ebuild after ebuild in here since _nothing_ is happening...
Comment 20 Mr. Bones. (RETIRED) gentoo-dev 2008-08-02 17:50:30 UTC
Yes, this is exactly the right place.
Comment 21 Piotr Szymaniak 2008-08-03 08:31:21 UTC
Rename Eions ebuild and you will have working 0.6.2.
Comment 22 Vladimir Loose 2008-08-03 12:03:19 UTC
0.6.2 ebuild from roslin overlay compiles perfectly on my x86, and works fine with
USE="alsa iconv png scenarios timidity zlib"

(again thanks for ebuild!)

By the way: should we add this new (0.6.2) tbuild to attachmetns for this bug?
There is only 0.6.1_rc1 by now, when 'summary' says 'new 0.6.2 version' :)
Comment 23 Tomáš Chvátal (RETIRED) gentoo-dev 2008-08-08 16:45:59 UTC
Created attachment 162530 [details]
openttd 0.6.2

 + reenabling midi
 + adding unicode use flag
 + more debug with debug :] (didnt work before)
 + !tested build with various USE expect Timidity++ so please somebody test this one!
Comment 24 Tomáš Chvátal (RETIRED) gentoo-dev 2008-08-08 16:47:02 UTC
Created attachment 162532 [details, diff]
libiconv patch

Just to have it all in one place so people have no need to look into comments
Comment 25 David Hallas 2008-09-19 18:34:34 UTC
openttd-0.6.2.ebuild works fine for me running AMD64 stable system.
Comment 26 Stian Skjelstad 2008-09-19 18:46:12 UTC
This is not ment for stepping on anybodies toes, but..

Wouldn't it make more sense to have a newer version in the portage (even masked) that have the known security bugs fixed, than old versions with known issues masked present? Or did I miss some stupid point somewhere?
Comment 27 Tomáš Chvátal (RETIRED) gentoo-dev 2008-10-02 10:00:15 UTC
Created attachment 166969 [details]
Ebuild for version 0.6.3

Well i just fixed some einfo -> elog stuff. (renaming should be sufficient too if you are lazy to download it again :D)
Comment 28 James Le Cuirot gentoo-dev 2008-10-10 12:42:00 UTC
Apart from scripts/readme.txt not being found during src_install, 0.6.3 is working fine here on amd64. I'm unclear as to whether those vulnerabilities are fixed in this version.
Comment 29 James Le Cuirot gentoo-dev 2008-10-10 14:34:13 UTC
I also just ran the game on a Pentium 120 MMX using Puppy Linux. :D The reason I mention this is because I ran it outside of X using SDL with svgalib. Therefore the check for SDL being built against X may be unnecessary. However, the copy of SDL I built against was built against X anyway so maybe it's still needed at compile time.
Comment 30 Patric Stout 2008-10-16 12:36:26 UTC
I took a look at the ebuild, and it still contains very old stuff (like 0.4.8 stuff). So I took the time to clean up the ebuild, make some patches for upstream to make newer releases work a bit smoother with Gentoo, and created an overlay. Too bad OpenTTD is hard masked for all versions. Nevertheless, I wanted to share my ebuild with you guys, so I attached my version (and patches) here. The overlay will be published via OpenTTD somewhere next week. Any comments on the ebuilds are very welcome.
Comment 31 Patric Stout 2008-10-16 12:37:49 UTC
Created attachment 168660 [details, diff]
Modified the 'make install' to work with Gentoo
Comment 32 Patric Stout 2008-10-16 12:38:12 UTC
Created attachment 168662 [details, diff]
Makes a Gentoo valid menu-desktop-thingy
Comment 33 Patric Stout 2008-10-16 12:39:04 UTC
Created attachment 168664 [details]
0.6.3 ebuild

This ebuild uses 'make install' from upstream to avoid updating the ebuild every time a file is added for install.
Comment 34 Tomáš Chvátal (RETIRED) gentoo-dev 2008-10-17 07:39:32 UTC
You know that in sum are your patches and ebuild about 2x bigger than previous approach? :D.

Well i will try it today and see how is it working :]
Comment 35 Tomáš Chvátal (RETIRED) gentoo-dev 2008-10-17 19:02:40 UTC
Created attachment 168822 [details]
openttd-0.6.3

Merged stuff from mine local overlay and from Patric.

Patric: hope you wont mind i obsoleted yours and replaced it with this one.
Comment 36 Patric Stout 2008-10-17 22:33:20 UTC
>
> Patric: hope you wont mind i obsoleted yours and replaced it with this one.
> 

That is fine, I am glad you made some nice updates to the ebuild :) I hope you don't mind I pick up yours again to put it in the ebuilds we (as in OpenTTD) publish ;) Anyway, one question about your ebuild:

 emake DESTDIR="${D}" install

The 'DESTDIR' part has absolutely no use for OpenTTD what so ever. So is there any real reason you re-introduced it? (mind that ${D} is feed to OpenTTD make system via --install-dir).

Also, to make it perfectly clear: both patches I attached are already upstream. These two versions are the backported onces to 0.6.3. Any new release of OpenTTD will contain those patches (just so you know ;)).
Comment 37 Tomáš Chvátal (RETIRED) gentoo-dev 2008-10-18 09:03:15 UTC
Aw i missed that
i did diff and patched it together... And this slipped. That DESTDIR="${D}" Has really no use for us.

Btw why you dont use some normal make system? Just curious I dont mean this question as offense.

And i kinda get that the patches will be included since you are one of the devs :D
Comment 38 Tomáš Chvátal (RETIRED) gentoo-dev 2008-10-18 09:04:14 UTC
Patric: And are you including our libiconv.patch?
Comment 39 Patric Stout 2008-10-19 11:45:34 UTC
(In reply to comment #37)
> 
> Btw why you dont use some normal make system? Just curious I dont mean this
> question as offense.
> 

We support many OSes .. and it is kind of impossible to make autoconf work on a few of them, so we simply wrote our own. We know what it does, and we know it works as expected ;) Most people can't say that about their autoconf/automake system :)

(In reply to comment #38)
> Patric: And are you including our libiconv.patch?
> 

This is a tricky one. We have not a single bugreport related to it, so we are unsure if it is a Gentoo only problem, or a more general one. So for now we won't add it, but we are looking into it :)
Comment 40 Patric Stout 2008-10-19 11:47:19 UTC
Created attachment 169074 [details]
openttd-0.6.3

removed DESTDIR from 'emake install' (no use in OpenTTD)
Comment 41 Patric Stout 2008-10-19 12:14:24 UTC
Created attachment 169078 [details]
openttd-0.6.3

it turns out that OpenTTD doesn't require 'iconv' for linux builds. UTF-8 works fine without iconv. iconv is only required for Mac OS X users. If this gives any problems, please let me know.
Comment 42 Patric Stout 2008-10-19 20:11:59 UTC
Created attachment 169122 [details]
openttd-0.6.3

Yet an other small update. Now 'freetype' is a USE-flag, enabled by default (as most users would want it), but possible to disable (if you use a ASCII based language, you most likely don't need it). It also meant using $(use_with) instead of --with-freetype, as --without-freetype is needed in case you compile OpenTTD without freetype, while you have it installed.
Comment 43 Tomáš Chvátal (RETIRED) gentoo-dev 2008-10-20 16:11:23 UTC
Actualy iconv is needed if one is not using utf system....
So iconv stays :D Btw are you on irc we can takl this out and then post resulting ebuild.
Comment 44 Tomáš Chvátal (RETIRED) gentoo-dev 2008-10-22 19:48:26 UTC
Created attachment 169474 [details]
openttd-0.6.3

Ok merging your patches and iconv stays ;]
Comment 45 Tomáš Chvátal (RETIRED) gentoo-dev 2008-10-22 20:04:16 UTC
Created attachment 169482 [details]
libiconv.patch

Upstream patch for libiconv, will be in next release.
Comment 46 Tomáš Chvátal (RETIRED) gentoo-dev 2008-10-22 21:35:51 UTC
Created attachment 169504 [details]
openttd-0.6.3

Hopefuly final one, since we reached some nice consensus on openttd irc channel, thanks all pple there specialy you Patric.
Comment 47 Tomáš Chvátal (RETIRED) gentoo-dev 2008-10-22 22:05:35 UTC
Created attachment 169508 [details]
libiconv.patch

Well trac was not cooperating correctly so this should be correct and working libiconv patch
Comment 48 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2008-10-23 04:31:39 UTC
0.6.3 in the tree now. NOT removed from package.mask yet, could folk please test it more?
Comment 49 Robert Buchholz (RETIRED) gentoo-dev 2008-10-23 11:40:47 UTC
(In reply to comment #48)
> 0.6.3 in the tree now. NOT removed from package.mask yet, could folk please
> test it more?

the p.mask is security related and the 0.6.3 version is not affected. what is your timeline / expected results of the tests?
Comment 50 Tupone Alfredo gentoo-dev 2008-11-10 20:40:42 UTC
openttd-0.6.3 is unmasked (25 oct 2008)