Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 213698 - setting makeopts in src_unpack does not work with keepwork
Summary: setting makeopts in src_unpack does not work with keepwork
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core - Interface (emerge) (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 216231
  Show dependency tree
 
Reported: 2008-03-17 13:56 UTC by Markus Duft (RETIRED)
Modified: 2008-04-04 22:24 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Duft (RETIRED) gentoo-dev 2008-03-17 13:56:51 UTC
in dev-utils/git the some make options are set in the src_unpack function. this does not work when building with keepwork, and stopping somewhere in the build process, and restarting.

when moving the function call for setting the make options from src_unpack to src_compile, everything works as expected.

Reproducible: Always

Steps to Reproduce:
1. build git with FEATURES="keepwork"
2. cancel building somewhere while compiling.
3. start building again

Actual Results:  
the make options (which are fital for building git correctly (argl :) )) are re-set to the defaults, since they are not set anymore on the second compile (src_unpack not called there...)

Expected Results:  
...
Comment 1 Zac Medico gentoo-dev 2008-03-18 01:48:01 UTC
(In reply to comment #0)
> when moving the function call for setting the make options from src_unpack to
> src_compile, everything works as expected.

This is because keepwork does not preserve ${T}/environment. For maximum consistency, I think change the keepwork behavior so that the make options that are set inside src_unpack will not be lost.
Comment 2 Zac Medico gentoo-dev 2008-04-04 22:24:05 UTC
This is fixed in 2.1.5_rc1.