Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 213374 - ebump and echangelog should use a single variable (or pair of)
Summary: ebump and echangelog should use a single variable (or pair of)
Status: RESOLVED TEST-REQUEST
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Third-Party Tools (show other bugs)
Hardware: All Linux
: High minor
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 268725
  Show dependency tree
 
Reported: 2008-03-14 11:16 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2009-06-29 19:50 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2008-03-14 11:16:54 UTC
It seems strange to me that ebump and echangelog can't share the user name and email address, but the manpages report:

ebump(1)
       ~/.gentoo/gentool-env From this file, ebump will load the env vars AUTHORNAME and AUTHOREMAIL, which are used to generate proper ChangeLog entries.

echangelog(1)
       ECHANGELOG_USER
           If echangelog can’t figure out your username for the entry, you should set ECHANGELOG_USER.  For example, export ECHANGELOG_USER="Aron Griffis
           <agriffis@gentoo.org>"


It would be nice if I didn't have to repeat my identity again (I already have it in environment for git, twice, and for Mercurial).
Comment 1 SpanKY gentoo-dev 2008-03-14 11:28:01 UTC
better to start using a project-wide variable

GENTOO_AUTHOR_NAME
GENTOO_AUTHOR_EMAIL
GENTOO_COMMITTER_NAME
GENTOO_COMMITTER_EMAIL
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2008-03-14 11:35:46 UTC
Works for me, having those differentiated is also a good idea if we're going to stress more on proxy maintainership.
Comment 3 Christian Ruppert (idl0r) gentoo-dev 2009-04-30 21:50:59 UTC
(In reply to comment #1)
> better to start using a project-wide variable
> 
> GENTOO_AUTHOR_NAME
> GENTOO_AUTHOR_EMAIL
> GENTOO_COMMITTER_NAME
> GENTOO_COMMITTER_EMAIL
> 

Hey guys,

I added support for those variables.
So you might want take a look at http://sources.gentoo.org/viewcvs.py/gentoolkit?rev=561&view=rev
Feel free to test :)
Comment 4 Christian Ruppert (idl0r) gentoo-dev 2009-05-07 09:04:07 UTC
gentoolkit-dev-0.2.6.11 has been released. I will close after independent
verification that the bug is fixed.