Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 213073 - x11-apps/xdm-1.1.7 installs in /@DESTDIR@
Summary: x11-apps/xdm-1.1.7 installs in /@DESTDIR@
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords: Inclusion
: 222493 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-03-11 21:11 UTC by Sandro Bonazzola
Modified: 2008-06-09 04:41 UTC (History)
10 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix dumb inclusion (xdm-1.1.7-inclusion.patch,759 bytes, patch)
2008-03-14 14:29 UTC, Sergey Dryabzhinsky
Details | Diff
Remove all DESTDIR (xdm-1.1.7-inclusion.patch,749 bytes, patch)
2008-03-16 07:20 UTC, Sergey Dryabzhinsky
Details | Diff
Ebuild update (xdm-1.1.7-r1.ebuild.diff,660 bytes, patch)
2008-03-16 07:21 UTC, Sergey Dryabzhinsky
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sandro Bonazzola 2008-03-11 21:11:57 UTC
# emerge -pv xdm
[ebuild   R   ] x11-apps/xdm-1.1.7  USE="ipv6 pam xprint -debug" 0 kB

# qlist xdm
/@DESTDIR@/usr/share/X11/app-defaults/Chooser
/etc/pam.d/xdm
/etc/X11/xdm/Xservers
[cut]

The following file is clearly in the wrong place:
/@DESTDIR@/usr/share/X11/app-defaults/Chooser

# emerge --info
Portage 2.1.4.4 (default-linux/amd64/2007.0, gcc-4.2.3, glibc-2.7-r1, 2.6.24-gentoo-r3 x86_64)
=================================================================
System uname: 2.6.24-gentoo-r3 x86_64 AMD Athlon(tm) 64 Processor 3500+
Timestamp of tree: Tue, 11 Mar 2008 16:46:01 +0000
distcc 2.18.3 x86_64-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled]
ccache version 2.4 [enabled]
app-shells/bash:     3.2_p33
dev-java/java-config: 1.3.7, 2.1.5
dev-lang/python:     2.5.1-r5
dev-python/pycrypto: 2.0.1-r6
dev-util/ccache:     2.4-r7
sys-apps/baselayout: 1.12.11.1
sys-apps/sandbox:    1.2.18.1-r2
sys-devel/autoconf:  2.13, 2.61-r1
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10.1
sys-devel/binutils:  2.18-r1
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   1.5.26
virtual/os-headers:  2.6.24
ACCEPT_KEYWORDS="amd64 ~amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=athlon64 -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/config /var/lib/hsqldb"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/initng/daemon /etc/initng/net /etc/initng/system /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild /etc/splash /etc/terminfo /etc/texmf/web2c /etc/udev/rules.d"
CXXFLAGS="-march=athlon64 -O2 -pipe"
DISTDIR="/home/ftp/distfiles"
EMERGE_DEFAULT_OPTS="--with-bdeps y"
FEATURES="ccache collision-protect cvs distlocks elog java-strict metadata-transfer multilib-strict sandbox sfperms sign strict stricter unmerge-orphans userfetch userpriv usersandbox"
GENTOO_MIRRORS="ftp://mirror.switch.ch/mirror/gentoo/ "
LANG="it_IT.UTF-8"
LC_ALL="it_IT.UTF-8"
LINGUAS="it"
PKGDIR="/home/ftp/packages"
PORTAGE_COMPRESS="bzip2"
PORTAGE_COMPRESS_FLAGS="-9"
PORTAGE_RSYNC_EXTRA_OPTS=" --timeout=800 --progress "
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/overlays/portage"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="3dnow 3dnowext 3ds 7zip X a52 aac acl acpi alsa amd64 amr aoss apache2 arts asf audiofile avahi bash-completion berkdb bl branding bzip2 cairo cal3d caps ccache cdb cddb cdparanoia cdr cg chroot cli cpudetection cracklib crypt css cups curl custom-cflags dbus devhelp dga directfb disk-partition djvu dmi dovecot-sasl dri dts dv dvd dvdr dvdread emerald encode epydoc erandom esd exif expat extrafilters fame ffmpeg firefox flac fltk foomaticdb fortran gd gdbm ggi gif gimp gimpprint glib glibc-omitfp glitz glut gmp gnokii gnome gnutls gphoto2 gpm graphviz gsm gtk gtkhtml guile hal hbci howl-compat iconv idn ieee1394 imagemagick imlib ipv6 isc isdnlog ithreads java javacomm javascript jbig jce jikes jpeg jpeg2k justify kde kdeenablefinal kdehiddenvisibility kqemu lcms ldap libcaca libnotify linuxthreads-tls lm_sensors logitech-mouse logrotate lzo mad mailwrapper matroska mbox mdb mhash midi mikmod mjpeg mmap mmx mmxext mng motif mozdevelop mp3 mpeg mpm-worker mppe-mppc msn mudflap musepack musicbrainz mysql ncurses nfs nls nptl nptlonly nsplugin numeric nvidia odbc ode offensive ofx ogg ogre on-the-fly-crypt openexr opengl openmp oss pam parport pch pcre pdf perl php png povray ppds pppd pulseaudio python qa qt3 qt3support qt4 quicktime quotes rdesktop readline reflection resolvconf restrict-javascript rtc samba scanner sdl session slang slp smime sndfile snmp speex spell spl sse sse2 ssl startup-notification subversion svg sysfs syslog tcltk tcpd test tetex tga theora threads tidy tiff timidity tk truetype unicode usb userlocales utempter v4l v4l2 vcd vda vorbis vorbis-psy wma wmf wmp xattr xcomposite xforms xine xinerama xml xorg xpm xprint xscreensaver xv xvid xvmc yv12 zeroconf zlib" ALSA_CARDS="intel8x0" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" APACHE2_MPMS="worker" CAMERAS="canon directory panasonic pccam300" ELIBC="glibc" FOO2ZJS_DEVICES="hp1005" INPUT_DEVICES="mouse evdev keyboard" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="it" USERLAND="GNU" VIDEO_CARDS="nvidia nv"
Unset:  CPPFLAGS, CTARGET, INSTALL_MASK, LDFLAGS, MAKEOPTS
Comment 1 Sandro Bonazzola 2008-03-12 18:16:48 UTC
Here is a patch to solve the issue.

--- xdm-1.1.7/Makefile.am       2008-03-07 23:03:25.000000000 +0100
+++ /tmp/xdm-1.1.7/Makefile.am  2008-03-12 19:02:46.736574000 +0100
@@ -151,7 +151,7 @@

 # App default files  (*.ad)

-appdefaultdir = @DESTDIR@@appdefaultdir@
+appdefaultdir = ${DESTDIR}@appdefaultdir@

 APPDEFAULTFILES = Chooser
Comment 2 Norberto Bensa 2008-03-12 21:48:04 UTC
Hello
Is there anybody in there?
Just nod if you can here me
Is there any dev at home reading this?

I've emerged this three days ago. Nobody had hit this one yet? 

Comment 3 Donnie Berkholz (RETIRED) gentoo-dev 2008-03-12 23:11:26 UTC
Huh, that's weird. I'm adding the Inclusion keyword to note that this bug contains a fix.
Comment 4 Markus Dittrich (RETIRED) gentoo-dev 2008-03-13 12:51:40 UTC
I hit the same problem last night - rather strange.
Comment 5 Sergey Dryabzhinsky 2008-03-14 14:29:37 UTC
Created attachment 146124 [details, diff]
Fix dumb inclusion

Some fixup... but I thunk that we need here to run eautoreconf...
Comment 6 Donnie Berkholz (RETIRED) gentoo-dev 2008-03-15 23:04:06 UTC
I dont think the DESTDIR entry should be in there at all, that should be handled automatically later. If you remove @DESTDIR@ or $(DESTDIR) and set SNAPSHOT="yes", does it work?
Comment 7 Sergey Dryabzhinsky 2008-03-16 07:16:44 UTC
Yes, it's work.
Comment 8 Sergey Dryabzhinsky 2008-03-16 07:20:40 UTC
Created attachment 146270 [details, diff]
Remove all DESTDIR

Remove all DESTDIR entries
Comment 9 Sergey Dryabzhinsky 2008-03-16 07:21:48 UTC
Created attachment 146271 [details, diff]
Ebuild update

Set SNAPSHOT="yes" and add patch
Comment 10 Sandro Bonazzola 2008-03-18 19:00:07 UTC
(In reply to comment #8 and #9)
Attached patches works fine for me.
Comment 11 Norberto Bensa 2008-03-24 18:53:07 UTC
Anyone?

Comment 12 Norberto Bensa 2008-04-09 04:38:51 UTC
There's a fix attached to this bug but no one added it to portage.
Is there something wrong? I mean, something beyond Gentoo? Can we help in some form or another?
Comment 13 Donnie Berkholz (RETIRED) gentoo-dev 2008-04-09 07:34:30 UTC
(In reply to comment #12)
> There's a fix attached to this bug but no one added it to portage.
> Is there something wrong? I mean, something beyond Gentoo? Can we help in some
> form or another?

It's not clear to me which fix (if either) is correct. This needs to get figured out, rather than just adding something that works, so that the fix can go upstream.
Comment 14 Sandro Bonazzola 2008-04-09 17:39:06 UTC
(In reply to comment #13)

> It's not clear to me which fix (if either) is correct. This needs to get
> figured out, rather than just adding something that works, so that the fix can
> go upstream.

Using patch submitted with comment #8 and comment #9 works for me as stated in comment #10.
I can understand that it's better study it better before send it upstream, but if this can't be fixed until then, then mask the package until it's fixed.
Having to search in bugzilla for finding a patch and apply manually the patch for having it working doesn't seem either a good thing from my point of view.
This is just an opinion, not a criticism.
Comment 15 harry.tx 2008-05-03 11:57:37 UTC
(In reply to comment #8)
> Created an attachment (id=146270) [edit]
> Remove all DESTDIR
> 
> Remove all DESTDIR entries
> 

Does work for me too. I'm curious why patch isn't included in official portage.
Comment 16 happyfool 2008-05-08 15:15:09 UTC
I don't suppose someone could commit a temporary fix for this, perhaps just in postinstall? While it's getting pushed upstream? Without a new -r version if need be?

If nothing else, it demonstrates a huge QA issue in gentoo. After that gentoo is dying scare last year.. Package that everybody not running a server will have installed, creates a new root-level directory..
Comment 17 Donnie Berkholz (RETIRED) gentoo-dev 2008-05-09 06:03:36 UTC
(In reply to comment #16)
> If nothing else, it demonstrates a huge QA issue in gentoo. After that gentoo
> is dying scare last year.. Package that everybody not running a server will
> have installed, creates a new root-level directory..

There are reasons it's not marked stable... if you use testing, you can't expect perfection, especially in little things that really don't matter functionally.
Comment 18 Donnie Berkholz (RETIRED) gentoo-dev 2008-05-18 01:55:21 UTC
*** Bug 222493 has been marked as a duplicate of this bug. ***
Comment 19 Patrizio Bassi 2008-06-07 12:22:14 UTC
no news here?
Comment 20 Sergiy Borodych 2008-06-07 15:13:48 UTC
I see in x11-apps/xdm-1.1.8 for me all OK
try it
Comment 21 Patrizio Bassi 2008-06-08 13:11:40 UTC
tried 1.1.8, it's ok. this bug can be closed
Comment 22 Sergey Dryabzhinsky 2008-06-08 13:19:48 UTC
(In reply to comment #21)
> tried 1.1.8, it's ok. this bug can be closed

Confirm...
Comment 23 Donnie Berkholz (RETIRED) gentoo-dev 2008-06-09 04:41:54 UTC
Thanks for waiting till it got fixed upstream and testing to confirm, folks.