Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 212080 - [PATCH] Fix "zing" symbols for protected config files skipped because they were previously merged
Summary: [PATCH] Fix "zing" symbols for protected config files skipped because they we...
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Portage team
Keywords: InVCS
Depends on:
Blocks: 216231
  Show dependency tree
Reported: 2008-03-02 15:57 UTC by Russell Yanofsky
Modified: 2008-04-04 19:40 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

confmem-zing-fix.patch (confmem-zing-fix.patch,417 bytes, patch)
2008-03-02 15:58 UTC, Russell Yanofsky
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Russell Yanofsky 2008-03-02 15:57:50 UTC
When the --noconfmem option is not specified, portage skips the creation of ._cfg####_ files when their checksums are already in the CONFIG_MEMORY_FILE list (/var/lib/portage/config). The problem is that current versions of portage don't give any indication that they are skipping these files. The attached patch fixes the "zing" symbols for these files so install output for these files looks like:

    -o- /etc/some/conf/file

instead of:

    >>> /etc/some/conf/file

This appears to have been the original intention of the code in the dblink.mergeme function, but there's an extra line in there that overwrites the "-o-" symbol right before it is printed. The patch removes this line of code since it is not correct for this case and is redundant for every other case.

Reproducible: Always

Steps to Reproduce:
This problem can be reproduced for pretty much any package with a configuration file. The steps below use the net-misc/rsync package as an example.

1. Emerge net-misc/rsync
2. Edit the /etc/rsyncd.conf file so its checksum changes
3. Emerge net-misc/rsync again.
Actual Results:  
Output from the final merge step will show:

   >>> /etc/rsyncd.conf

This happens even though the /etc/rsyncd.conf merge was skipped (no ._cfg file created).

Expected Results:  
Since it skipped the file, portage should have printed:

   -o- /etc/rsyncd.conf

This is the result you see after applying the patch.
Comment 1 Russell Yanofsky 2008-03-02 15:58:44 UTC
Created attachment 145092 [details, diff]
Comment 2 Marius Mauch (RETIRED) gentoo-dev 2008-03-03 20:29:36 UTC
fixed, and changed the symbol to '---' as I don't think this deserves a special one.
Comment 3 Marius Mauch (RETIRED) gentoo-dev 2008-03-20 18:15:08 UTC
This is supposed to be fixed in portage-2.2_pre5 or earlier.
Comment 4 Marius Mauch (RETIRED) gentoo-dev 2008-03-20 18:15:55 UTC
This is supposed to be fixed in portage-2.2_pre5 or earlier.