Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 208827 - x11-apps/xman patch to allow xman to use bzip to decompress man pages.
Summary: x11-apps/xman patch to allow xman to use bzip to decompress man pages.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords: Inclusion
Depends on:
Blocks:
 
Reported: 2008-02-04 10:13 UTC by Bob Raitz
Modified: 2008-05-28 07:50 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to give bzip decompression ability to xman (xman-bzip2.patch,4.25 KB, patch)
2008-02-04 10:21 UTC, Bob Raitz
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bob Raitz 2008-02-04 10:13:35 UTC
The man files under Gentoo use bzip for compression. Xman assumes gzip compression, and therefore will not decompress properly unless patched. When patched, xman will decompress the bzipped files, and display them properly.

Reproducible: Always

Steps to Reproduce:
1.use standard xman ebuild
2.open a man page using xman.
3.be greeted by lots of strange characters.

Actual Results:  
After patching with the patch I am going to submit, xman worked as expected.

Expected Results:  
Shown the man pages properly decompressed and formatted.
Comment 1 Bob Raitz 2008-02-04 10:21:25 UTC
Created attachment 142641 [details, diff]
patch to give bzip decompression ability to xman

This patch file came from this discussion in the forum: 
http://forums.gentoo.org/viewtopic-t-571249-highlight-xman.html .
The path to this patch is:
http://cvs.mandriva.com/cgi-bin/viewvc.cgi/SPECS/XFree86/XFree86-4.2.99.3-xman-bzip2.patch?view=log

I installed the patch manually, and compiled xman manually (not using emerge). Once installed, it worked as expected. Xman was able to decompress and properly display formatted man pages. While it seems that few users use xman, there are those of us who do, and it's nice to have it work properly.

Thanks for your time and consideration.

Blessed be!
Pappy
Comment 2 Bob Raitz 2008-02-04 10:22:38 UTC
Note, the patch will have to be modified to work with portage, but you already knew that.
Comment 3 Donnie Berkholz (RETIRED) gentoo-dev 2008-02-06 08:05:25 UTC
I'm not going to take that patch until it's been accepted upstream. I don't understand why it's not there already. Could you politely suggest to the Mandriva people that they submit it upstream (bugs.freedesktop.org, xorg product) or do it yourself?

Once it's been committed upstream, please reopen this bug. Thanks!
Comment 4 Bob Raitz 2008-02-06 09:55:27 UTC
(In reply to comment #3)
> I'm not going to take that patch until it's been accepted upstream. I don't
> understand why it's not there already. Could you politely suggest to the
> Mandriva people that they submit it upstream (bugs.freedesktop.org, xorg
> product) or do it yourself?
> 
> Once it's been committed upstream, please reopen this bug. Thanks!
> 
I have sent it upstream. The link to the x.org bug report has been added to the forum page that was the source for this bug report. 

Thank you for your time and consideration.

Blessed be!
Pappy
Comment 5 Bob Raitz 2008-02-09 07:20:13 UTC
This bug/patch request has been sent upstream. The upstream bug number is 
http://bugs.freedesktop.org/show_bug.cgi?id=14400 . As per the request by Donnie Berkholz, the bug has been sent upstream, and I am re-opening it, as well. See comment #3 for details.

Blessed be!
Pappy
Comment 6 Bob Raitz 2008-02-09 21:07:53 UTC
I received a reply from upstream that the patch is currently under consideration. I requested that it be accepted.

Blessed be!
Pappy
Comment 7 James Cloos 2008-02-10 03:05:51 UTC
I pushed this patch (applied by hand — patch(1) was unable to apply it to git master) to the xman(1x) repo in git commit dbfa16889ae66d5880e23c9a63f8385896512020 and expect to be part of xman 1.0.4.
Comment 8 Bob Raitz 2008-02-10 07:50:09 UTC
(In reply to comment #7)
> I pushed this patch (applied by hand — patch(1) was unable to apply it to git
> master) to the xman(1x) repo in git commit
> dbfa16889ae66d5880e23c9a63f8385896512020 and expect to be part of xman 1.0.4.
> 

I guess that's a good thing. For now, as long as it works for me, I'm fine. Others who are enterprising can also apply it manually, and enjoy xman functionality. 

I am glad to hear that it is slated for inclusion in 1.0.4. I'd be more than happy to offer my systems to test this version when it comes out, or in beta.

Blessed be!
Pappy
Comment 9 Bob Raitz 2008-02-12 11:40:49 UTC
There is now a resolution to the bug upstream. The following comment was added to the x.org bugzilla.

BEGIN FORWARDED COMMENT:

> Thank you very much, and if you need a volunteer to test it, I have three
> Gentoo systems ready and waiting to try it.

To test it you can clone the xman git repo via:

git://anongit.freedesktop.org/git/xorg/app/xman

or

http://anongit.freedesktop.org/git/xorg/app/xman

and run:

 ./autogen.sh && make && sudo make install

Or, for a Gentoo box you can clone my as yet partial live-x11 overlay via:

git://people.freedesktop.org/~cloos/live-x11.git

or

http://people.freedesktop.org/~cloos/live-x11.git

or, if you just want the single ebuild you can grab that via cgit at:

http://cgit.freedesktop.org/~cloos/live-x11/tree/x11-apps/xman/xman-9999.ebuild

for an HTML page or, for just the text/plain file:

http://cgit.freedesktop.org/~cloos/live-x11/blob/?id=3562a073836d6cffc7a88b855a648bad3cda0e01

I’m running that now and it works fine for me.  (I do not use xprint so I
haven’t tested the xprint support in xman.  But everything else was fine.)

END FORWARDED COMMENT.

I have installed the git version, and it works. The ebuild listed above comes up as masked by corruption. 

Perhaps as a means of resolving this issue, the ebuild could be rewritten by a Gentoo developer so it doesn't come up as masked by corruption. Perhaps it could even placed in the portage tree, if only for those willing to risk beta-testing it in order to have a truly functional version of xman.

Thank you for your time, consideration, and effort in resolving this issue.

Blessed be!
Pappy
Comment 10 Donnie Berkholz (RETIRED) gentoo-dev 2008-05-09 07:26:34 UTC
I'm marking this fixed, because it's an upstream issue that has been fixed upstream and will be in the next release, which should happen anytime now.
Comment 11 Bob Raitz 2008-05-09 08:18:16 UTC
Cool. Thanks to all.

Blessed be!
Pappy
Comment 12 Bob Raitz 2008-05-27 06:50:01 UTC
(In reply to comment #10)
> I'm marking this fixed, because it's an upstream issue that has been fixed
> upstream and will be in the next release, which should happen anytime now.
> 
I was just wondering when it was going to hit. I'm still running the non-gentoo version, which works just fine, I might add. I'd like to get back to having everything set up on my system set up via portage.

N-E_WAY, just checking to see when it's planned to hit portage.

Blessed be!
Pappy
Comment 13 Donnie Berkholz (RETIRED) gentoo-dev 2008-05-28 07:28:49 UTC
(In reply to comment #12)
> (In reply to comment #10)
> > I'm marking this fixed, because it's an upstream issue that has been fixed
> > upstream and will be in the next release, which should happen anytime now.
> > 
> I was just wondering when it was going to hit. I'm still running the non-gentoo
> version, which works just fine, I might add. I'd like to get back to having
> everything set up on my system set up via portage.
> 
> N-E_WAY, just checking to see when it's planned to hit portage.

Whenever upstream pushes out a release of xman. I've seen a bunch of stuff getting released in the past week or two, so it might be sometime soon.
Comment 14 Bob Raitz 2008-05-28 07:50:04 UTC
> Whenever upstream pushes out a release of xman. I've seen a bunch of stuff
> getting released in the past week or two, so it might be sometime soon.
> 
Nice. Could you post a heads-up, please...just enough to have an email telling me it's here. I have a thread that I want to update as soon as the update hits. It's a group of users waiting for the new xman.

Thanks for your time and effort thus far.

Blessed be!
Pappy