Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 206285 - media-libs/jpeg (exifautotran) preserve timestamp feature and others
Summary: media-libs/jpeg (exifautotran) preserve timestamp feature and others
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PATCH, PMASKED
: 181944 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-01-17 05:01 UTC by Israel G. Lugo
Modified: 2021-01-30 12:00 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
add feature to preserve file timestamps, various fixes (exifautotran-ilugo.patch,1.87 KB, patch)
2008-01-17 05:04 UTC, Israel G. Lugo
Details | Diff
new patch version, forgot something (exifautotran-ilugo.patch,1.98 KB, patch)
2008-01-17 15:43 UTC, Israel G. Lugo
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Israel G. Lugo 2008-01-17 05:01:01 UTC
I am attaching a patch to implement the following improvements to the exifautotran program:

17 Jan 2008; Israel G. Lugo <israel.lugo@lugosys.com>
 - Add --preserve option to preserve file modification time.
 - Fix file permissions being altered.
 - Only replace original file after everything is known to have gone well.
 - Fix possibility of data loss; replace original file atomically instead
   of deleting it then trying to move the new one in place.
 - Add signal trap to perform cleanup if interrupted (thanks to
   Debian's exifautotran).
 - Improve robustness:
     - use mktemp instead of hardcoded temporary file
     - quote all expansions of user-controlled variables
Comment 1 Israel G. Lugo 2008-01-17 05:04:45 UTC
Created attachment 141097 [details, diff]
add feature to preserve file timestamps, various fixes
Comment 2 Israel G. Lugo 2008-01-17 05:27:58 UTC
I'm CC'ing graphics@gentoo.org since they're listed as maintainers for this package. I would've assigned the bug myself but I don't see the Reassign option anywhere...
Comment 3 Israel G. Lugo 2008-01-17 15:43:08 UTC
Created attachment 141144 [details, diff]
new patch version, forgot something

Posting a new patch, forgot to skip the file in case jpegexiforient was unable to reset the orientation to 1 (would leave the file in an inconsistent rotation state).
Comment 4 Jakub Moc (RETIRED) gentoo-dev 2008-02-05 10:06:08 UTC
*** Bug 181944 has been marked as a duplicate of this bug. ***
Comment 5 Samuli Suominen (RETIRED) gentoo-dev 2009-08-23 06:35:35 UTC
Israel, starting from >=media-libs/jpeg-7 we are using a Debian copy of exifautotran.

-> This bug should be reported to Debian bugtracking system.
Comment 6 SpanKY gentoo-dev 2009-08-23 07:02:22 UTC
you dont have to subscribe to anything, just e-mail submit@bugs.debian.org

some notes on the patch:
 - looks like a typo as you use "--pretend" instead of "--preserve"
 - the mktemp and signal stuff isnt needed anymore as it's included
Comment 7 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-01-30 12:00:25 UTC
Removing.