Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 204668 - econf fails when WORKDIR has spaces
Summary: econf fails when WORKDIR has spaces
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core - Ebuild Support (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 200044
  Show dependency tree
 
Reported: 2008-01-06 20:50 UTC by Santiago M. Mola (RETIRED)
Modified: 2008-01-12 03:38 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild.sh-epatch-source-spaces.patch (ebuild.sh-epatch-source-spaces.patch,787 bytes, patch)
2008-01-06 20:52 UTC, Santiago M. Mola (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Santiago M. Mola (RETIRED) gentoo-dev 2008-01-06 20:50:01 UTC
Here's the offending part:
                   
for x in $(find "${WORKDIR}" -type f '(' -name config.guess -o -name config.sub ')') ; do
    vecho " * econf: updating ${x/${WORKDIR}\/} with /usr/share/gnuconfig/${x##*/}"
    cp -f /usr/share/gnuconfig/${x##*/} ${x}
done

which is broken when paths have spaces.
Comment 1 Santiago M. Mola (RETIRED) gentoo-dev 2008-01-06 20:52:05 UTC
Created attachment 140314 [details, diff]
ebuild.sh-epatch-source-spaces.patch

Use find blah | while read x.

This implies executing the code in a subshell. If this is a problem here, it could be workaround'ed with IFS.
Comment 2 Zac Medico gentoo-dev 2008-01-11 00:06:46 UTC
Thanks, this is in svn.
Comment 3 Zac Medico gentoo-dev 2008-01-12 03:38:36 UTC
This has been released in 2.1.4.