197835 – cannot validate preferences with net-p2p/nicotine+-1.2.9

Bug 197835 - cannot validate preferences with net-p2p/nicotine+-1.2.9

Summary: cannot validate preferences with net-p2p/nicotine+-1.2.9

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Gentoo net-p2p team

URL:
Whiteboard:
Keywords:

Depends on:	199466
Blocks:
	Show dependency tree

Reported:	2007-11-01 23:53 UTC by Julien Allanos (RETIRED)
Modified:	2008-03-31 14:28 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
nicotine+-1.2.9-locale-handling.patch (nicotine+-1.2.9-locale-handling.patch,2.67 KB, patch) 2007-12-04 09:42 UTC, Santiago M. Mola (RETIRED)	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Julien Allanos (RETIRED) gentoo-dev

2007-11-01 23:53:13 UTC

Clicking on Validate in the Preferences window fails with the following:

Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/pynicotine/gtkgui/frame.py", line 1560, in OnSettingsClosed
    output = self.settingswindow.GetSettings()
  File "/usr/lib/python2.4/site-packages/pynicotine/gtkgui/settingswindow.py", line 2215, in GetSettings
    sub = page.GetSettings()
  File "/usr/lib/python2.4/site-packages/pynicotine/gtkgui/settingswindow.py", line 1207, in GetSettings
    return {
AttributeError: 'NoneType' object has no attribute 'lower'

Tested with :

dev-lang/python-2.4.4-r5 (USE: ipv6 ncurses readline ssl)
dev-python/pygtk-2.10.6 (USE: opengl)

and ~/.nicotine removal. nicotine+-1.2.8 works fine.

Comment 1 Santiago M. Mola (RETIRED) gentoo-dev

2007-11-05 12:58:14 UTC

'Validate' means 'OK' or 'Apply'? And I guess 'Preferences' is actually 'Settings'. Are you using English locale? Please do it, so I don't end confused ;-)

I couldn't reproduce it yet, but I've quite a few things to try.

Comment 2 Julien Allanos (RETIRED) gentoo-dev

2007-11-25 12:30:42 UTC

I'm using fr_FR.UTF-8 :) With LC_ALL=C there is no problem.

Comment 3 Santiago M. Mola (RETIRED) gentoo-dev

2007-12-01 14:19:07 UTC

Thanks, reported upstream: http://www.nicotine-plus.org/ticket/223

Comment 4 Julien Allanos (RETIRED) gentoo-dev

2007-12-01 21:58:04 UTC

Great ! Thank you :)

Comment 5 Santiago M. Mola (RETIRED) gentoo-dev

2007-12-04 09:04:18 UTC

Fixed upstream: http://nicotine-plus.org/changeset/652

Comment 6 Santiago M. Mola (RETIRED) gentoo-dev

2007-12-04 09:42:50 UTC

Created attachment 137696 [details, diff]
nicotine+-1.2.9-locale-handling.patch

@dju: could you test if the patch solves your problem?

Comment 7 Raúl Porcel (RETIRED) gentoo-dev

2008-02-25 14:21:36 UTC

ping...

Comment 8 Santiago M. Mola (RETIRED) gentoo-dev

2008-03-31 14:28:57 UTC

Fixed in 1.2.9-r1, tried with fr locale and works. This should be stable candidate in 30 days (but will have to check bug #197117).