Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 195920 - portage-2.1.3.13: etc-update hangs when using an editor
Summary: portage-2.1.3.13: etc-update hangs when using an editor
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Tools (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
: 195949 (view as bug list)
Depends on:
Blocks: 194041
  Show dependency tree
 
Reported: 2007-10-15 07:47 UTC by Steve
Modified: 2007-11-09 02:15 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Steve 2007-10-15 07:47:48 UTC
Using and editor, like vimdiff, as the diff_command in /etc/etc-update.conf causes etc-update to hang due to the sanity check (redirecting vim to /dev/null) :

if ! diff_command "${TMP}"/.diff-test-1 "${TMP}"/.diff-test-2 &> /dev/null ; then
    echo "ERROR: '${diff_command}' does not seem to work, aborting"
    exit 1
fi

Reproducible: Always

Steps to Reproduce:
1. Set diff_command="vim -d %file1 %file2", using_editor=1, pager=""
2. run etc-update


Actual Results:  
etc-update hangs, needs a 'kill' to stop it

Expected Results:  
Updated config files
Comment 1 Mark Dominik Bürkle 2007-10-15 14:49:13 UTC
Yep: the vimdiff command is waiting for input. But it will never ask the user as its output is /dev/null.

Workaround: just write ":qa" (and <return>) to end the sanity check
(or whatever Your $diff_command is expecting for a normal finish).

etc-update is running normally after the sanity check is passed.

Sample output with "userspace workaround":)

#>> etc-update
:qa
Scanning Configuration files...
Exiting: Nothing left to do; exiting. :)
#>>

Kind regards,
Dominik
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2007-10-15 18:41:54 UTC
*** Bug 195949 has been marked as a duplicate of this bug. ***
Comment 3 Zac Medico gentoo-dev 2007-10-15 20:25:04 UTC
This is fixed in 2.1.3.14.
Comment 4 Jonathan Stringer 2007-11-09 02:14:06 UTC
I have this same problem in portage-2.1.3.19 (on amd64)

emerge --info:
Portage 2.1.3.19 (default-linux/amd64/2007.0/desktop, gcc-4.1.2, glibc-2.6.1-r0, 2.6.22-gentoo-r8 x86_64)
=================================================================
System uname: 2.6.22-gentoo-r8 x86_64 AMD Athlon(tm) 64 X2 Dual Core Processor 4200+
Timestamp of tree: Fri, 09 Nov 2007 00:16:01 +0000
app-shells/bash:     3.2_p17
dev-java/java-config: 1.3.7, 2.0.33-r1
dev-lang/python:     2.4.4-r6
dev-python/pycrypto: 2.0.1-r6
sys-apps/baselayout: 1.12.9-r2
sys-apps/sandbox:    1.2.18.1-r2
sys-devel/autoconf:  2.13, 2.61-r1
sys-devel/automake:  1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10
sys-devel/binutils:  2.18-r1
sys-devel/gcc-config: 1.3.16
sys-devel/libtool:   1.5.24
virtual/os-headers:  2.6.22-r2
ACCEPT_KEYWORDS="amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=athlon64 -O2 -pipe -msse3"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/config"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/revdep-rebuild /etc/terminfo /etc/udev/rules.d"
CXXFLAGS="-march=athlon64 -O2 -pipe -msse3"
DISTDIR="/usr/portage/distfiles"
FEATURES="distlocks metadata-transfer sandbox sfperms strict unmerge-orphans userfetch"
GENTOO_MIRRORS="http://ftp.swin.edu.au/gentoo http://public.planetmirror.com/pub/gentoo/ http://mirror.pacific.net.au/linux/Gentoo http://mirror.isp.net.au/ftp/pub/gentoo/ ftp://ftp.swin.edu.au/gentoo "
LANG="en_NZ.UTF-8"
LINGUAS="en ja"
MAKEOPTS="-j4"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --filter=H_**/files/digest-*"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.au.gentoo.org/gentoo-portage"
USE="3dnow 3dnowext X a52 aac acl acpi alsa amd64 anthy berkdb bitmap-fonts bzip2 cairo cddb cdr cjk cli cracklib crypt cups daap dbus dhcp directfb dri dvd dvdr dvdread eds emboss encode evo fam firefox flac fortran gdbm geoip gif glitz gpm hal iconv imlib immqt ipod irc isdnlog jabber jack jack-tmpfs java jingle joystick jpeg kde kerberos ldap libsamplerate lm_sensors logitech-mouse mad midi mikmod mmx mmxext mp3 mp4 mpeg msn mudflap musicbrainz ncurses nls nptl nptlonly nsplugin nvidia ogg openal opengl openmp oss pam pcre pdf perl png pppd python qt3 qt3support quicktime rar readline reflection samba scanner sdl session spell spl sse sse2 ssl svg tcpd theora threads tiff truetype truetype-fonts type1-fonts unicode usb vorbis xcomposite xinerama xml xorg xscreensaver xv xvid zip zlib" ALSA_CARDS="intel8x0" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route share shm softvol" ELIBC="glibc" INPUT_DEVICES="keyboard mouse aiptek joystick" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en ja" USERLAND="GNU" VIDEO_CARDS="nvidia"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LDFLAGS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 5 Jonathan Stringer 2007-11-09 02:15:06 UTC
Wrong thread, sorry.