Bug 194169 – sys-apps/portage-2.1.3.10: Missing quotes around ${WORKDIR}, ${T} and ${D}

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Samuli Suominen (RETIRED) 2007-09-29 07:20:46 UTC]

Attempt to check /usr/lib/portage/bin for unquoted variables that should be quoted.

ebuild.sh, line 1525, export S=${WORKDIR}/${P}

isolated-functions.sh, line 27, echo -e "$*" >> ${T}/logging/${EBUILD_PHASE:-other}.${messagetype}

prepallman, line 12, mandir=${mandir#${D}}

[Comment 1 Alec Warner (RETIRED) 2007-09-29 07:45:46 UTC]

Commited to HEAD in r7878

[Comment 2 SpanKY 2007-09-29 08:22:10 UTC]

wrong, right, wrong

you do not need quotes in assignments and in fact, they're specifically left out

[Comment 3 Zac Medico 2007-09-29 08:34:13 UTC]

(In reply to comment #2)
> you do not need quotes in assignments and in fact, they're specifically left
> out

For completeness, I'll add that something like make DESTDIR=${D} doesn't count as an assignment because it's a command argument rather than a shell variable assignment.

[Comment 4 Samuli Suominen (RETIRED) 2007-09-29 08:43:20 UTC]

Thanks for clearing that up, makes sense now.

[Comment 5 SpanKY 2007-09-29 08:50:22 UTC]

yeah, sorry for not being explicit ... i was referring to just shell assignments

basically shell rules say expansion of whitespace due to variables/commands/etc... is not considered

so this is all ok:
f=" "
b=${f}
c=$(echo "a b c d")
d=${c}_moo_moo_$b

[Comment 6 Zac Medico 2007-10-06 04:36:03 UTC]

This has been released in 2.1.3.12.