Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 192359 - media-video/mplayer aviheader.c Heap overflow vulnerability (CVE-2007-4938)
Summary: media-video/mplayer aviheader.c Heap overflow vulnerability (CVE-2007-4938)
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Security
Classification: Unclassified
Component: Vulnerabilities (show other bugs)
Hardware: All Linux
: High major
Assignee: Gentoo Security
URL: http://www.securityfocus.com/archive/...
Whiteboard: A2 [ebuild]
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-12 22:29 UTC by Robert Buchholz (RETIRED)
Modified: 2007-09-22 17:39 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Buchholz (RETIRED) gentoo-dev 2007-09-12 22:29:57 UTC
According to SecurityFocus:
  MPlayer is prone to a heap-based buffer-overflow vulnerability because
  it fails to perform adequate boundary checks on user-supplied input
  data. Attackers can exploit this issue to execute arbitrary code with
  the privileges of the user running the application. Failed attacks will
  result in denial-of-service conditions.

No upstream patch available yet.
Comment 1 Robert Buchholz (RETIRED) gentoo-dev 2007-09-12 22:39:14 UTC
Setting whiteboard and cc'ing maintainers.
media-video, according to the avdisory mplayer upstream was contacted a month ago. It seems they did not discuss or commit anything related to this issue yes.
Comment 2 Christian Faulhammer (RETIRED) gentoo-dev 2007-09-13 19:35:32 UTC
Patch to be found here
http://svn.mplayerhq.hu/mplayer/trunk/libmpdemux/aviheader.c?r1=23985&r2=24447
Comment 3 Reimar Döffinger 2007-09-15 17:20:57 UTC
We did not fix this because it is not a security issue (only null-pointer dereference) unless combined with a libc calloc integer overflow.
This was our reply to the people reporting it, they never responded:


Hello,
On Mon, Jul 30, 2007 at 02:54:59PM +0800, Code Audit Labs wrote:
[...]
>      and example code
>      calloc(0x10000001, 0x10);
> 
>      it will return NULL in winxp or gligc 2.5

In this case it only results in a crash and is not critical (still the
suggestion of exchanging the checks seems good and will very likely be
implemented).

>      it will return 0x10 sizes heap in glibc <2.5(maybe prior) or 
> win2000 sp4

This is an integer overflow vulnerability in the calloc implementations
(see also e.g. http://cert.uni-stuttgart.de/advisories/calloc.php), and
we have no intention of working around it.

Greetings,
Reimar Döffinger
Comment 4 Robert Buchholz (RETIRED) gentoo-dev 2007-09-18 23:47:08 UTC
(In reply to comment #3)
> We did not fix this because it is not a security issue (only null-pointer
> dereference) unless combined with a libc calloc integer overflow.

Thanks a lot for getting back to us. I did not have time to review patch and impact yet, sorry.

CVE assigned CVE-2007-4938 to this issue.
Comment 5 Reimar Döffinger 2007-09-22 14:54:28 UTC
Any news? And is there actually anyone checking these security reports? Most even left the horrible spelling of the original report, quite a few silently removed the dependency on libc version mentioned in the original report etc. 
Comment 6 Robert Buchholz (RETIRED) gentoo-dev 2007-09-22 16:53:39 UTC
(In reply to comment #5)
> Any news? And is there actually anyone checking these security reports?

Yes, we're checking them. That's why we opened a bug for it. A bug does not verify the claim the researchers made. I'm sorry if this non-issue causes you a headache upstream.

I talked to nion who handled the Debian bug yesterday and agree this is only a possible Denial of Service, since glibc 2.3 and later are stable on Gentoo for quite a while.

Closing. Thanks again.
Comment 7 Reimar Döffinger 2007-09-22 17:39:29 UTC
Thanks for looking into it.
And sorry for my unrelated rant I couldn't resist to make that you unfortunately misunderstood, I wasn't complaining about you distro people.
I was complaining about SecurityFocus etc. that not only didn't seem to have done much checking but also left out critical information, and of course the vulnhunt guys for completely ignoring our input. I really had expected more :-( (well, there is still CVE, maybe they manage a more useful description whenever they come around to handling it).