Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 190998 - www-client/opera: Patch for adding bugs.gentoo.org and packages.gentoo.org to search engines
Summary: www-client/opera: Patch for adding bugs.gentoo.org and packages.gentoo.org to...
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Jeroen Roovers (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-01 19:39 UTC by Pacho Ramos
Modified: 2010-07-01 16:17 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
opera-gentoo_search.patch (opera-gentoo_search.patch,593 bytes, patch)
2007-09-01 19:39 UTC, Pacho Ramos
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2007-09-01 19:39:28 UTC
I attach a patch for adding these sites allowing users search terms on them using opera search box

Thanks


Reproducible: Always
Comment 1 Pacho Ramos gentoo-dev 2007-09-01 19:39:48 UTC
Created attachment 129794 [details, diff]
opera-gentoo_search.patch
Comment 2 Peter Gantner (a.k.a. nephros) 2007-09-26 16:23:45 UTC
(In reply to comment #1)
shouldn't that be 'Key = gb' for the Gentoo Bugs section?
Comment 3 Pacho Ramos gentoo-dev 2007-09-26 18:59:48 UTC
Yes, it's a typo :-S
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2007-09-29 18:54:19 UTC
Sorry I didn't comment earlier. I had to do some serious technical and moral thinking about this patch.

On the technical side, I wonder what these lines would do when the numbers have already been given in the original file:
+[Search Engine 36]
+[Search Engine 37]

=== Technical considerations ===
I do not currently know whether these would be changed by Opera by default if conflicts were found. Also, search.ini has an ID field for each entry which should probably match the Search Engine number. I am reluctant to even go test what the impact of conflicts would be or whether Opera somehow patches them gracefully at runtime. Maybe it's enough to set higher Search Engine and ID numbers to avoid conflicts, but even then Opera might choose to add a "gb" or "gp" Key of their own. It might also be required to write a new patch every time Opera changes search.ini. Besides the possibility of this patch causing bugs (for me to resolve), it would also involve the extra work of maintaining the patch.

Ideally, a script would check search.ini's existing Search Engine entries and add the new entries carefully, reporting through the ebuild which search keys it used to set up the packages.g.o and bugs.g.o entries, both to avoid the conflicts that might arise at runtime and to facilitate handling bugs (because the build log would be verbose about the additions). A simple patch that would tag on the new entries at the end of the file would not suffice.

=== Moral considerations ===
On the other hand, I want to maintain the package as close to upstream's defaults as possible, thereby both respecting upstream as well as causing a minimum of bugs that inadvertently find their way upstream instead of staying right here on bugs.gentoo.org where they belong. While extras such as these are nice, I wonder whether setting them up manually in ~/.opera/search.ini or preferably through Opera's interface isn't the best way to do it.

I would appreciate it if you could address these concerns.

See also bug #139508 for additional information about patching Opera system-wide as opposed to for specific users only.
Comment 5 Jeroen Roovers (RETIRED) gentoo-dev 2010-07-01 16:17:02 UTC
I'd like to install Opera just the way upstream intended, and now I don't think we should add our own search engines, because we cannot even assume Gentoo/Opera users are the people who really want to use packages.g.o, let alone bugs.g.o. Maybe some of the system admins who run emerge and file bug reports, but not nearly everyone who uses Opera on Gentoo.