Bug 190821 – Switch gnome2.eclass to use emake in gnome2_src_install

• Status: RESOLVED DUPLICATE of bug 202184
• Product: Gentoo Linux

[Description Petteri Räty (RETIRED) 2007-08-30 21:41:17 UTC]

make DESTDIR=${D} "scrollkeeper_localstate_dir=${D}${sk_tmp_dir} " "$@" install || die "install failed"

should use emake here nowadays

[Comment 1 Daniel Gryniewicz (RETIRED) 2007-09-04 01:10:00 UTC]

Is there some advantage to this?  Or is it just asthetics?  Obviously, it's nicer to have ebuilds use emake, because everyone sees them, but this is an eclass; changing it will cause huge metadata churn for the whole world.  Is there any gain to it?

(I'm not against it; I'm merely prioritizing)

[Comment 2 Petteri Räty (RETIRED) 2007-09-04 15:05:35 UTC]

(In reply to comment #1)
> Is there some advantage to this?  Or is it just asthetics?  Obviously, it's
> nicer to have ebuilds use emake, because everyone sees them, but this is an
> eclass; changing it will cause huge metadata churn for the whole world.  Is
> there any gain to it?
> 
> (I'm not against it; I'm merely prioritizing)
> 

Yes. It makes using MAKEOPTS possible and respects the MAKE variable. It's also  the way to do it told by policy. I regularly change Java eclasses that are used by hundreds of ebuilds... It's only a strain on the servers generating the metadata cache any way.

[Comment 3 Saleem Abdulrasool (RETIRED) 2007-12-13 22:41:24 UTC]

*** This bug has been marked as a duplicate of bug 20284 ***

[Comment 4 Petteri Räty (RETIRED) 2007-12-14 00:16:11 UTC]

(In reply to comment #3)
> 
> *** This bug has been marked as a duplicate of bug 20284 ***
> 

Seems like a typo or something as that bug is about qmail.

[Comment 5 Rémi Cardona (RETIRED) 2007-12-14 06:55:54 UTC]

*** This bug has been marked as a duplicate of bug 202184 ***