189994 – app-portage/gentoolkit - eread will try to delete nonexistent file

Bug 189994 - app-portage/gentoolkit - eread will try to delete nonexistent file

Summary: app-portage/gentoolkit - eread will try to delete nonexistent file

Status:	RESOLVED FIXED

Alias:	None

Product:	Portage Development
Classification:	Unclassified
Component:	Tools (show other bugs)
Hardware:	All Linux

Importance:	High minor
Assignee:	Portage Tools Team

URL:
Whiteboard:
Keywords:	InVCS

Depends on:
Blocks:	170220
	Show dependency tree

Reported:	2007-08-24 03:58 UTC by cburroughs
Modified:	2007-09-13 15:51 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Skip inexistant file (eread-0.2.4_pre6-inexistant_file.patch,330 bytes, patch) 2007-08-24 06:55 UTC, Ludovic Fauvet	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description cburroughs 2007-08-24 03:58:22 UTC

If you ask eread to display a nonexistent file the pager will give an error and then eread will ask if you want to delete the file.  This obviously doesn't make much sense.

Choice? 300000
Missing filename ("less --help" for help)
Delete file? [y/N] 


Reproducible: Always

Comment 1 Ludovic Fauvet 2007-08-24 06:55:57 UTC

Created attachment 129045 [details, diff]
Skip inexistant file

Comment 2 Paul Varner (RETIRED) gentoo-dev

2007-09-13 02:55:06 UTC

I didn't use your patch since when you enter an invalid entry $FILE doesn't contain anything. However, thanks for the bug report and the patch.

$ svn commit -m "Fix eread to not accept invalid input for file selection. (Bug #189994)"
Sending        ChangeLog
Sending        src/eread/eread
Transmitting file data ..
Committed revision 436.

Comment 3 Paul Varner (RETIRED) gentoo-dev

2007-09-13 15:51:31 UTC

Released in gentoolkit-0.2.4_pre7