Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 187346 - media-sound/rhythmbox-0.10.1: Unspecified runtime dependency on gst-plugins-taglib for tag editing
Summary: media-sound/rhythmbox-0.10.1: Unspecified runtime dependency on gst-plugins-t...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-01 08:13 UTC by Ivan Toshkov
Modified: 2008-05-27 19:34 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild with added missing dependency (rhythmbox-0.10.1-r1.ebuild,3.12 KB, text/plain)
2007-12-17 16:59 UTC, Ivan Toshkov
Details
Improved dependency (rhythmbox-0.10.1-r1.ebuild,3.13 KB, text/plain)
2008-01-21 09:26 UTC, Ivan Toshkov
Details
Improved dependency (rhythmbox-0.11.2-r1.ebuild,3.21 KB, text/plain)
2008-01-21 09:27 UTC, Ivan Toshkov
Details
Patch for 0.11.5 ebuild (rhythmbox-0.11.5.ebuild.patch,448 bytes, patch)
2008-04-09 08:31 UTC, Ivan Toshkov
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Toshkov 2007-08-01 08:13:22 UTC
Tag editing in Rhythmbox is enabled by default since version 0.9.6.  It depends on media-plugins/gst-plugins-taglib, but the dependency is not mentioned in the rhythmbox ebuild.

Reproducible: Always

Steps to Reproduce:
1. Make sure gst-plugins-taglib isn't installed
2. emerge media-sound/rhythmbox-0.10.1
3. Check if gst-plugins-taglib got installed
Actual Results:  
Not installed.

Expected Results:  
Installed (or at least mentioned, that it's needed for tag editing).
Comment 1 Gilles Dartiguelongue (RETIRED) gentoo-dev 2007-08-04 15:41:21 UTC
I think I had a similar problem in that, recreating my library without gst-plugins-taglib ended up in a really big chunk of my mp3s id3s not being read.
Installing this plugin and re creating my library from scratch made it work. If you could confirm that too that would be great.
Comment 2 Ivan Toshkov 2007-08-10 12:41:10 UTC
With my collection I got the same results with and without gst-plugins-taglib installed.  To test it I'm removing the directory ~/.gnome2/rhythmbox before each run, but I'm not 100% sure that is sufficient.
Comment 3 Christopher Covington 2007-09-26 03:59:26 UTC
Shouldn't the tagwriting (and maybe musicbrainz) USE flag draw in the gst plugin?
Comment 4 Ivan Toshkov 2007-09-26 06:01:51 UTC
(In reply to comment #3)
> Shouldn't the tagwriting (and maybe musicbrainz) USE flag draw in the gst
> plugin?
> 

The problem was, that when I was registering the bug, gst-plugins-taglib was keyword-masked, and rhythmbox wasn't.  It's now unmasked, so this should work without problems.
Comment 5 Rémi Cardona (RETIRED) gentoo-dev 2007-09-26 16:45:49 UTC
Ivan, if this bug is fixed for you, please close the bug :) Thanks
Comment 6 Ivan Toshkov 2007-09-26 21:11:34 UTC
Sorry, my English isn't perfect.  :(

What I meant was, that I agree with Christopher's comment.  I was just trying to explain, that the situation when the bug was raised was that rhythmbox was stable, but gst-plugins-taglib wasn't.  It won't be good to make a stable package depend on a non-stable, right?

But now, both packages are stable, so the dependency should be ok.  But it's still not there, so the bug isn't fixed.
Comment 7 Spider (Yep, that one) 2007-12-12 13:20:32 UTC
Bug verified:
USE="tagwriting"
emerge rhythmbox


Editing tags of MP3's fail, but Ogg/Vorbis will succeed.
Fix:
install gst-plugins-taglib

Editing tags of mp3's succeed.
Reason:
tagwriting? ( media-plugins/gst-plugins-tagwriting )  is missing from RDEPEND.
Comment 8 A. Person 2007-12-14 03:14:49 UTC
I have gst-plugins-taglib installed and I can edit MP3 tags, but when I edit a FLAC tag it reverts back within 5-10 seconds after I make the change.  I've tried re-emerging flac to no avail.  Any suggestions?
Comment 9 Ivan Toshkov 2007-12-17 16:59:50 UTC
Created attachment 138741 [details]
Ebuild with added missing dependency
Comment 10 Nguyen Thai Ngoc Duy (RETIRED) gentoo-dev 2008-01-19 12:03:44 UTC
(In reply to comment #9)
> Created an attachment (id=138741) [edit]
> Ebuild with added missing dependency
> 

taglib is for mp3 tagging only so "tagwriting? ( >=media-plugins/gst-plugins-taglib-0.10.6 )" should be inside "mad? ()" block.

(In reply to comment #8)
> I have gst-plugins-taglib installed and I can edit MP3 tags, but when I edit a
> FLAC tag it reverts back within 5-10 seconds after I make the change.  I've
> tried re-emerging flac to no avail.  Any suggestions?
> 

It seems rhythmbox needs flactag for tag writing and the plugin is disabled in gst-plugins-flac. Are you sure you have flactag plugin installed?
Comment 11 Ivan Toshkov 2008-01-21 09:26:57 UTC
Created attachment 141444 [details]
Improved dependency
Comment 12 Ivan Toshkov 2008-01-21 09:27:35 UTC
Created attachment 141446 [details]
Improved dependency
Comment 13 A. Person 2008-01-22 17:32:15 UTC
I bet flactag is the problem.  How can I enable that plugin?
Comment 14 Nguyen Thai Ngoc Duy (RETIRED) gentoo-dev 2008-01-22 18:38:07 UTC
(In reply to comment #13)
> I bet flactag is the problem.  How can I enable that plugin?
> 

You should not IMO. It has been disabled in 0.10.x since Aug 2005. Better ping gstreamer developers about its status. If you still want it, edit gstflac.c in gst-plugins-good, remove "#if 0" around flactag registration code.
Comment 15 A. Person 2008-01-22 18:45:15 UTC
So no Gentoo users are editing flac tags in rhythmbox unless they uncomment that code?
Comment 16 Nguyen Thai Ngoc Duy (RETIRED) gentoo-dev 2008-01-22 18:55:03 UTC
(In reply to comment #15)
> So no Gentoo users are editing flac tags in rhythmbox unless they uncomment
> that code?
> 

I don't use flac myself so my statement could be wrong. The same situation holds for every distro, not just Gentoo. And if you uncomment that code, you are risking your precious music files.
Comment 17 Rémi Cardona (RETIRED) gentoo-dev 2008-04-08 15:37:12 UTC
Ivan,

could you please provide an ebuild patch on top of rhythmbox 0.11.5? Makes reviewing a lot easier.

Thanks
Comment 18 Ivan Toshkov 2008-04-09 08:31:10 UTC
Created attachment 149182 [details, diff]
Patch for 0.11.5 ebuild

The patch is quite simple: it just adds the dependency.
Comment 19 Rémi Cardona (RETIRED) gentoo-dev 2008-05-27 19:34:26 UTC
In portage without revbump.

Thanks for reporting