Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 183625 - perl-app.eclass and perl-module.eclass prevent the use of Makefile if PREFER_BUILDPL is set
Summary: perl-app.eclass and perl-module.eclass prevent the use of Makefile if PREFER_...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Perl team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: perl-eclass
  Show dependency tree
 
Reported: 2007-06-29 08:58 UTC by Vincent Pit
Modified: 2009-11-14 22:10 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
PREFER_BUILDPL behaviour fix (perl-eclass.patch,2.01 KB, patch)
2007-06-29 08:58 UTC, Vincent Pit
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Pit 2007-06-29 08:58:03 UTC
If PREFER_BUILDPL is set to "yes", portage will completely ignore any Makefile.PL and so won't do anything unless there's a Build.PL. That may considered a little restrictive for a PREFERence, since it prevents any module to be build unless PREFER_BUILDPL is explicitely specified to "no". The following patch changes this behaviour to :
- use Build.PL if either :
 * we are in module-build
 * there's a Build.PL, and PREFER_BUILDPL is yes if Makefile.PL is present too
- otherwise use Makefile.PL if it's present

Reproducible: Always

Steps to Reproduce:
Comment 1 Vincent Pit 2007-06-29 08:58:50 UTC
Created attachment 123369 [details, diff]
PREFER_BUILDPL behaviour fix
Comment 2 Torsten Veller (RETIRED) gentoo-dev 2009-11-14 22:10:23 UTC
Vincent, the description isn't accurate any more.

The eclasses currently check:

| if [[ ${PREFER_BUILDPL} == yes && -f Build.PL ]] ; then
| einfo "Using Module::Build"
| ...
| elif [[ -f Makefile.PL ]] ; then
| einfo "Using ExtUtils::MakeMaker"
| ...
| fi

If you think we can improve it, please describe the problem again. I close the bug in the meantime.

Thanks for your patience