Bug 179348 – Move madwifi headers into madwifi-ng-tools

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Daniel Drake (RETIRED) 2007-05-21 19:27:12 UTC]

Currently the madwifi-ng ebuild installs the /usr/include/madwifi headers used by wpa_supplicant and hostapd. This means that wpa_supplicant has to conditionally depend on madwifi-ng, which is in itself nasty because madwifi-ng has dependencies on kernel stuff -- this is an inconvenience when building release media etc.

I think the headers should be installed by the madwifi-ng-tools ebuild and wpa_supplicant/hostapd dependencies should be updated.

[Comment 1 Gordon Malm (RETIRED) 2007-05-22 09:03:17 UTC]

I just whipped up some patches to do as requested in this bug.  They work for me with the exception of hostapd-0.5.7-r1.patch which I did not test.

[Comment 2 Gordon Malm (RETIRED) 2007-05-22 09:04:24 UTC]

Created attachment 119968 [details, diff]
madwifi-ng-0.9.3-r4.patch

Patch: madwifi-ng-0.9.3-r3.ebuild -> madwifi-ng-0.9.3-r4.ebuild

[Comment 3 Gordon Malm (RETIRED) 2007-05-22 09:05:20 UTC]

Created attachment 119970 [details, diff]
madwifi-ng-tools-0.9.3-r1.patch

Patch: madwifi-ng-tools-0.9.3.ebuild -> madwifi-ng-tools-0.9.3-r1.ebuild

[Comment 4 Gordon Malm (RETIRED) 2007-05-22 09:06:24 UTC]

Created attachment 119972 [details, diff]
hostapd-0.4.9-r1.patch

Patch: hostapd-0.4.9.ebuild -> hostapd-0.4.9-r1.ebuild

[Comment 5 Gordon Malm (RETIRED) 2007-05-22 09:07:02 UTC]

Created attachment 119973 [details, diff]
hostapd-0.5.7-r1.patch

Patch: hostapd-0.5.7.ebuild -> hostapd-0.5.7-r1.ebuild

[Comment 6 Gordon Malm (RETIRED) 2007-05-22 09:07:34 UTC]

Created attachment 119975 [details, diff]
wpa_supplicant-0.5.7-r1.patch

Patch: wpa_supplicant-0.5.7.ebuild -> wpa_supplicant-0.5.7-r1.ebuild

[Comment 7 Gordon Malm (RETIRED) 2007-05-22 09:40:20 UTC]

In the case of hostapd/wpa_supplicant ebuilds these changes should probably just go into the existing ebuilds instead of a rather meaningless revbump.  Only submitted the patches this way for consistency/testing/etc.

[Comment 8 Stefan Schweizer (RETIRED) 2007-05-23 16:07:52 UTC]

the madwifi side of things is done.

[Comment 9 Togge 2007-05-24 05:31:42 UTC]

Now madwifi-ng-tools don't emerge due to file collisions with madwifi-ng. A blocker against older versions?

[Comment 10 Gordon Malm (RETIRED) 2007-05-24 06:22:47 UTC]

(In reply to comment #9)
> Now madwifi-ng-tools don't emerge due to file collisions with madwifi-ng. A
> blocker against older versions?
> 

That was left out in the cvs commit.  There is also a format error in the einfo messages at the end.

[Comment 11 Stefan Schweizer (RETIRED) 2007-05-24 08:56:35 UTC]

(In reply to comment #9)
> Now madwifi-ng-tools don't emerge due to file collisions with madwifi-ng. A
> blocker against older versions?


A blocker is a bad thing because most users do not know how to correctly handle it. Besides it braks automated updates.

Maybe we can remove the conflicting files in preinst?

[Comment 12 Stefan Schweizer (RETIRED) 2007-06-19 07:54:48 UTC]

all fixed, thanks.