Bug 178544 – einstall modifies EXTRA_EINSTALL

• Status: RESOLVED FIXED
• Product: Portage Development

[Description James C. Georgas 2007-05-14 19:31:17 UTC]

The einstall() function in ebuild.sh prepends the ABI target libdir to the global variable EXTRA_EINSTALL.

Since the variable is global, the modifications accumulate across calls, which messes multilib loops that call einstall().

I think the EXTRA_* variables should not be modified by portage, if they're supposed to be user settable.

Patch to follow.

[Comment 1 James C. Georgas 2007-05-14 19:33:42 UTC]

Created attachment 119249 [details, diff]
preserve EXTRA_EINSTALL in einstall() function

This patch preserves the contents of EXTRA_EINSTALL, by using the EI_DESTLIBDIR variable directly instead.

[Comment 2 SpanKY 2007-05-14 23:54:29 UTC]

`einstall` shouldnt be used in the first place, but that's a different topic

the usage should be changed to match EXTRA_ECONF usage in econf() ... in other words, introduce a local LOCAL_EXTRA_EINSTALL and utilize that

[Comment 3 James C. Georgas 2007-05-15 02:21:09 UTC]

Created attachment 119319 [details, diff]
updated patch to einstall() in ebuild.sh

This patch incorporates spanKY's suggestions to solve the problem.

[Comment 4 SpanKY 2007-05-19 04:09:27 UTC]

thanks, ive merged that one

[Comment 5 James C. Georgas 2007-05-19 13:54:47 UTC]

Your welcome.

I have another bug, similar to this one, reported as #178378, which I think got lost between the cracks last week. It started out as an eclass bug, but the problem also exists in ebuild.sh, so it might be relevant to core also.

[Comment 6 Zac Medico 2007-05-19 18:23:08 UTC]

(In reply to comment #5)
> I have another bug, similar to this one, reported as #178378, which I think got
> lost between the cracks last week. It started out as an eclass bug, but the
> problem also exists in ebuild.sh, so it might be relevant to core also.

In svn r6558.

[Comment 7 Zac Medico 2007-05-25 09:08:48 UTC]

This has been released in 2.1.2.8.