178378 – x-modular.eclass missing ECONF_SOURCE checks

Bug 178378 - x-modular.eclass missing ECONF_SOURCE checks

Summary: x-modular.eclass missing ECONF_SOURCE checks

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Eclasses (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Gentoo X packagers

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2007-05-13 17:05 UTC by James C. Georgas
Modified:	2007-08-02 01:22 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
patch for x-modular.eclass (x-modular-econf.patch,396 bytes, text/plain) 2007-05-13 17:06 UTC, James C. Georgas	Details
make src_compile search ECONF_SOURCE for configure script (ebuild_sh_src_compile.patch,322 bytes, patch) 2007-05-13 20:09 UTC, James C. Georgas	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description James C. Georgas 2007-05-13 17:05:51 UTC

The econf() function in ebuild.sh checks if ECONF_SOURCE is set before defaulting to the current directory, when looking for a configure script.

However, calls to econf() from several other functions don't use ECONF_SOURCE to search for a configure script. Instead, they check only the current directory, and silently skip the configure step, if the script is not found there.

This breaks ebuilds that try to compile in a directory other than the source directory.

Reproducible: Always

Comment 1 James C. Georgas 2007-05-13 17:06:53 UTC

Created attachment 119129 [details]
patch for x-modular.eclass

x-modular has this problem. Here's a patch.

Comment 2 Alec Warner (RETIRED) archtester

2007-05-13 17:38:44 UTC

I don't think this is a portage bug, if specific ebuilds or eclasses need fixing it's probably easier to just e-mail the specific maintainers.

-Alec

Comment 3 James C. Georgas 2007-05-13 17:51:18 UTC

Oh, ok. Thanks.

However, the default src_compile() function in ebuild.sh does the same thing. Should I make a patch for that file here?

/\V

Comment 4 Steve L 2007-05-13 19:46:19 UTC

Yes please; you might want to make this a tracker for all the eclasses that do this too.

Comment 5 James C. Georgas 2007-05-13 20:09:06 UTC

Created attachment 119142 [details, diff]
make src_compile search ECONF_SOURCE for configure script

Comment 6 James C. Georgas 2007-05-13 20:11:02 UTC

(In reply to comment #4)
> Yes please; you might want to make this a tracker for all the eclasses that do
> this too.
> 

I don't know how to do that.

Comment 7 James C. Georgas 2007-05-13 22:10:42 UTC

(In reply to comment #5)
> Created an attachment (id=119142) [edit]
> make src_compile search ECONF_SOURCE for configure script
> 

I should have stated that this new patch is for ebuild.sh, as requested.

Comment 8 Zac Medico gentoo-dev

2007-05-19 18:21:39 UTC

(In reply to comment #5)
> Created an attachment (id=119142) [edit]
> make src_compile search ECONF_SOURCE for configure script

Thanks, it's in portage svn r6558.

Comment 9 Donnie Berkholz (RETIRED) gentoo-dev

2007-08-02 01:22:10 UTC

Applied, thanks for your patience!