Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 177290 - repoman: Disallow committing new files without a ChangeLog entry
Summary: repoman: Disallow committing new files without a ChangeLog entry
Status: RESOLVED DUPLICATE of bug 337853
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-06 09:18 UTC by Petteri Räty (RETIRED)
Modified: 2011-10-12 19:44 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Petteri Räty (RETIRED) gentoo-dev 2007-05-06 09:18:14 UTC
If you are adding new files, there is no reason to omit a ChangeLog entry so repoman should refuse to commit.
Comment 1 SpanKY gentoo-dev 2007-05-06 09:22:58 UTC
adding metadata should not require a changelog entry
Comment 2 Petteri Räty (RETIRED) gentoo-dev 2007-05-06 09:26:43 UTC
(In reply to comment #1)
> adding metadata should not require a changelog entry
> 

Why? It would leave a trace in the ChangeLog about that there was no metadata before this point and as such no maintainer and would tell who is the maintainer.
Comment 3 SpanKY gentoo-dev 2007-05-06 11:22:59 UTC
pointless noise imo ... you're just doing:
cat metadata.xml >> ChangeLog
Comment 4 Petteri Räty (RETIRED) gentoo-dev 2007-05-06 11:48:43 UTC
(In reply to comment #3)
> pointless noise imo ... you're just doing:
> cat metadata.xml >> ChangeLog
> 

Yes but the point of ChangeLog is to see major changes. If we don't record metadata.xml there, they would have to resort to viewcvs.
Comment 5 Alec Warner (RETIRED) archtester gentoo-dev Security 2007-08-28 16:50:30 UTC
As Cardoe stated on irc, I'd rather see repoman do the entry for you rather than repoman complain because you didn't write one.

Another warning or error is just gay.  You want a changelog entry, just make repoman do it.  You are already passing the damn message with -m for the cvs commit.  No one uses a different commit message versus changelog message anyway.

They just run

repoman commmit -m msg
echangelog msg

Comment 6 Doug Goldstein (RETIRED) gentoo-dev 2007-08-28 16:52:25 UTC
I don't know about you.. but I usually do:

echangelog "message"
repoman ci -m "message"

Not the other way around.

Simply the change should be, if ChangeLog isn't one of the altered files that repoman sees.. run echangelog.
Comment 7 Robert Buchholz (RETIRED) gentoo-dev 2007-09-08 21:35:22 UTC
(In reply to comment #5)
> As Cardoe stated on irc, I'd rather see repoman do the entry for you rather
> than repoman complain because you didn't write one.

Both could be implemented. If you commit with -m and no ChangeLog, repoman fails / warns. Furthermore, it could have a -c switch (like sunrise-commit) that creates echangelog and commits afterward.
Comment 8 Markos Chandras (RETIRED) gentoo-dev 2011-10-12 19:44:56 UTC
We will move the discussion to bug 337853

*** This bug has been marked as a duplicate of bug 337853 ***