176351 – Make eclass functions more strict

Bug 176351 - Make eclass functions more strict

Summary: Make eclass functions more strict

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Java (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Java team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2007-04-28 12:57 UTC by Marat Radchenko
Modified:	2015-06-09 01:08 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Marat Radchenko 2007-04-28 12:57:32 UTC

for example, java-pkg_getjar doesn't die when it is given only one argument.
eant doesn't die if it cannot find package for specified ANT_TASKS.

Comment 1 Josh Nichols (RETIRED) gentoo-dev

2007-04-28 14:42:32 UTC

The problem with some of these functions is that they are typically called from a subshell, ie:

eant -Dsomejar=$(java-pkg_getjar something)

As a result, having it die wouldn't get you anything, since it would die in the subshell.

Comment 2 Vlastimil Babka (Caster) (RETIRED) gentoo-dev

2007-04-28 14:47:45 UTC

(In reply to comment #0)
> eant doesn't die if it cannot find package for specified ANT_TASKS.

Hm that would be ant script itself, not eant function. You're probably right it should do that now.

(In reply to comment #1)
> As a result, having it die wouldn't get you anything, since it would die in the
> subshell.

I remember some notice on -dev about die in subshell now somewhat working, although not 100% reliably :/

Comment 3 Alex Xu (Hello71) 2015-06-09 01:08:13 UTC

most java ebuilds appear to die, closing.