Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 174485 - net-misc/rdesktop segfaults w/ x11-libs/libX11-1.1.1-r1
Summary: net-misc/rdesktop segfaults w/ x11-libs/libX11-1.1.1-r1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Chris Gianelloni (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-13 16:33 UTC by Rod MacCallum
Modified: 2007-05-29 17:56 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix for segfault caused within rdesktop-1.5.0 (rdesktop-1.5.0-libX11-segfault-fix.patch,444 bytes, patch)
2007-04-16 18:50 UTC, Haroon Rafique
Details | Diff
patch for new ebuild 1.5.0-r2 (rdesktop-ebuild-version-bump.patch,439 bytes, patch)
2007-04-16 18:52 UTC, Haroon Rafique
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rod MacCallum 2007-04-13 16:33:14 UTC
Hello,

Running rdesktop command, connection is made to 2003 terminal server and username/password box is displayed. After entering un/pw and hitting "OK", rdesktop quits with a "Segmentation fault". 

Reproducible: Always

Steps to Reproduce:
1.rdesktop -u rod -a 15 "terminal.server"
2.enter pw/un, click "OK"
3.rdesktop segfaults

Actual Results:  
rdesktop segfaults

Expected Results:  
rdesktop connection to be established

Portage 2.1.2.2 (default-linux/x86/2006.0, gcc-4.1.1, glibc-2.5-r0, 2.6.19-gentoo-r5 i686)
=================================================================
System uname: 2.6.19-gentoo-r5 i686 AMD Athlon(tm) XP  3200+
Gentoo Base System release 1.12.9
Timestamp of tree: Thu, 12 Apr 2007 13:30:01 +0000
dev-java/java-config: 1.3.7, 2.0.31
dev-lang/python:     2.3.5-r3, 2.4.3-r4
dev-python/pycrypto: 2.0.1-r5
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.61
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10
sys-devel/binutils:  2.16.1-r3
sys-devel/gcc-config: 1.3.15-r1
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.4.19-r1, 2.6.17-r2
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=athlon-xp -pipe -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/lib/fax /usr/share/X11/xkb /usr/share/config /var/spool/fax/etc"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf /etc/java-config/vms/ /etc/revdep-rebuild /etc/terminfo"
CXXFLAGS="-O2 -march=athlon-xp -pipe -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="distlocks fixpackages metadata-transfer sandbox sfperms strict"
GENTOO_MIRRORS="http://distfiles.gentoo.org http://distro.ibiblio.org/pub/linux/distributions/gentoo"
LC_ALL="en_US"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --filter=H_**/files/digest-*"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X alsa apache2 apm arts berkdb bitmap-fonts cli cracklib crypt cups dri dvd eds emboss encode esd fam foomaticdb fortran gdbm gif gnome gpm gstreamer gtk gtk2 iconv imlib ipv6 isdnlog jpeg kde libg++ libwww mad midi mikmod motif mp3 mpeg ncurses nls nptl nptlonly ogg opengl oss pam pcre perl png pppd python qt3 qt4 quicktime readline reflection sdl session spell spl ssl tcltk tcpd truetype truetype-fonts type1-fonts usb vorbis x86 xml xorg xv zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1 emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route share shm softvol" ELIBC="glibc" INPUT_DEVICES="keyboard mouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" USERLAND="GNU" VIDEO_CARDS="nvidia vga"
Unset:  CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LDFLAGS, LINGUAS, MAKEOPTS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2007-04-13 16:34:26 UTC
x11-libs/libX11 version?
Comment 2 Rod MacCallum 2007-04-13 16:37:24 UTC
x11-libs/libX11-1.1.1-r1
Comment 3 Jakub Moc (RETIRED) gentoo-dev 2007-04-13 16:44:28 UTC
Hmm, I guess it works when you downgrade to 1.1.1, right?
Comment 4 Rod MacCallum 2007-04-13 17:20:06 UTC
Yes, downgrading to the unstable 1.1.1 seems to solve the issue.
Comment 5 Jakub Moc (RETIRED) gentoo-dev 2007-04-13 17:38:38 UTC
Bleh... see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=418021
Comment 6 Haroon Rafique 2007-04-16 18:47:04 UTC
From:
https://bugs.launchpad.net/ubuntu/+source/rdesktop/+bug/102922
Specifically comment 9:
https://bugs.launchpad.net/ubuntu/+source/rdesktop/+bug/102922/comments/9

The solution provided in comment 9 works for me. I will attach a diff against the 1.5.0 sources and also a diff to get an updated 1.5.0-r2 ebuild.
Comment 7 Haroon Rafique 2007-04-16 18:48:18 UTC
(In reply to comment #6)

> 
> The solution provided in comment 9 works for me. I will attach a diff against
> the 1.5.0 sources and also a diff to get an updated 1.5.0-r2 ebuild.
> 

oops... bugzilla autolinked comment 9 to comment#9 inside this issue (it doesn't even exist yet). Please disregard that.
Comment 8 Haroon Rafique 2007-04-16 18:50:48 UTC
Created attachment 116463 [details, diff]
Fix for segfault caused within rdesktop-1.5.0

Fix for segfault caused within rdesktop-1.5.0 as a result of libX11-1.1.1-r1
Comment 9 Haroon Rafique 2007-04-16 18:52:40 UTC
Created attachment 116465 [details, diff]
patch for new ebuild 1.5.0-r2
Comment 10 Martin Jackson (RETIRED) gentoo-dev 2007-04-23 19:32:41 UTC
I can confirm the attached fix works as rdesktop-1.5.0-r2 in my environment, in which I use it quite heavily.
Comment 11 Christoph Loehr 2007-04-24 05:13:00 UTC
(In reply to comment #10)
> I can confirm the attached fix works as rdesktop-1.5.0-r2 in my environment, in
> which I use it quite heavily.
> 

Same for me. I use the fix since a few days and have encountered no problems so far.
Comment 12 Aurelien Minet 2007-04-25 09:02:39 UTC
I have had the problem and the patch fix it too.
Comment 13 brzezik 2007-04-26 11:11:25 UTC
echo >x11-libs/libX11-1.1.1 >> /etc/portage/package.mask
emerge libX11 rdesktop

Comment 14 Chris Gianelloni (RETIRED) gentoo-dev 2007-04-26 18:44:23 UTC
Ehh, no.  Fixing rdesktop and using the patch above is much preferred to allowing a security vulnerable version of libX11 on your machine.  This should be taken care of soon.
Comment 15 Nico Baggus 2007-04-26 22:39:22 UTC
The ubuntu path replaces the 
cx * g_bpp /8 ..,

it will segfault again btw when the XCreateImage decides to return a NULL
again....,
So a path should also include a check for the XCreateImage result value imho.
Comment 16 Martin Jackson (RETIRED) gentoo-dev 2007-04-26 23:34:07 UTC
I have accepted wolf31o2's offer of maintainership and committed rdesktop-1.5.0-r2 to the tree.  Please test, and if no issues are found, I will file a stabilization request in 30 days.
Comment 17 Rod MacCallum 2007-05-29 17:56:46 UTC
1.5.0-r2 has been working fine for me.