Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 172331 - app-crypt/gnupg Wrong Photo Viewer String hardcoded in ebuild
Summary: app-crypt/gnupg Wrong Photo Viewer String hardcoded in ebuild
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Crypto team [DISABLED]
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-26 19:56 UTC by Daniel Kenzelmann
Modified: 2007-04-03 09:41 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Kenzelmann 2007-03-26 19:56:42 UTC
The GnuPG ebuild hardcodes a photo viewer

myconf="${myconf} --with-photo-viewer=${viewer}

From gnupg doc:

--with-photo-viewer=FIXED_VIEWER
                    Force the photo viewer to be FIXED_VIEWER and
		    disable any ability for the user to change it in
		    their options file.


1. It should not force a specific viewer, by default the viewer can be set in the config UNLESS you specify it at compile time with "--with-photo-viewer", thus, that line in the ebuild should be disabled.

2. IF you want to force users to use a fixed viewer you have to use at least a correct config
currently  it is "--with-photo-viewer=/usr/bin/xloadimage" which WON'T work.
you have to use --with-photo-viewer="xloadimage -fork -quiet -title 'KeyID 0x%k' stdin" (be careful with the quotes)
which happens to be the default if you don't specify "--with-photo-viewer" at all

Reproducible: Always

Steps to Reproduce:
1. include Photo-ID in GnuPG key
2. try to view it
3. will not work, no matter what you try as /usr/bin/xloadimage is hardcoded which also is not a correct gnupg photo-viewer string




This also affects tools like Seahorse.
Comment 1 Alon Bar-Lev (RETIRED) gentoo-dev 2007-03-27 06:46:32 UTC
I never used images....
What happens if you don't specify with-photo-viewer or disable-photo-viewers and you don't have xloadimage or xli installed?
Does gnupg still works (apart of images), or we still need to keep the dependency?
Comment 2 Daniel Kenzelmann 2007-03-27 07:46:39 UTC
GnuPG will always work, it just won't display the photos if you specify a wrong photo-viewer in the config or on the commandline.

You can also just use e.g. cat like --photo-viewer "cat - > Pic0x%k.jpg" which will just put the image into a file or use a script to send the image somewhere else, thus there is no real dependency to any X-application.
Comment 3 Alon Bar-Lev (RETIRED) gentoo-dev 2007-03-31 16:31:02 UTC
crypto: Unless someone has a good reason, I think I will drop the dependency (adding elog) so users may install a filter for their choice.
Comment 4 Daniel Black (RETIRED) gentoo-dev 2007-03-31 22:44:21 UTC
sounds good Alon
Comment 5 Alon Bar-Lev (RETIRED) gentoo-dev 2007-04-02 09:01:00 UTC
OK.
Fixed in:
gnupg-2.0.3-r1
gnupg-1.4.7-r1

Daniel, please verify that this is what you wished for.
Comment 6 Daniel Kenzelmann 2007-04-02 20:02:52 UTC
Great, thanks, that's it.

Now if only someone could update the seahorse ebuild as in bug 128780  (the ebuild in portage requires gnupg 1.4.x) then i could clean out my portage overlay a little bit :-)
Comment 7 Alon Bar-Lev (RETIRED) gentoo-dev 2007-04-03 09:41:26 UTC
I am glad that it is working.

Regarding seahorse... I just don't have control over it... The seahorse maintainer (gnome) seem like don't care to make it working... Is it working for you with gpg2? Can you update bug#164523 with you configuration so people may find the problem they are having with their environment.

Thanks!