Bug 168859 – games-simulation/openttd bad built_with_use check w/ USE="-dedicated"

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Denis Gubanov 2007-03-01 11:17:28 UTC]

ebuild not test 'dedicated' USE-flag
may be trouble in thes section:

pkg_setup() {
        if ! built_with_use media-libs/libsdl X ; then
                die "Please emerge media-libs/libsdl with USE=X"
        fi
        games_pkg_setup
}


?

Reproducible: Always

Steps to Reproduce:
1. without X installed
2. without libsdl installed (or libsdl compiled without X use-flag)
3. 

Actual Results:  
!!! ERROR: games-simulation/openttd-0.5.0 failed.
Call stack:
  ebuild.sh, line 1630:   Called dyn_setup
  ebuild.sh, line 702:   Called qa_call 'pkg_setup'
  ebuild.sh, line 38:   Called pkg_setup
  openttd-0.5.0.ebuild, line 35:   Called die

!!! Please emerge media-libs/libsdl with USE=X
!!! If you need support, post the topmost build error, and the call stack if relevant.
!!! A complete build log is located at '/var/tmp/portage/games-simulation/openttd-0.5.0/temp/build.log'.

[Comment 1 Denis Gubanov 2007-03-01 11:20:18 UTC]

may be some like

pkg_setup() {
        if ! use dedicated ; then
            if ! built_with_use media-libs/libsdl X ; then
                    die "Please emerge media-libs/libsdl with USE=X"
                fi
            games_pkg_setup
        fi
}


?

[Comment 2 Mr. Bones. (RETIRED) 2007-03-01 17:07:25 UTC]

games_pkg_setup should always be called.

[Comment 3 Lars Weiler (RETIRED) 2007-03-01 18:47:22 UTC]

You are right.  I updated the ebuild that it should ask for X in libsdl only when openttd will not be built with the dedicated USE-flag.