Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 167240 - app-* ebuilds abusing ROOT
Summary: app-* ebuilds abusing ROOT
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Quality Assurance Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-16 18:14 UTC by Ciaran McCreesh
Modified: 2007-06-24 23:10 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ciaran McCreesh 2007-02-16 18:14:46 UTC
Some notes on ROOT:

* The idea behind ROOT is that one can build a system with ROOT=/somewhere and then chroot into it or tar up /somewhere as a system image. It is not designed to allow the user to run /somewhere/usr/bin/foo.

* ROOT can't be used correctly in src_*, since ROOT might be different when merging a binary package. For example, a binary package might be built with ROOT=/ and then installed onto a system using ROOT=/somewhere.

* ROOT isn't used for library dependencies. When building, libraries, headers etc. on / have to be used. Cross-compiling etc is done by configuring the toolchain correctly, not by hacking ebuilds in a way that breaks binary packages.

Ebuilds in app-* that appear to get this wrong will be pasted into comments, since the list is too long for a single place.

Summary of all mentioned herds:
  cjk crypto gnome gnome-office kde lcd mobile-phone no-herd text-markup wine

Summary of all mentioned maintainers:
   <beu@gentoo.org>
   <crypto@gentoo.org>
   <dragonheart@gentoo.org>
   <r3pek@gentoo.org>
   Alessio Cassibba <swapon@gmail.com>
   Leonardo Boshell <leonardop@gentoo.org>
   Markus Ullmann <jokey@gentoo.org>
   Michael Sterrett <mr_bones_@gentoo.org>
   Robert Buchholz <rbu@gentoo.org>
   Saleem Abdulrasool <compnerd@gentoo.org>
Comment 1 Ciaran McCreesh 2007-02-16 18:15:07 UTC
QA checks for package directory /app-admin/syslog-ng:
/app-admin/syslog-ng/syslog-ng-1.6.11-r1.ebuild: root:
  maybe:        ROOT abuse in src_compile on line 39: --with-libol=${ROOT}/usr/bin \
/app-admin/syslog-ng/syslog-ng-1.6.12.ebuild: root:
  maybe:        ROOT abuse in src_compile on line 39: --with-libol=${ROOT}/usr/bin \
metadata.xml:
  herds:        no-herd
  maintainer:   Michael Sterrett <mr_bones_@gentoo.org>


QA checks for package directory /app-admin/usermin:
/app-admin/usermin/usermin-1.220.ebuild: root:
  maybe:        ROOT abuse in src_install on line 57: perl=${ROOT}/usr/bin/perl
  maybe:        ROOT abuse in src_install on line 75: sed -i -e "s:^pidfile=.*$:pidfile=${ROOT}/var/run/usermin.pid:" ${D}/etc/usermin/miniserv.conf
  maybe:        ROOT abuse in src_install on line 76: find ${D}/etc/usermin -type f | xargs sed -i -e "s:${D}:${ROOT}:g"
/app-admin/usermin/usermin-1.230.ebuild: root:
  maybe:        ROOT abuse in src_install on line 57: perl=${ROOT}/usr/bin/perl
  maybe:        ROOT abuse in src_install on line 75: sed -i -e "s:^pidfile=.*$:pidfile=${ROOT}/var/run/usermin.pid:" ${D}/etc/usermin/miniserv.conf
  maybe:        ROOT abuse in src_install on line 76: find ${D}/etc/usermin -type f | xargs sed -i -e "s:${D}:${ROOT}:g"
metadata.xml:
  herds:        no-herd
  maintainer:   <beu@gentoo.org>


QA checks for package directory /app-admin/webmin:
/app-admin/webmin/webmin-1.290-r1.ebuild: root:
  maybe:        ROOT abuse in src_install on line 98: perl=${ROOT}/usr/bin/perl
  maybe:        ROOT abuse in src_install on line 116: sed -i -e "s:^pidfile=.*$:pidfile=${ROOT}/var/run/webmin.pid:" ${D}/etc/webmin/miniserv.conf
  maybe:        ROOT abuse in src_install on line 117: find ${D}/etc/webmin -type f | xargs sed -i -e "s:${D}:${ROOT}:g"
/app-admin/webmin/webmin-1.290.ebuild: root:
  maybe:        ROOT abuse in src_install on line 98: perl=${ROOT}/usr/bin/perl
  maybe:        ROOT abuse in src_install on line 116: sed -i -e "s:^pidfile=.*$:pidfile=${ROOT}/var/run/webmin.pid:" ${D}/etc/webmin/miniserv.conf
  maybe:        ROOT abuse in src_install on line 117: find ${D}/etc/webmin -type f | xargs sed -i -e "s:${D}:${ROOT}:g"
/app-admin/webmin/webmin-1.300-r1.ebuild: root:
  maybe:        ROOT abuse in src_install on line 92: perl=${ROOT}/usr/bin/perl
  maybe:        ROOT abuse in src_install on line 110: sed -i -e "s:^pidfile=.*$:pidfile=${ROOT}/var/run/webmin.pid:" ${D}/etc/webmin/miniserv.conf
  maybe:        ROOT abuse in src_install on line 111: find ${D}/etc/webmin -type f | xargs sed -i -e "s:${D}:${ROOT}:g"
/app-admin/webmin/webmin-1.300.ebuild: root:
  maybe:        ROOT abuse in src_install on line 92: perl=${ROOT}/usr/bin/perl
  maybe:        ROOT abuse in src_install on line 110: sed -i -e "s:^pidfile=.*$:pidfile=${ROOT}/var/run/webmin.pid:" ${D}/etc/webmin/miniserv.conf
  maybe:        ROOT abuse in src_install on line 111: find ${D}/etc/webmin -typ
e f | xargs sed -i -e "s:${D}:${ROOT}:g"
/app-admin/webmin/webmin-1.320.ebuild: root:
  maybe:        ROOT abuse in src_install on line 92: perl=${ROOT}/usr/bin/perl
  maybe:        ROOT abuse in src_install on line 110: sed -i -e "s:^pidfile=.*$:pidfile=${ROOT}/var/run/webmin.pid:" ${D}/etc/webmin/miniserv.conf
  maybe:        ROOT abuse in src_install on line 111: find ${D}/etc/webmin -type f | xargs sed -i -e "s:${D}:${ROOT}:g"
metadata.xml:
  herds:        no-herd
  maintainer:   <beu@gentoo.org>


QA checks for package directory /app-crypt/cryptplug:
/app-crypt/cryptplug/cryptplug-0.3.16-r1.ebuild: root:
  maybe:        ROOT abuse in src_compile on line 31: export GPGME_CONFIG=${ROOT}/usr/bin/gpgme3-config
metadata.xml:
  herds:        crypto
  maintainer:   <crypto@gentoo.org>
Comment 2 Ciaran McCreesh 2007-02-16 18:15:20 UTC

QA checks for package directory /app-crypt/gpgme:
/app-crypt/gpgme/gpgme-0.3.14-r1.ebuild: root:
  maybe:        ROOT abuse in src_compile on line 76: if [ -x "${ROOT}"usr/bin/gpg2 ]; then
  maybe:        ROOT abuse in src_compile on line 77: myconf="${myconf} --with-gpg=${ROOT}usr/bin/gpg2"
  maybe:        ROOT abuse in src_compile on line 79: myconf="${myconf} --with-gpg=${ROOT}usr/bin/gpg"
metadata.xml:
  herds:        crypto
  maintainer:   <dragonheart@gentoo.org>


QA checks for package directory /app-crypt/seahorse:
/app-crypt/seahorse/seahorse-0.6.3-r1.ebuild: root:
  maybe:        ROOT abuse in src_compile on line 34: export GPGME_CONFIG=${ROOT}/usr/bin/gpgme3-config
metadata.xml:
  herds:        gnome
  maintainer:   Saleem Abdulrasool <compnerd@gentoo.org>


QA checks for package directory /app-emulation/virtualbox:
/app-emulation/virtualbox/virtualbox-1.3.4-r1.ebuild: root:
  maybe:        ROOT abuse in src_install on line 55: make_wrapper xpidl "sdk/bin/xpidl" "${ROOT}opt/VirtualBox" "/opt/VirtualBox" "/usr/bin"
  maybe:        ROOT abuse in src_install on line 65: make_wrapper vboxsvc "./VBoxSVC" "${ROOT}opt/VirtualBox" "/opt/VirtualBox" "/usr/bin"
  maybe:        ROOT abuse in src_install on line 66: make_wrapper virtualbox "./VirtualBox" "${ROOT}opt/VirtualBox" "/opt/VirtualBox" "/usr/bin"
  maybe:        ROOT abuse in src_install on line 67: make_wrapper vboxmanage "./VBoxManage" "${ROOT}opt/VirtualBox" "/opt/VirtualBox" "/usr/bin"
  maybe:        ROOT abuse in src_install on line 68: make_wrapper vboxsdl "./VBoxSDL" "${ROOT}opt/VirtualBox" "/opt/VirtualBox" "/usr/bin"
  maybe:        ROOT abuse in src_install on line 69: make_wrapper vboxvrdp "./VBoxVRDP" "${ROOT}opt/VirtualBox" "/opt/VirtualBox" "/usr/bin"
/app-emulation/virtualbox/virtualbox-1.3.4.ebuild: root:
  maybe:        ROOT abuse in src_install on line 53: make_wrapper vboxsvc "./VBoxSVC" "${ROOT}opt/VirtualBox" "/opt/VirtualBox" "/usr/bin"
  maybe:        ROOT abuse in src_install on line 54: make_wrapper virtualbox "./VirtualBox" "${ROOT}opt/VirtualBox" "/opt/VirtualBox" "/usr/bin"
/app-emulation/virtualbox/virtualbox-9999.ebuild: root:
  maybe:        ROOT abuse in src_install on line 52: make_wrapper xpidl "sdk/bin/xpidl" "${ROOT}opt/VirtualBox" "/opt/VirtualBox" "/usr/bin"
  maybe:        ROOT abuse in src_install on line 62: make_wrapper vboxsvc "./VBoxSVC" "${ROOT}opt/VirtualBox" "/opt/VirtualBox" "/usr/bin"
  maybe:        ROOT abuse in src_install on line 63: make_wrapper virtualbox "./VirtualBox" "${ROOT}opt/VirtualBox" "/opt/VirtualBox" "/usr/bin"
  maybe:        ROOT abuse in src_install on line 64: make_wrapper vboxmanage "./VBoxManage" "${ROOT}opt/VirtualBox" "/opt/VirtualBox" "/usr/bin"
  maybe:        ROOT abuse in src_install on line 65: make_wrapper vboxsdl "./VBoxSDL" "${ROOT}opt/VirtualBox" "/opt/VirtualBox" "/usr/bin"
  maybe:        ROOT abuse in src_install on line 66: make_wrapper vboxvrdp "./VBoxVRDP" "${ROOT}opt/VirtualBox" "/opt/VirtualBox" "/usr/bin"
metadata.xml:
  herds:        no-herd
  maintainer:   Markus Ullmann <jokey@gentoo.org>
  maintainer:   Alessio Cassibba <swapon@gmail.com>


QA checks for package directory /app-emulation/virtualbox-bin:
/app-emulation/virtualbox-bin/virtualbox-bin-1.3.4.ebuild: root:
  maybe:        ROOT abuse in src_install on line 86: make_wrapper vboxsvc "./VBoxSVC" "${ROOT}opt/VirtualBox" "/opt/VirtualBox" "/usr/bin"
  maybe:        ROOT abuse in src_install on line 87: make_wrapper virtualbox "./VirtualBox" "${ROOT}opt/VirtualBox" "/opt/VirtualBox" "/usr/bin"
  maybe:        ROOT abuse in src_install on line 88: make_wrapper vboxmanage "./VBoxManage" "${ROOT}opt/VirtualBox" "/opt/VirtualBox" "/usr/bin"
  maybe:        ROOT abuse in src_install on line 89: make_wrapper vboxsdl "./VBoxSDL" "${ROOT}opt/VirtualBox" "/opt/VirtualBox" "/usr/bin"
  maybe:        ROOT abuse in src_install on line 90: make_wrapper vboxvrdp "./VBoxVRDP" "${ROOT}opt/VirtualBox" "/opt/VirtualBox" "/usr/bin"
metadata.xml:
  herds:        no-herd
  maintainer:   Markus Ullmann <jokey@gentoo.org>
  maintainer:   Alessio Cassibba <swapon@gmail.com>


QA checks for package directory /app-emulation/wine:
/app-emulation/wine/wine-0.9.1.ebuild: root:
  maybe:        ROOT abuse in src_compile on line 117: use lcms && append-flags -I"${ROOT}"/usr/include/lcms
/app-emulation/wine/wine-0.9.2.ebuild: root:
  maybe:        ROOT abuse in src_compile on line 117: use lcms && append-flags -I"${ROOT}"/usr/include/lcms
/app-emulation/wine/wine-0.9.3.ebuild: root:
  maybe:        ROOT abuse in src_compile on line 117: use lcms && append-flags -I"${ROOT}"/usr/include/lcms
/app-emulation/wine/wine-0.9.4.ebuild: root:
  maybe:        ROOT abuse in src_compile on line 118: use lcms && append-flags -I"${ROOT}"/usr/include/lcms
/app-emulation/wine/wine-0.9.5-r1.ebuild: root:
  maybe:        ROOT abuse in src_compile on line 103: use lcms && append-flags -I"${ROOT}"/usr/include/lcms
/app-emulation/wine/wine-0.9.6.ebuild: root:
  maybe:        ROOT abuse in src_compile on line 116: use lcms && append-flags -I"${ROOT}"/usr/include/lcms
/app-emulation/wine/wine-0.9.7.ebuild: root:
  maybe:        ROOT abuse in src_compile on line 100: use lcms && append-flags -I"${ROOT}"/usr/include/lcms
  maybe:        ROOT abuse in src_compile on line 117: use lcms && append-flags -I"${ROOT}"/usr/include/lcms
/app-emulation/wine/wine-20041019-r3.ebuild: root:
  maybe:        ROOT abuse in src_compile on line 86: use lcms && append-flags -I${ROOT}/usr/include/lcms
/app-emulation/wine/wine-20050111-r2.ebuild: root:
  maybe:        ROOT abuse in src_compile on line 87: use lcms && append-flags -I${ROOT}/usr/include/lcms
/app-emulation/wine/wine-20050211.ebuild: root:
  maybe:        ROOT abuse in src_compile on line 109: use lcms && append-flags -I"${ROOT}"/usr/include/lcms
/app-emulation/wine/wine-20050310-r1.ebuild: root:
  maybe:        ROOT abuse in src_compile on line 110: use lcms && append-flags -I"${ROOT}"/usr/include/lcms
/app-emulation/wine/wine-20050419.ebuild: root:
  maybe:        ROOT abuse in src_compile on line 109: use lcms && append-flags -I"${ROOT}"/usr/include/lcms
/app-emulation/wine/wine-20050524.ebuild: root:
  maybe:        ROOT abuse in src_compile on line 109: use lcms && append-flags -I"${ROOT}"/usr/include/lcms
/app-emulation/wine/wine-20050628.ebuild: root:
  maybe:        ROOT abuse in src_compile on line 108: use lcms && append-flags -I"${ROOT}"/usr/include/lcms
/app-emulation/wine/wine-20050725-r1.ebuild: root:
  maybe:        ROOT abuse in src_compile on line 109: use lcms && append-flags -I"${ROOT}"/usr/include/lcms
/app-emulation/wine/wine-20050830.ebuild: root:
  maybe:        ROOT abuse in src_compile on line 109: use lcms && append-flags -I"${ROOT}"/usr/include/lcms
/app-emulation/wine/wine-20050930.ebuild: root:
  maybe:        ROOT abuse in src_compile on line 119: use lcms && append-flags -I"${ROOT}"/usr/include/lcms
metadata.xml:
  herds:        wine

Comment 3 Ciaran McCreesh 2007-02-16 18:15:38 UTC
QA checks for package directory /app-i18n/jless:
/app-i18n/jless/jless-358.254.ebuild: root:
  maybe:        ROOT abuse in src_install on line 46: if [ ! -f ${ROOT}/usr/bin/lesspipe.sh ] ; then
/app-i18n/jless/jless-382.258.ebuild: root:
  maybe:        ROOT abuse in src_install on line 55: if [ ! -f ${ROOT}/usr/bin/lesspipe.sh ] ; then
metadata.xml:
  herds:        cjk


QA checks for package directory /app-misc/g15composer:
/app-misc/g15composer/g15composer-3.0.2.ebuild: root:
  maybe:        ROOT abuse in src_install on line 48: exeinto "${ROOT}usr/share/${PN}"
  maybe:        ROOT abuse in src_install on line 52: exeinto "${ROOT}usr/share/apps/amarok/scripts"
/app-misc/g15composer/g15composer-3.1.ebuild: root:
  maybe:        ROOT abuse in src_install on line 49: exeinto "${ROOT}/usr/share/${PN}"
  maybe:        ROOT abuse in src_install on line 54: exeinto "${ROOT}/usr/share/apps/amarok/scripts"
metadata.xml:
  herds:        lcd
  maintainer:   Robert Buchholz <rbu@gentoo.org>


QA checks for package directory /app-misc/tracker:
/app-misc/tracker/tracker-0.5.4.ebuild: root:
  maybe:        ROOT abuse in src_compile on line 109: myconf="${myconf} --with-deskbar-applet-handler-dir=${ROOT}usr/$(get_libdir)/deskbar-applet/handlers/"
metadata.xml:
  herds:        no-herd
  maintainer:   Saleem Abdulrasool <compnerd@gentoo.org>


QA checks for package directory /app-misc/workrave:
/app-misc/workrave/workrave-1.8.3.ebuild: root:
  maybe:        ROOT abuse in src_compile on line 75: addwrite "${ROOT}/usr/qt/3/etc/settings"
metadata.xml:
  herds:        gnome
  maintainer:   Leonardo Boshell <leonardop@gentoo.org>


/app-mobilephone/moto4lin/moto4lin-0.3.ebuild: root:
  maybe:        ROOT abuse in src_compile on line 22: addwrite "${ROOT}/usr/qt/3/etc/settings"
/app-mobilephone/moto4lin/moto4lin-0.3_p20051125.ebuild: root:
  maybe:        ROOT abuse in src_compile on line 22: addwrite "${ROOT}/usr/qt/3/etc/settings"
metadata.xml:
  herds:        mobile-phone
  maintainer:   <r3pek@gentoo.org>


QA checks for package directory /app-office/abiword:
/app-office/abiword/abiword-2.4.5-r1.ebuild: root:
  maybe:        ROOT abuse in src_install on line 72: make DESTDIR="${D}" icondir="${ROOT}usr/share/pixmaps" install || die "Installation failed"
/app-office/abiword/abiword-2.4.6.ebuild: root:
  maybe:        ROOT abuse in src_install on line 68: make DESTDIR="${D}" icondir="${ROOT}usr/share/pixmaps" install || die "install failed"
metadata.xml:
  herds:        gnome-office


QA checks for package directory /app-office/koffice-libs:
/app-office/koffice-libs/koffice-libs-1.5.2.ebuild: root:
  maybe:        ROOT abuse in src_compile on line 52: local myconf="--enable-scripting --with-pythonfir=${ROOT}/usr/$(get_libdir)/python${PYVER}/site-packages"
/app-office/koffice-libs/koffice-libs-1.6.1.ebuild: root:
  maybe:        ROOT abuse in src_compile on line 52: local myconf="--enable-scripting --with-pythonfir=${ROOT}/usr/$(get_libdir)/python${PYVER}/site-packages"
/app-office/koffice-libs/koffice-libs-1.6.2.ebuild: root:
  maybe:        ROOT abuse in src_compile on line 52: local myconf="--enable-scripting --with-pythonfir=${ROOT}/usr/$(get_libdir)/python${PYVER}/site-packages"
metadata.xml:
  herds:        kde


QA checks for package directory /app-text/linuxdoc-tools:
/app-text/linuxdoc-tools/linuxdoc-tools-0.9.21_p4.ebuild: root:
  maybe:        ROOT abuse in src_install on line 67: export SGML_CATALOG_FILES="${ROOT}/usr/share/sgml/sgml-iso-entities-8879.1986/catalog"
metadata.xml:
  herds:        text-markup



(that's all for app-*)
Comment 4 Jakub Moc (RETIRED) gentoo-dev 2007-02-16 18:24:50 UTC
Good too see that the quality of output of your QA tool really rocks... Please use attachments in future because this is completely unreadable mess.
Comment 5 Stephen Bennett (RETIRED) gentoo-dev 2007-02-16 19:00:43 UTC
On the contrary, it's clearly separated by package, with maintainer information attached to each and a summary at the beginning. Since apparently jakub can't be bothered to bug wrangle, CC-ing relevant maintainers...
Comment 6 Diego Elio Pettenò (RETIRED) gentoo-dev 2007-02-16 20:30:10 UTC
KDE done.
Comment 7 Markus Ullmann (RETIRED) gentoo-dev 2007-02-16 20:36:12 UTC
app-emulation/virtualbox* done
Comment 8 Diego Elio Pettenò (RETIRED) gentoo-dev 2007-02-16 20:40:18 UTC
CJK done.
Comment 9 Saleem Abdulrasool (RETIRED) gentoo-dev 2007-02-16 20:47:39 UTC
gnome-office, compnerd done
Comment 10 Daniel Black (RETIRED) gentoo-dev 2007-02-16 22:18:55 UTC
cryptplug and gpgme perfected
Comment 11 Leonardo Boshell (RETIRED) gentoo-dev 2007-02-16 23:38:51 UTC
Ports fixed:
  app-misc/workrave
  app-text/linuxdoc-tools

Thanks.
Comment 12 Robert Buchholz (RETIRED) gentoo-dev 2007-02-18 19:41:31 UTC
Thanks for the hint, fixed g15composer and g15daemon.
Comment 13 Alin Năstac (RETIRED) gentoo-dev 2007-03-10 14:52:37 UTC
fixed app-mobilephone/moto4lin
Comment 14 Piotr Jaroszyński (RETIRED) gentoo-dev 2007-06-24 23:10:17 UTC
I have fixed the rest.