166825 – sys-apps/eject incorrectly handles mount points with spaces in name

Bug 166825 - sys-apps/eject incorrectly handles mount points with spaces in name

Summary: sys-apps/eject incorrectly handles mount points with spaces in name

Status:	RESOLVED DUPLICATE of bug 151257

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High normal
Assignee:	Gentoo Linux bug wranglers

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2007-02-14 13:10 UTC by Jan
Modified:	2007-02-14 13:40 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Resolves the problem of white spaces in mount points (eject.patch,1.63 KB, patch) 2007-02-14 13:13 UTC, Jan	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jan 2007-02-14 13:10:25 UTC

If I could have done so, I would have re-opened this bug: http://bugs.gentoo.org/show_bug.cgi?id=151257. The patch suggested there does not resolve the problem of white spaces in mount points in my opinion.

De-mangling of the mount points must be done *before* the strcmp(), not afterwards. Additionally, I would suggest testing for "\0nn" when looking for an octal number rather than testing for "\nnn".

Comment 1 Jan 2007-02-14 13:13:42 UTC

Created attachment 110163 [details, diff]
Resolves the problem of white spaces in mount points

Comment 2 Jakub Moc (RETIRED) gentoo-dev

2007-02-14 13:40:16 UTC


*** This bug has been marked as a duplicate of bug 151257 ***