As said above... :) --- xfce44.eclass 2007-01-25 20:35:54.000000000 +0100 +++ xfce44.eclass 2007-01-28 04:36:40.000000000 +0100 @@ -16,7 +16,7 @@ COMPRESS=".tar.bz2" CONFIGURE="econf" -INSTALL="make DESTDIR=${D} install" +INSTALL="emake DESTDIR=${D} install" XFCE_BETA_VERSION="4.3.99.2" XFCE_VERSION="4.4.0"
I've just passed set of fixes to welp which includes a fix for this but instead of using emake I've added gmake. And why? There was issues when installing several Xfce4 packages in a row, files from other packages getting owned by next package in installation list. Read, A MESS. What now? gmake obviously fixes building issues for g/fbsd and this is solved but if you want emake there, for QA reasons we need someone to test building several of xfce4 packages in a row with emake in eclass instead of gmake. After installation running qlist/qfile/equery or such to verify correct files are owned by correct package.
> using emake I've added gmake. No, we should not replace it with gmake for sure. > There was issues when installing several Xfce4 packages in a row, files from > other packages getting owned by next package in installation list. Read, A > MESS. That has nothing to do with make vs. emake vs. gmake. It's called a collision, you'd find out if you turned on collision-protect feature in make.conf if your package manager supported such feature. :P That said, I only hit one collision on upgrading from 4.3.99 which has been already fixed in Bug 163213. If you have more, file a *new* bug about those, has nothing to do with this one.
Wasn't about file collisions, but something about parallel make causing problems. Anyway, couldn't reproduce them anymore at all so whatever. emake is fine by me too.
Using emake now, thanks to welp.
