Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 164114 - Add exclude to prepalldocs
Summary: Add exclude to prepalldocs
Status: RESOLVED DUPLICATE of bug 260118
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Enhancement/Feature Requests (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-27 22:25 UTC by Alon Bar-Lev (RETIRED)
Modified: 2009-06-30 09:39 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
prepalldocs (prepalldocs,762 bytes, text/plain)
2007-01-27 22:46 UTC, SpanKY
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alon Bar-Lev (RETIRED) gentoo-dev 2007-01-27 22:25:57 UTC
Currently prepalldocs excludes automatically "html" subdirectory, I would like it to be able to add other subdirectories.

Something like:
DOCS_EXCLUDE="d1 d2 d3" prepalldocs

Should be simple addition of for loop.

Thanks!
Comment 1 SpanKY gentoo-dev 2007-01-27 22:46:23 UTC
Created attachment 108318 [details]
prepalldocs

DOCS_EXCLUDE is a crappy variable name ... perhaps a better method would be to pass it them in as arguments:
prepalldocs -x d1 -x d2 -x d3

either way, here's an easy way of doing this
Comment 2 Alon Bar-Lev (RETIRED) gentoo-dev 2007-01-27 22:51:47 UTC
Thanks for quick response!
Waiting to use this... :)
Comment 3 Alon Bar-Lev (RETIRED) gentoo-dev 2007-03-02 22:50:52 UTC
Hello, Is there target version/revision for this?
Comment 4 Alon Bar-Lev (RETIRED) gentoo-dev 2007-04-06 19:57:27 UTC
Maybe also add an optional argument of a directory to prep... So it can be used for other locations as well...

Just curios... Why a simple patch as this one is sitting so long opened? Is there something wrong with the request?
Comment 5 Zac Medico gentoo-dev 2007-05-23 01:43:36 UTC
For interface changes within the ebuild environment, it's best to version them via EAPI.  The next best alternative is to make ebuilds depend on a version of portage that supports the required interfaces, but that's a poor substitute for EAPI.  See bug 179380 for a similar situation.
Comment 6 Alon Bar-Lev (RETIRED) gentoo-dev 2007-05-23 15:02:00 UTC
Thanks,
But this does not change the interface. The default behavior is the same.
But OK...
We will wait.
Comment 7 Marius Mauch (RETIRED) gentoo-dev 2007-06-06 01:02:56 UTC
(In reply to comment #6)
> Thanks,
> But this does not change the interface. The default behavior is the same.

An extension is also a change to the interface (ebuilds relying on the extension may not work correctly with portage versions not having that extension). That said, it could be handled with a portage dep in this case, but that wouldn't be nice to non-portage users.
Comment 8 Ciaran McCreesh 2007-06-19 10:08:40 UTC
prep* shouldn't be in ebuilds or PMS anyway...
Comment 9 SpanKY gentoo-dev 2007-06-19 18:28:29 UTC
incorrect as already noted on the gentoo-dev mailing list

there is no clean way to get the functionality of `prepalldocs` other than `prepalldocs`

most prep* functions are transparent, but many of them need to be in EAPI-0
Comment 10 Alon Bar-Lev (RETIRED) gentoo-dev 2007-10-06 08:09:12 UTC
What about EAPI-1?
Comment 11 Zac Medico gentoo-dev 2007-10-06 08:50:56 UTC
I guess this one will have to wait until EAPI-2 since EAPI-1 is already defined (bug #194876). It wouldn't set a very good precedent if we were to go and change the definition now (even though >=sys-apps/portage-2.1.3.12 hasn't been marked stable yet).

For inclusion, I think we should update the patch to use some kind of command argument interface as suggested in comment #1 since the environment variable approach seems unclean (why pollute the environment with yet another variable).
Comment 12 Ulrich Müller gentoo-dev 2009-06-30 09:39:04 UTC
This is obsoleted by bug 260118 I'd say.


*** This bug has been marked as a duplicate of bug 260118 ***