164015 – media-video/cxfe patch to compile when LDFLAGS=-Wl,--as-needed

Bug 164015 - media-video/cxfe patch to compile when LDFLAGS=-Wl,--as-needed

Summary: media-video/cxfe patch to compile when LDFLAGS=-Wl,--as-needed

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Gentoo Media-video project

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	as-needed
	Show dependency tree

Reported:	2007-01-27 02:50 UTC by Daniel Lin
Modified:	2007-01-30 19:20 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Daniel Lin 2007-01-27 02:50:59 UTC

cxfe fails to link when LDFLAGS=-Wl,--as-needed is specified in make.conf.

Reproducible: Always

Steps to Reproduce:
1. Add LDFLAGS=-Wl,--as-needed to /etc/make.conf
2. emerge cxfe
3.

Actual Results:  
The link stage errors out with undefined references.

Expected Results:  
The emerge should complete successfully.

The following patch is sufficient.  I haven't submitted to upstream yet.

diff -uprN old-cxfe-0.9.1/Makefile.in new-cxfe-0.9.1/Makefile.in
--- old-cxfe-0.9.1/Makefile.in 2007-01-26 21:41:54.899079600 -0500
+++ new-cxfe-0.9.1/Makefile.in      2007-01-26 21:42:39.538269611 -0500
@@ -14,7 +14,7 @@ mandir = $(prefix)/man/man1
 CC = @CC@ -Wall
 CPPFLAGS = @CPPFLAGS@
 CFLAGS = $(CPPFLAGS) @CFLAGS@ `xine-config --cflags`
-LIBS = @LIBS@
+LDLIBS = @LIBS@
 LDFLAGS = `xine-config --libs` -L/usr/X11R6/lib -lXext @LDFLAGS@ @LIBS@ -lX11
 INSTALL = @INSTALL@

Comment 1 Alexis Ballier gentoo-dev

2007-01-30 19:20:23 UTC

Applied, thanks.