Added support for portage ROOT in qmerge applet. Reproducible: Always I had problems with compiling the cvs version but 0.1.23 seems to be unmodified so the patch is agains 0.1.23.
Created attachment 107799 [details, diff] qmerge_portroot_support.patch
Natanael, thanks for the patch but could you please. cd portage-utils/tests/source make check # then attach an updated patch. tia
Created attachment 107813 [details, diff] qmerge_portroot_support_v2.patch Updated patch attached. btw... Why is BUFSIZE better than PATH_MAX? Looks like its double the size than needed for path operations.
(In reply to comment #3) > Created an attachment (id=107813) [edit] > qmerge_portroot_support_v2.patch > > Updated patch attached. > > btw... Why is BUFSIZE better than PATH_MAX? Looks like its double the > size than needed for path operations. You want _Q_PATH_MAX main.c /* make sure our buffers are as big as they can be */ #if PATH_MAX > _POSIX_PATH_MAX /* _Q_PATH_MAX */ # define _Q_PATH_MAX PATH_MAX #else # define _Q_PATH_MAX _POSIX_PATH_MAX #endif
Created attachment 107875 [details, diff] qmerge_portroot_support_v3.patch s/BUFSIZE/_Q_PATH_MAX/g thanks!
Created attachment 107898 [details, diff] qmerge-mkdirhier.diff Commited v3 of your patch. I would like to make the following change to it to avoid the extra system() call. Could you please test? tia
(In reply to comment #6) > Created an attachment (id=107898) [edit] > qmerge-mkdirhier.diff > > Commited v3 of your patch. I would like to make the following change to it to > avoid the extra system() call. Could you please test? tia > Yes. it looks better. works for me. btw... seems like empty dirs are not properly removed with qmerge -U. I think it can be commited to cvs anyway. Its a good start.
(In reply to comment #7) > btw... seems like empty dirs are not properly removed with qmerge -U. Feel free to poke around. A blind rmdir() as long as no other pkg owns said dir is safe. --------------------------- Closing bug as FIXED. Any other additions to qmerge just file a new bug. Or search for bugs assigned to portage-utils@gentoo if you want to take a stab at any of the existing requests.
