Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 162859 - [xfce4-svn overlay]: add thunar-volman ebuild, fix xfce4-cpufreq src_compile() and remove debug.eclass warnings
Summary: [xfce4-svn overlay]: add thunar-volman ebuild, fix xfce4-cpufreq src_compile(...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: XFCE Team
URL:
Whiteboard:
Keywords:
: 163378 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-01-20 00:20 UTC by Adam James
Modified: 2007-01-31 21:30 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
diff for revision 5 of xfce4-svn overlay (xfce4-svn-r5.diff,4.03 KB, patch)
2007-01-20 00:21 UTC, Adam James
Details | Diff
updated diff for revision 5 of xfce4-svn overlay (xfce4-svn-r5+volman+mpc.diff,5.17 KB, patch)
2007-01-21 19:37 UTC, Adam James
Details | Diff
patch to add thunar-volman to svn tree (thunar-volman-svn2.diff,1.87 KB, patch)
2007-01-23 02:01 UTC, Sebastian Krämer
Details | Diff
ebuild draft for thunar-volman-0.1.2 (thunar-volman-0.1.2.ebuild,444 bytes, text/plain)
2007-01-26 18:12 UTC, Steffen Bach
Details
thunar-volman-0.1.2.ebuild (thunar-volman-0.1.2.ebuild,762 bytes, text/plain)
2007-01-29 17:28 UTC, Samuli Suominen (RETIRED)
Details
thunar-volman-0.1.2.ebuild (thunar-volman-0.1.2.ebuild,745 bytes, text/plain)
2007-01-31 10:04 UTC, Samuli Suominen (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Adam James 2007-01-20 00:20:48 UTC
Hello,

Just a few enhancements for the xfce4-svn overlay. Firstly, a new thunar plugin called volman. Secondly, xfce4-cpufreq provides autogen now, rather than configure, so a minor amendment to src_compile(). Finally, the xfce4-svn eclass is still inheriting debug (which is deprecated), so I removed it. Not sure if this is correct, but I tested the debug use flag and it still behaved as expected.

This is my first Gentoo bug report, so be gentle!
Comment 1 Adam James 2007-01-20 00:21:48 UTC
Created attachment 107491 [details, diff]
diff for revision 5 of xfce4-svn overlay
Comment 2 Adam James 2007-01-21 19:37:32 UTC
Created attachment 107711 [details, diff]
updated diff for revision 5 of xfce4-svn overlay

Updated the diff to include another extra - xfce4-mpc panel plugin.
Comment 3 Sebastian Krämer 2007-01-23 01:57:18 UTC
Hey Adam,

I found your report just after I posted a request for thunar-volman myself (bug #163378).

Just a note, it always helps if you create separate patches for different issues. That makes it easier for maintainers to review and apply one patch for volman, one for removing the debug eclass etc. Depending on the issue you better even create separate bug reports (not sure if that's necessary here though).
Comment 4 Sebastian Krämer 2007-01-23 02:01:16 UTC
Created attachment 107862 [details, diff]
patch to add thunar-volman to svn tree

My attachment from the other bugreport.
I added the dependencies Adam used (although I'm not sure if the version numbers match svn's requirements).
Comment 5 Jakub Moc (RETIRED) gentoo-dev 2007-01-23 07:11:01 UTC
*** Bug 163378 has been marked as a duplicate of this bug. ***
Comment 6 Steffen Bach 2007-01-26 18:12:53 UTC
Created attachment 108217 [details]
ebuild draft for thunar-volman-0.1.2

This ebuild works for me on x86
Comment 7 Sebastian Krämer 2007-01-26 19:43:21 UTC
(In reply to comment #6)
> Created an attachment (id=108217) [edit]
> ebuild draft for thunar-volman-0.1.2

Hm, IMO this is something different, not for the xfce svn overlay..

> This ebuild works for me on x86

Sidenote, my latest portage update of hal pulled dbus and dbus-glib automatically, if I remember correctly. It could be removed from the dependecies in your ebuild, could it? (not tested)

Comment 8 Jakub Moc (RETIRED) gentoo-dev 2007-01-28 04:01:16 UTC
The dbus deps are wrong in all attached ebuilds; should depend on dbus bindings (like dbus-glib), not dbus itself.
Comment 9 Sebastian Krämer 2007-01-28 14:01:36 UTC
(In reply to comment #8)
> The dbus deps are wrong in all attached ebuilds; should depend on dbus bindings
> (like dbus-glib), not dbus itself.

So what does that mean? One of the previous patches with correct dependencies to dbus-glib would be okay (= get applied)?
Comment 10 Dustin C. Hatch 2007-01-29 02:19:54 UTC
Any idea on how long until the debug.eclass is removed from the ebuilds?  Would be nice to be rid of the " * QA Notice: The package xfce-[extra|base]/* still uses the broken debug.eclass" I get once a day.
Comment 11 Samuli Suominen (RETIRED) gentoo-dev 2007-01-29 05:20:40 UTC
(In reply to comment #10)
> Any idea on how long until the debug.eclass is removed from the ebuilds?  Would
> be nice to be rid of the " * QA Notice: The package xfce-[extra|base]/* still
> uses the broken debug.eclass" I get once a day.
> 

4.4.0 doesn't use debug.eclass anymore.
Comment 12 Dustin C. Hatch 2007-01-29 16:10:38 UTC
(In reply to comment #11)
> (In reply to comment #10)
> > Any idea on how long until the debug.eclass is removed from the ebuilds?  Would
> > be nice to be rid of the " * QA Notice: The package xfce-[extra|base]/* still
> > uses the broken debug.eclass" I get once a day.
> > 
> 
> 4.4.0 doesn't use debug.eclass anymore.
> 
The xfce-svn.eclass inherits debug, which is what this bug regards.
Comment 13 Samuli Suominen (RETIRED) gentoo-dev 2007-01-29 17:28:08 UTC
Created attachment 108506 [details]
thunar-volman-0.1.2.ebuild

*plop*
Comment 14 Samuli Suominen (RETIRED) gentoo-dev 2007-01-31 10:04:28 UTC
Created attachment 108740 [details]
thunar-volman-0.1.2.ebuild

Adjusting DESCRIPTION..
Comment 15 Samuli Suominen (RETIRED) gentoo-dev 2007-01-31 15:38:05 UTC
Comment on attachment 108740 [details]
thunar-volman-0.1.2.ebuild

In tree, thanks to welp.
Comment 16 Peter Weller (RETIRED) gentoo-dev 2007-01-31 21:30:18 UTC
Closing...