Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 162528 - app-crypt/bestcrypt fails to compile against >= linux-2.6.19
Summary: app-crypt/bestcrypt fails to compile against >= linux-2.6.19
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Crypto team [DISABLED]
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: kernel-2.6.19
  Show dependency tree
 
Reported: 2007-01-17 12:15 UTC by Brandon Low
Modified: 2007-01-18 22:09 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
bestcrypt-1.6_p10-r1.ebuild.diff (bestcrypt-1.6_p10-r1.ebuild.diff,1.16 KB, patch)
2007-01-18 12:42 UTC, Alon Bar-Lev (RETIRED)
Details | Diff
bestcrypt-1.6_p10-kernel-version.patch (bestcrypt-1.6_p10-kernel-version.patch,440 bytes, patch)
2007-01-18 12:44 UTC, Alon Bar-Lev (RETIRED)
Details | Diff
bestcrypt-1.6_p10-r1.ebuild.diff (bestcrypt-1.6_p10-r1.ebuild.diff,1.04 KB, text/plain)
2007-01-18 12:52 UTC, Alon Bar-Lev (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Brandon Low 2007-01-17 12:15:40 UTC
As of linux-2.6.19 the config.h header file appears to have been officially removed in favor of autoconf.h.  Bestcrypt compiles fine with a simple sed:

sed -ie 's:linux/config.h:linux/autoconf.h' mod/mkver.c

but I'm not sure if this breaks with older kernel versions.  perhaps a function needs to be added to kernel-mod.eclass which will take a list of files to fix and change from linux/config.h <-> linux/autoconf.h correctly based on kernel version?
Comment 1 Alon Bar-Lev (RETIRED) gentoo-dev 2007-01-17 12:29:11 UTC
Which version do you use?
I tested bestcrypt-1.6_p10 and it compiles fine.
Comment 2 Brandon Low 2007-01-17 12:32:15 UTC
am trying to merge 1.6_p10

what kernel version are you running and have linked in /usr/src/linux?
Comment 4 Alon Bar-Lev (RETIRED) gentoo-dev 2007-01-17 19:32:59 UTC
I use 2.6.19...
Very strange!
Comment 5 Brandon Low 2007-01-17 19:39:50 UTC
are you using vanilla or another kernel patchset?  Perhaps the patch un-removes the header?
Comment 6 Alon Bar-Lev (RETIRED) gentoo-dev 2007-01-17 19:44:08 UTC
I will take a look at this over the week-end.
Comment 7 Daniel Drake (RETIRED) gentoo-dev 2007-01-17 19:52:39 UTC
The correct solution is along the lines of:

#include <linux/version.h>
#if LINUX_VERSION_CODE <= KERNEL_VERSION(2,6,18)
#include <linux/config.h>
#endif

No include is needed on recent kernels. Changing to autoconf.h will probably break in the near future.
Comment 8 Alon Bar-Lev (RETIRED) gentoo-dev 2007-01-17 19:54:38 UTC
Daniel,
What about genkernel --kernel-config?
It should be fixed too, right?
Comment 9 Alon Bar-Lev (RETIRED) gentoo-dev 2007-01-17 19:56:29 UTC
Oh!
I messed up the config.h and .config.
I still don't understand how it works for me...
Will check what went wrong.
Comment 10 Alon Bar-Lev (RETIRED) gentoo-dev 2007-01-18 12:42:35 UTC
Created attachment 107363 [details, diff]
bestcrypt-1.6_p10-r1.ebuild.diff

Well... My configuration was the correct one... mkver should not be compiled under 2.6... Strange enough there was an explicit attempt to compile it.

Another problem is that the Makefile determine the kernel version by uname... And not the one it compiles...

And added no-strict-aliasing (reported to upstream).

Since I don't have a working configuration, can you please check if the attached ebuild works for you?
Comment 11 Alon Bar-Lev (RETIRED) gentoo-dev 2007-01-18 12:44:01 UTC
Created attachment 107365 [details, diff]
bestcrypt-1.6_p10-kernel-version.patch
Comment 12 Alon Bar-Lev (RETIRED) gentoo-dev 2007-01-18 12:52:47 UTC
Created attachment 107367 [details]
bestcrypt-1.6_p10-r1.ebuild.diff

Even cleaner.
Comment 13 Brandon Low 2007-01-18 15:42:04 UTC
works fine for me.
Comment 14 Alon Bar-Lev (RETIRED) gentoo-dev 2007-01-18 22:09:59 UTC
Thanks!