Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 160333 - sys-kernel/genkernel: smarter doslowusb (DO_slowusb) triggering
Summary: sys-kernel/genkernel: smarter doslowusb (DO_slowusb) triggering
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: genkernel (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Genkernel Maintainers
Depends on:
Reported: 2007-01-05 15:13 UTC by Fabio Erculiani
Modified: 2007-06-21 06:04 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

smarter "slowusb" triggering (genkernel-3.4.5-smarter-doslowusb.patch,1.48 KB, patch)
2007-01-05 15:20 UTC, Fabio Erculiani
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fabio Erculiani 2007-01-05 15:13:34 UTC
title says it all. Attacching the patch. Not the best solution but it:
- works
- does not harm
- is very useful

doslowusb option is automagically triggered only when really needed.
Comment 1 Fabio Erculiani 2007-01-05 15:20:15 UTC
Created attachment 105583 [details, diff]
smarter "slowusb" triggering
Comment 2 Chris Gianelloni (RETIRED) gentoo-dev 2007-01-07 18:50:44 UTC

This breaks support on the IBM bladecenter, at least.
Comment 3 Fabio Erculiani 2007-01-07 22:14:23 UTC
hey, it's just an enhancement, it does not break anything! doslowusb or --slowusb is still usable as before.
Comment 4 Fabio Erculiani 2007-01-07 22:16:23 UTC
btw, what a wonderful way of trying to improve this "slowusb" hack... why does it break? is the IBM bladecenter the only problem? I think that it could be fixed in the same way too... What a lazy answer :-(
Comment 5 Fabio Erculiani 2007-03-02 19:48:41 UTC
as usual... an incomplete answer... I don't usually expect this kind of feedback from a developer :S
Comment 6 Marijn Schouten (RETIRED) gentoo-dev 2007-04-04 16:55:30 UTC

so, fixed instead?
Comment 7 Chris Gianelloni (RETIRED) gentoo-dev 2007-04-05 12:22:48 UTC
No.  I've had some issues with the patch, especially on slower machines, as it causes some serious delays, which I am trying to work out.
Comment 8 Fabio Erculiani 2007-04-05 13:58:02 UTC
but it's in the SVN, so the resolution of this bug is wrong (WONTFIX).
maybe that the "serious" delay is caused by the "sleep 10" line...? That line was always triggered, even in the past, appending "doslowusb" boot option.
I still can't understand the reasons of what you wrote here, because you added that to the source code anyway... and it's there since _pre2 AFAIK.
Comment 9 Fabio Erculiani 2007-05-18 08:37:37 UTC
Ok, so reopening.
Comment 10 Chris Gianelloni (RETIRED) gentoo-dev 2007-06-21 00:23:43 UTC
This caused a huge number of complaints on the 2007.0 release, so I am reverting this patch.
Comment 11 Fabio Erculiani 2007-06-21 06:04:27 UTC
true, because your patch contained a small bug. But, that's your problem.