Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 158937 - java-pkg_dosrc() in java-utils-2.eclass cannot handle source jar files
Summary: java-pkg_dosrc() in java-utils-2.eclass cannot handle source jar files
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Java team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-23 11:08 UTC by Matthew Schultz
Modified: 2011-01-19 03:13 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
java-utils-2.patch (java-utils-2.patch,845 bytes, text/plain)
2006-12-23 11:10 UTC, Matthew Schultz
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Schultz 2006-12-23 11:08:22 UTC
Calling java-pkg_dosrc() in java-utils-2.eclass causes the ebuild to die because it only looks for .java files.  It should also accept .jar files because IDEs can read from .jar files for code completion as well.
Comment 1 Matthew Schultz 2006-12-23 11:10:05 UTC
Created attachment 104648 [details]
java-utils-2.patch

This patch should fix the problem.
Comment 2 Vlastimil Babka (Caster) (RETIRED) gentoo-dev 2006-12-23 11:23:39 UTC
How's that a major severity?

We prefer unpacking the jars and making the zip contain only the unpacked .java files for consistency. What's the advantage of packing jar files?
Comment 3 Matthew Schultz 2006-12-23 12:13:38 UTC
I'm all about consistency but with a package that has packed up all of its .java source files in multiple jar files in multiple directories, I think it's a real pain to have to unpack all that just to keep consistency.  As I understand, all or most of the java IDEs like Eclipse, Netbeans, Intellij, etc can handle .jar files for their code completion. So why not include jar files in the zip file?
Comment 4 Petteri Räty (RETIRED) gentoo-dev 2006-12-23 12:52:13 UTC
(In reply to comment #3)
> I'm all about consistency but with a package that has packed up all of its
> .java source files in multiple jar files in multiple directories, I think it's
> a real pain to have to unpack all that just to keep consistency.  As I
> understand, all or most of the java IDEs like Eclipse, Netbeans, Intellij, etc
> can handle .jar files for their code completion. So why not include jar files
> in the zip file?
> 

jar files a subset of zip files so of course the IDEs can handle jar files. The question here is that can it handle jar files inside .zip files. 
Comment 5 Matthew Schultz 2006-12-23 13:59:19 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > I'm all about consistency but with a package that has packed up all of its
> > .java source files in multiple jar files in multiple directories, I think it's
> > a real pain to have to unpack all that just to keep consistency.  As I
> > understand, all or most of the java IDEs like Eclipse, Netbeans, Intellij, etc
> > can handle .jar files for their code completion. So why not include jar files
> > in the zip file?
> > 
> 
> jar files a subset of zip files so of course the IDEs can handle jar files. The
> question here is that can it handle jar files inside .zip files. 
> 

I was wondering that myself.  I just found out that when you want Intellij to do code completion, you have to point it to each separate jar file which it can then read.  Now that sounds like a real pain in the ass.  Maybe it's better to just leave it in it's source directory as it is since they're all just zip files anyway?
Comment 6 Matthew Schultz 2006-12-23 14:48:21 UTC
So I guess one of two things could be done.  

1. Leave the files like they are if they're jars and don't call this function.

or 

2. Modify the function so it recurses through multiple directories, extracts the jars and puts them all in the same directory structure and zip that up. Then the person using the IDE only has to point to one file instead of having to go through separate directories for each one.
Comment 7 Vlastimil Babka (Caster) (RETIRED) gentoo-dev 2006-12-24 07:02:10 UTC
How many packages are affected by this? Are some in portage tree? Which?
Also, we build stuff from source which means we already have the source unpacked in order to compile it :) So how could that happen to have source only in .jar files?
Comment 8 Miroslav Šulc gentoo-dev 2011-01-19 03:13:55 UTC
looks like this is not important anymore. if i am wrong, reopen.