Bug 158529 – [STABLE] app-laptop/omnibook requires a patch to compile against 2.6.19

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Jaco Kroon 2006-12-19 04:05:57 UTC]

omnibook won't compile against kernel version 2.6.19 and up due to the fact that linux/config.h no longer exists.  From what I can determine one should now include linux/autoconf.h

[Comment 1 Jaco Kroon 2006-12-19 04:10:13 UTC]

Created attachment 104351 [details]
omnibook-2.6.19.patch

Additionally one needs to add the following unpack section.  This should be ok on older kernels as well, from 2.6.17 at least linux/conf.h has simply included linux/autoconf.h anyway.

src_unpack() {
        unpack ${A}
        epatch "${FILESDIR}/omnibook-2.6.19.patch"
}

[Comment 2 Daniel Drake (RETIRED) 2006-12-19 16:03:54 UTC]

Please rework the patch to do something like:

#include <linux/version.h>
#if LINUX_VERSION_CODE <= KERNEL_VERSION(2,6,18)
#include <linux/config.h>
#endif

Michele, please fix in stable tree ASAP

[Comment 3 Michele Noberasco (RETIRED) 2006-12-20 01:34:44 UTC]

Fixed (as new package revision). Since I don't have a 2.6.19 to test it on, yet, could someone test it for me? Otherwise I should be able to do it myself in a couple of days...

[Comment 4 Jaco Kroon 2006-12-20 02:32:57 UTC]

Yes, that suggested fix would indeed be better, the autoconf is included using -i on newer versions.

I don't see the updated ebuild in portage yet, so I'll try again later.

[Comment 5 Jaco Kroon 2006-12-20 05:10:28 UTC]

Works correctly, other than the sandbox errors I'm getting, but those occur with ati-drivers as well so I doubt it's related.

I'm leaving this open, please close when it gets bumped to stable.

[Comment 6 Markus Meier 2006-12-20 14:13:45 UTC]

app-laptop/omnibook-20060817-r1
1. emerges on x86 (with 2.6.19 source)
2. passes collision test
no hardware to test

Portage 2.1.1-r2 (default-linux/x86/2006.1/desktop, gcc-4.1.1, glibc-2.4-r4, 2.6.18.4 i686)
=================================================================
System uname: 2.6.18.4 i686 Genuine Intel(R) CPU           T2300  @ 1.66GHz
Gentoo Base System version 1.12.6
Last Sync: Wed, 20 Dec 2006 18:30:01 +0000
ccache version 2.3 [disabled]
app-admin/eselect-compiler: [Not Present]
dev-java/java-config: 1.3.7, 2.0.30
dev-lang/python:     2.3.5-r3, 2.4.3-r4
dev-python/pycrypto: 2.0.1-r5
dev-util/ccache:     2.3
dev-util/confcache:  [Not Present]
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.60
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2
sys-devel/binutils:  2.16.1-r3
sys-devel/gcc-config: 1.3.14
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.17-r2
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=prescott -pipe -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/X11/xkb /usr/share/config /var/qmail/alias /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf /etc/java-config/vms/ /etc/revdep-rebuild /etc/terminfo /etc/texmf/web2c"
CXXFLAGS="-O2 -march=prescott -pipe -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--nospinner"
FEATURES="autoconfig collision-protect distlocks metadata-transfer parallel-fetch sandbox sfperms strict test userfetch userpriv usersandbox"
GENTOO_MIRRORS="http://mirror.switch.ch/mirror/gentoo/ http://gentoo.inode.at/"
LINGUAS="en de en_GB de_CH"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude='/distfiles' --exclude='/local' --exclude='/packages'"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="x86 X a52 aac acpi alsa apache2 asf berkdb bitmap-fonts cairo cdr cdrom cli cracklib crypt cups dbus divx dlloader dri dts dvd dvdr dvdread eds elibc_glibc emboss encode fam ffmpeg firefox flac fortran gdbm gif gnome gpm gstreamer gtk hal iconv input_devices_keyboard input_devices_mouse ipv6 isdnlog java jpeg kde kdeenablefinal kernel_linux ldap libg++ linguas_de linguas_de_CH linguas_en linguas_en_GB mad mikmod mmx mono mp3 mpeg ncurses nls nptl nptlonly ogg opengl oss pam pcre perl png ppds pppd python qt3 qt4 quicktime readline reflection rtsp ruby samba sdl session smp spell spl sse sse2 sse3 ssl svg tcpd test tetex theora threads truetype truetype-fonts type1-fonts udev unicode userland_GNU vcd video_cards_fbdev video_cards_i810 video_cards_vesa vorbis win32codecs wxwindows x264 xine xml xorg xprint xv xvid zlib"
Unset:  CTARGET, INSTALL_MASK, LANG, LC_ALL, LDFLAGS, PORTAGE_RSYNC_EXTRA_OPTS, PORTDIR_OVERLAY

[Comment 7 Michele Noberasco (RETIRED) 2006-12-24 00:15:01 UTC]

Module works fine om my freshly compiled 2.6.19... x86 stable.