attached there is a more efficient ebuild for the PECL runkit that do more checks about apache/php use flags requirements, gcc issues and fixes for PHP5.2. @attention: the ebuild is for the Gentoo PHP Overlay, not for the official portage tree.
Created attachment 103552 [details] dev-php5/pecl-runkit-0.9-r2.ebuild
Created attachment 103554 [details, diff] files/zend-api-5.2.patch
I added the check for USE=threads for PHP. The rest seems to be fixed already by pecl-runkit-0.9-buildfixes.patch so no need to do anything there.
i'm not sure if the patch that come from Gentoo PHP Overlay (pecl-runkit-0.9-buildfixes.patch) is a good solution. i have just discuss this compilation error upstream, suppling a right fix: http://pecl.php.net/bugs/bug.php?id=8849 Gentoo PHP Overlay patch replace Z_BVAL_P (old boolean type macro) with a Z_LVAL_P (long type macro), the mine instead substitue the old boolean type macro with the new version (ZVAL_BOOL). probably the patch from PHP Overlay fix the compilation issue, but make the resulting code totaly broken because it create a variable as a LONG type instead of a BOOL type (the source code require a BOOL type). It's better if the PHP Overlay apply mine patch, just to be sure to not inject indirect bugs.
(In reply to comment #4) > the compilation issue, but make the resulting code totaly broken because it > create a variable as a LONG type instead of a BOOL type (the source code > require a BOOL type). It's better if the PHP Overlay apply mine patch, just to > be sure to not inject indirect bugs. That patch doesn't apply w/ 0.9; provide a proper one please.
Created attachment 125280 [details] compile output (In reply to comment #5) > That patch doesn't apply w/ 0.9; provide a proper one please. it does, see the attached log (just done a few seconds ago). as AT i have tested it on x86 and amd64 before to supply it upstream.
(In reply to comment #6) > it does, see the attached log (just done a few seconds ago). > as AT i have tested it on x86 and amd64 before to supply it upstream. Well no, sorry, it doesn't... ===================== patching file runkit_sandbox.c Hunk #1 FAILED at 1467. 1 out of 1 hunk FAILED -- saving rejects to file runkit_sandbox.c.rej ======================
Created attachment 125282 [details, diff] pecl-runkit-0.9.gcc4.patch @jakub: try this one. (probably the php bugzilla have wrongly cutted some blank spaces/lines when i have submitted the patch)
(In reply to comment #8) > @jakub: try this one. > (probably the php bugzilla have wrongly cutted some blank spaces/lines when i > have submitted the patch) Thanks, this works. Added to dev-php4/pecl-runkit as well.
