Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 156783 - stabilize - net-dialup/slmodem-2.9.11_pre20051101-r2 failed with kernel-2.6.19
Summary: stabilize - net-dialup/slmodem-2.9.11_pre20051101-r2 failed with kernel-2.6.19
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Dialup Developers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: kernel-2.6.19
  Show dependency tree
 
Reported: 2006-12-01 03:48 UTC by Gianluca Parmiggiani
Modified: 2006-12-20 11:54 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
compile fix for kernel 2.6.19 (slmodem-2.9.11-kernel-2.6.19.patch,854 bytes, patch)
2006-12-01 04:49 UTC, Gianluca Parmiggiani
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gianluca Parmiggiani 2006-12-01 03:48:12 UTC
CC [M]  /var/tmp/portage/net-dialup/slmodem-2.9.11_pre20051101-r2/work/ungrab-winmodem/ungrab-winmodem.o
/var/tmp/portage/net-dialup/slmodem-2.9.11_pre20051101-r2/work/ungrab-winmodem/ungrab-winmodem.c:14:26: error: linux/config.h: No such file or directory
/var/tmp/portage/net-dialup/slmodem-2.9.11_pre20051101-r2/work/ungrab-winmodem/ungrab-winmodem.c: In function 'softmodem_release_init':
/var/tmp/portage/net-dialup/slmodem-2.9.11_pre20051101-r2/work/ungrab-winmodem/ungrab-winmodem.c:60: warning: passing argument 1 of 'pci_match_device' from incompatible pointer type
make[2]: *** [/var/tmp/portage/net-dialup/slmodem-2.9.11_pre20051101-r2/work/ungrab-winmodem/ungrab-winmodem.o] Error 1
make[1]: *** [_module_/var/tmp/portage/net-dialup/slmodem-2.9.11_pre20051101-r2/work/ungrab-winmodem] Error 2
make[1]: Leaving directory `/usr/src/linux-2.6.19-gentoo'
make: *** [all] Error 2
Comment 1 Gianluca Parmiggiani 2006-12-01 04:49:26 UTC
Created attachment 103119 [details, diff]
compile fix for kernel 2.6.19

fixes compile with kernel 2.6.19
Comment 2 Alin Năstac (RETIRED) gentoo-dev 2006-12-01 08:44:58 UTC
Question is, does it work? If it does, what module do you use?
Comment 3 Gianluca Parmiggiani 2006-12-01 18:14:17 UTC
unfortunately i don't have the chance to test it :(
anyway other packages fixed that way (ati-drivers and fbsplash in the kernel) are working fine.
Comment 4 Alin Năstac (RETIRED) gentoo-dev 2006-12-02 00:26:18 UTC
Fixed in slmodem-2.9.11_pre20061021.

I've replaced config.h with autoconf.h - the source files depend on a few CONFIGs.
It should be compilable with any 2.[4-6].* kernel.
Comment 5 Alin Năstac (RETIRED) gentoo-dev 2006-12-06 08:04:51 UTC
reopen the bug. 
At dsd's request, it will be closed when the version fixing this will be stabilized.
Comment 6 Stefan Schweizer (RETIRED) gentoo-dev 2006-12-07 11:58:02 UTC
x86: please stabilize the new version
Comment 7 Markus Meier gentoo-dev 2006-12-07 12:42:02 UTC
net-dialup/slmodem-2.9.11_pre20061021-r1  USE="alsa -usb"
1. emerges on x86
2. passes collision test

Portage 2.1.1-r2 (default-linux/x86/2006.1/desktop, gcc-4.1.1, glibc-2.4-r4, 2.6.18.4 i686)
=================================================================
System uname: 2.6.18.4 i686 Genuine Intel(R) CPU           T2300  @ 1.66GHz
Gentoo Base System version 1.12.6
Last Sync: Thu, 07 Dec 2006 17:30:01 +0000
ccache version 2.3 [disabled]
app-admin/eselect-compiler: [Not Present]
dev-java/java-config: 1.3.7, 2.0.30
dev-lang/python:     2.3.5-r3, 2.4.3-r4
dev-python/pycrypto: 2.0.1-r5
dev-util/ccache:     2.3
dev-util/confcache:  [Not Present]
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.60
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2
sys-devel/binutils:  2.16.1-r3
sys-devel/gcc-config: 1.3.13-r4
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.17-r2
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=prescott -pipe -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/X11/xkb /usr/share/config /var/qmail/alias /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf /etc/java-config/vms/ /etc/revdep-rebuild /etc/terminfo /etc/texmf/web2c"
CXXFLAGS="-O2 -march=prescott -pipe -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--nospinner"
FEATURES="autoconfig collision-protect distlocks metadata-transfer parallel-fetch sandbox sfperms strict test userfetch userpriv usersandbox"
GENTOO_MIRRORS="http://mirror.switch.ch/mirror/gentoo/ http://gentoo.inode.at/"
LINGUAS="en de en_GB de_CH"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude='/distfiles' --exclude='/local' --exclude='/packages'"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="x86 X a52 aac acpi alsa apache2 asf berkdb bitmap-fonts cairo cdr cdrom cli cracklib crypt cups dbus divx dlloader dri dts dvd dvdr dvdread eds elibc_glibc emboss encode fam ffmpeg firefox flac fortran gdbm gif gnome gpm gstreamer gtk hal iconv input_devices_keyboard input_devices_mouse ipv6 isdnlog java jpeg kde kdeenablefinal kernel_linux ldap libg++ linguas_de linguas_de_CH linguas_en linguas_en_GB mad mikmod mmx mono mp3 mpeg ncurses nls nptl nptlonly ogg opengl oss pam pcre perl png ppds pppd python qt3 qt4 quicktime readline reflection rtsp ruby samba sdl session smp spell spl sse sse2 sse3 ssl svg tcpd test tetex theora threads truetype truetype-fonts type1-fonts udev unicode userland_GNU vcd video_cards_fbdev video_cards_i810 video_cards_vesa vorbis win32codecs wxwindows x264 xine xml xorg xprint xv xvid zlib"
Unset:  CTARGET, INSTALL_MASK, LANG, LC_ALL, LDFLAGS, PORTAGE_RSYNC_EXTRA_OPTS, PORTDIR_OVERLAY
Comment 8 Christian Faulhammer (RETIRED) gentoo-dev 2006-12-08 03:42:57 UTC
x86 done
Comment 9 Daniel Drake (RETIRED) gentoo-dev 2006-12-19 15:28:15 UTC
Just a small note: the patch is partially redundant, you do not need to include autoconf.h on new kernels, it is included on the command line
Comment 10 Alin Năstac (RETIRED) gentoo-dev 2006-12-20 00:00:36 UTC
(In reply to comment #9)
> Just a small note: the patch is partially redundant, you do not need to include
> autoconf.h on new kernels, it is included on the command line

Is this proposition true for all kernel versions >=2.4 ?
If not, I find replacing config.h with autoconf.h THE solution for this kind of problem.
Comment 11 Daniel Drake (RETIRED) gentoo-dev 2006-12-20 05:22:41 UTC
Not all, but every kernel post-2.6.14 or so. This is what I am recommending for these situations:

#include <linux/version.h>
#if LINUX_VERSION_CODE <= KERNEL_VERSION(2,6,18)
#include <linux/config.h>
#endif

This will work on all current kernel versions and is also future-proof (there is discussion of changing the autoconf stuff again, this should not matter because nobody should be explicitly relying on that file now, instead they are relying on the config being available automatically).
Comment 12 Alin Năstac (RETIRED) gentoo-dev 2006-12-20 11:54:14 UTC
Point taken.
I've updated net-dialup/{slmodem,ltmodem,misdn,bewan-adsl} patches to your solution.