Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 156702 - Please remove GNOME 1 support and unmask x11-themes/mandrake-artwork
Summary: Please remove GNOME 1 support and unmask x11-themes/mandrake-artwork
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: gnome1-removal
  Show dependency tree
 
Reported: 2006-11-30 10:13 UTC by David Leverton
Modified: 2006-12-20 21:21 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
1.0.2-no-gtk1.diff (1.0.2-no-gtk1.diff,968 bytes, patch)
2006-11-30 10:14 UTC, David Leverton
Details | Diff
ebuild patch (mandrake-artwork.diff,1.74 KB, patch)
2006-11-30 10:14 UTC, David Leverton
Details | Diff
mandriva-artwork-1.0.4.ebuild (mandriva-artwork-1.0.4.ebuild,1.20 KB, text/plain)
2006-12-09 05:02 UTC, Pacho Ramos
Details
mandrake-artwork-1.0.4.ebuild (updated) (mandrake-artwork-1.0.4.ebuild,1.05 KB, text/plain)
2006-12-09 08:07 UTC, David Leverton
Details
remove-kde.patch (remove-kde.patch,848 bytes, patch)
2006-12-09 08:07 UTC, David Leverton
Details | Diff
remove-gtk1.patch (1.0.2-no-gtk1.diff,968 bytes, patch)
2006-12-09 08:08 UTC, David Leverton
Details | Diff
mandrake-artwork-1.0.4.ebuild (mandrake-artwork-1.0.4.ebuild,990 bytes, text/plain)
2006-12-10 05:20 UTC, Pacho Ramos
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Leverton 2006-11-30 10:13:20 UTC
x11-themes/mandrake-artwork is currently masked because it depends on media-libs/gdk-pixbuf, however this is only necessary to build the GTK-1 theme.  The package also supports GTK-2 and KDE.  Patch for removing GTK-1 support coming up.

(Note that IIRC some devs have expressed interest in keeping gdk-pixbuf, in which case this change wouldn't be necessary, but there doesn't seem to have been any activity there as it's still masked.)
Comment 1 David Leverton 2006-11-30 10:14:19 UTC
Created attachment 103052 [details, diff]
1.0.2-no-gtk1.diff
Comment 2 David Leverton 2006-11-30 10:14:45 UTC
Created attachment 103053 [details, diff]
ebuild patch
Comment 3 David Leverton 2006-12-01 05:24:11 UTC
Oops, forgot to mark this blocking.
Comment 4 Pacho Ramos gentoo-dev 2006-12-08 13:52:14 UTC
Why 
+		sed -i \
+			-e s/KDE_CHECK_FINAL// \
+			-e s/AC_PATH_KDE// \
+			configure.in || die
+		sed -i \
+			-e s/thememdk// \
+			-e s/thememdk// \
+			Makefile.am || die

only works if automake 1.4 is forced to be used?

When automake 1.4 is used, compilation fails with kde USE enabled with the following errors:

1. In configure I get some warnings:
config.status: WARNING:  Makefile.in seems to ignore the --datarootdir setting
config.status: creating gtk-2.0/Makefile
config.status: WARNING:  gtk-2.0/Makefile.in seems to ignore the --datarootdir setting
config.status: creating theme/Makefile
config.status: WARNING:  theme/Makefile.in seems to ignore the --datarootdir setting
config.status: creating theme/Galaxy2/Makefile
config.status: WARNING:  theme/Galaxy2/Makefile.in seems to ignore the --datarootdir setting
config.status: creating theme/GalaxySquared/Makefile
config.status: WARNING:  theme/GalaxySquared/Makefile.in seems to ignore the --datarootdir setting
config.status: creating metacity/Makefile
config.status: WARNING:  metacity/Makefile.in seems to ignore the --datarootdir setting
config.status: creating metacity/Galaxy2/Makefile
config.status: WARNING:  metacity/Galaxy2/Makefile.in seems to ignore the --datarootdir setting

Compilation fails with the following:
 i686-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I. -I../../.. -I/usr/kde/3.5/include -I/usr/qt/3/include -I. -DQT_THREAD_SUPPORT -D_REENTRANT -O2 -pipe -fomit-frame-pointer -march=pentium-m -mfpmath=sse -msse3 -Wp,-MD,.deps/mandrakeconfig.pp -c mandrakeconfig.cpp  -fPIC -DPIC -o .libs/mandrakeconfig.o
/bin/sh ../../../libtool --mode=link i686-pc-linux-gnu-g++  -O2 -pipe -fomit-frame-pointer -march=pentium-m -mfpmath=sse -msse3  -o kwin_mandrake_config.la -rpath /usr/lib/kde3 -L/usr/kde/3.5/lib -L/usr/qt/3/lib -L/usr/lib    -avoid-version -module -no-undefined @KDE_NO_UNDEFINED@ -R /usr/lib -R /usr/kde/3.5/lib -R /usr/qt/3/lib -R /usr/lib  -module config.lo mandrakeconfig.lo -lkdeui
i686-pc-linux-gnu-g++ -shared -nostdlib /usr/lib/gcc/i686-pc-linux-gnu/4.1.1/../../../crti.o /usr/lib/gcc/i686-pc-linux-gnu/4.1.1/crtbeginS.o  .libs/config.o .libs/mandrakeconfig.o  -Wl,--rpath -Wl,/usr/lib -Wl,--rpath -Wl,/usr/kde/3.5/lib -Wl,--rpath -Wl,/usr/qt/3/lib -L/usr/kde/3.5/lib -L/usr/qt/3/lib -L/usr/lib /usr/kde/3.5/lib/libkdeui.so -L/usr/X11R6/lib -L/usr/lib/gcc/i686-pc-linux-gnu/4.1.1 -L/usr/lib/gcc/i686-pc-linux-gnu/4.1.1/../../../../i686-pc-linux-gnu/lib -L/usr/lib/gcc/i686-pc-linux-gnu/4.1.1/../../.. -lstdc++ -lm -lc -lgcc_s /usr/lib/gcc/i686-pc-linux-gnu/4.1.1/crtendS.o /usr/lib/gcc/i686-pc-linux-gnu/4.1.1/../../../crtn.o  -march=pentium-m -mfpmath=sse -msse3 @KDE_NO_UNDEFINED@ -Wl,-soname -Wl,kwin_mandrake_config.so -o .libs/kwin_mandrake_config.so
i686-pc-linux-gnu-g++: @KDE_NO_UNDEFINED@: No such file or directory
make[4]: *** [kwin_mandrake_config.la] Error 1
make[4]: se sale del directorio `/var/tmp/portage/mandrake-artwork-1.0.2/work/galaxy-1.0.2/thememdk/generic/config'
make[3]: *** [all-recursive] Error 1
make[3]: se sale del directorio `/var/tmp/portage/mandrake-artwork-1.0.2/work/galaxy-1.0.2/thememdk/generic'
make[2]: *** [all-recursive] Error 1
make[2]: se sale del directorio `/var/tmp/portage/mandrake-artwork-1.0.2/work/galaxy-1.0.2/thememdk'
make[1]: *** [all-recursive] Error 1
make[1]: se sale del directorio `/var/tmp/portage/mandrake-artwork-1.0.2/work/galaxy-1.0.2'
make: *** [all-recursive-am] Error 2

If I use autoconf-1.9, mandrake-artwork compiles fine with USE kde enabled, but autoconf fails when kde USE is disabled (after running the sed "fix") :-(

Thanks :-)
Comment 5 David Leverton 2006-12-08 19:58:44 UTC
(In reply to comment #4)
> When automake 1.4 is used, compilation fails with kde USE enabled with the
> following errors:
> 
> 1. In configure I get some warnings:
> config.status: WARNING:  Makefile.in seems to ignore the --datarootdir setting
> config.status: creating gtk-2.0/Makefile
> config.status: WARNING:  gtk-2.0/Makefile.in seems to ignore the --datarootdir
> setting
> config.status: creating theme/Makefile
> config.status: WARNING:  theme/Makefile.in seems to ignore the --datarootdir
> setting
> config.status: creating theme/Galaxy2/Makefile
> config.status: WARNING:  theme/Galaxy2/Makefile.in seems to ignore the
> --datarootdir setting
> config.status: creating theme/GalaxySquared/Makefile
> config.status: WARNING:  theme/GalaxySquared/Makefile.in seems to ignore the
> --datarootdir setting
> config.status: creating metacity/Makefile
> config.status: WARNING:  metacity/Makefile.in seems to ignore the --datarootdir
> setting
> config.status: creating metacity/Galaxy2/Makefile
> config.status: WARNING:  metacity/Galaxy2/Makefile.in seems to ignore the
> --datarootdir setting

That looks like you're mixing a new autoconf with an old automake.  The ebuild patch should be forcing autoconf 2.13, does that not work for you?  It works for me, both with and without the kde flag.
Comment 6 Pacho Ramos gentoo-dev 2006-12-09 05:02:05 UTC
I am trying with a new ebuild and an updated galaxy themes (from mandriva 2007 src.rpm), I attatch the ebuild (I have renamed your great patch for removing gtk1 support :-))
Comment 7 Pacho Ramos gentoo-dev 2006-12-09 05:02:44 UTC
Created attachment 103686 [details]
mandriva-artwork-1.0.4.ebuild
Comment 8 David Leverton 2006-12-09 08:07:27 UTC
Created attachment 103693 [details]
mandrake-artwork-1.0.4.ebuild (updated)

That's great, thanks!  I made a few changes to the ebuild:

1) Use new shiny versions of autoconf and automake.
2) Removed GTK1 from DESCRIPTION. ;-)
3) Moved the no-kde part remove a few more things from configure.in (otherwise it doesn't build with the new autotools, probably the same problem you had in comment 4) and moved it out into a patch.
4) Use eautoreconf instead of eautoconf/eautomake (seems the problem I mentioned in the comment has been fixed).

This one builds for me both with and without KDE support.

Also, you forgot to mention where to download the RPM. :-P  So others don't have to go searching, it's available from http://sunsite.mff.cuni.cz/MIRRORS/ftp.sunet.se/pub/Linux/distributions/mandrake/devel/2007.0/SRPMS/main/release/galaxy-1.0.4-3mdv2007.0.src.rpm
Comment 9 David Leverton 2006-12-09 08:07:58 UTC
Created attachment 103694 [details, diff]
remove-kde.patch
Comment 10 David Leverton 2006-12-09 08:08:53 UTC
Created attachment 103695 [details, diff]
remove-gtk1.patch

Same as the old patch, but with the new name, to remove any possible confusion.
Comment 11 Pacho Ramos gentoo-dev 2006-12-10 04:38:32 UTC
Thanks

Please, rename bug summary, this package should be renamed to "mandriva-artwork" or "mandriva-galaxy" (because now, there is another mandriva theme called "Ia-Ora" (beautiful ;-)) instead of "madrake-artwork".
Comment 12 David Leverton 2006-12-10 04:49:03 UTC
(In reply to comment #11)
> Thanks
> 
> Please, rename bug summary, this package should be renamed to
> "mandriva-artwork" or "mandriva-galaxy" (because now, there is another mandriva
> theme called "Ia-Ora" (beautiful ;-)) instead of "madrake-artwork".

I'll leave that to the devs, could be confusing if I change it here but the tree still has the old name.
Comment 13 Pacho Ramos gentoo-dev 2006-12-10 05:02:00 UTC
OK, I understand it :-)
Comment 14 Pacho Ramos gentoo-dev 2006-12-10 05:20:34 UTC
Created attachment 103740 [details]
mandrake-artwork-1.0.4.ebuild

More cleanups.

Now, is not needed force automake and autoconf versions, also, econf can be run without options because we already are using set-qtdir and set-kdedir.

Thanks :-)
Comment 15 Pacho Ramos gentoo-dev 2006-12-14 03:51:11 UTC
What about this? The bug is fixed, please, bump to the new version and unmask it.

Thanks a lot
Comment 16 Jakub Moc (RETIRED) gentoo-dev 2006-12-20 21:21:04 UTC
Removed from the tree wrt Bug 154102.