Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 150855 - sys-apps/net-tools-1.60-r12 compile error against linux-headers-2.6.18
Summary: sys-apps/net-tools-1.60-r12 compile error against linux-headers-2.6.18
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
URL: http://sourceware.org/ml/libc-alpha/2...
Whiteboard:
Keywords:
: 156983 157564 157994 182460 (view as bug list)
Depends on:
Blocks: sane-linux-headers
  Show dependency tree
 
Reported: 2006-10-10 23:33 UTC by Mario Fetka (geos_one)
Modified: 2007-06-18 19:40 UTC (History)
9 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
net-tools fddi-fix patch (net-tools-2.4.28-fddi-fix.patch,421 bytes, patch)
2006-10-10 23:35 UTC, Mario Fetka (geos_one)
Details | Diff
local unaligned.h (unaligned.h,591 bytes, text/plain)
2006-12-06 06:47 UTC, Shunichi Fuji
Details
ebuild using unaligned.h and fddi_fix.patch (net-tools-1.60-r12.ebuild,2.36 KB, text/plain)
2006-12-06 06:49 UTC, Shunichi Fuji
Details
Replace the include of linux/netdevices.h in linux/if_fddi.h (linux-headers-2.6.19-if_fddi_include_netdevice.patch,360 bytes, patch)
2006-12-16 03:39 UTC, Kevin F. Quinn (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mario Fetka (geos_one) 2006-10-10 23:33:22 UTC
sys-apps/net-tools-1.60-r12 cant compile against linux-headers-2.6.18
Comment 1 Mario Fetka (geos_one) 2006-10-10 23:35:12 UTC
Created attachment 99344 [details, diff]
net-tools fddi-fix patch

this patch corrects the in_fddi error
Comment 2 John M. Drescher 2006-10-31 14:20:59 UTC
The patch fixed the fddi error however I still get other errors on amd64:

patching file pub/diag/Makefile
patching file pub/diag/Makefile
Hunk #1 succeeded at 15 with fuzz 1.
patching file pub/diag/ether-wake.c
touch .patch
make -C pub/diag most
make[1]: Entering directory `/var/tmp/portage/sys-apps/net-tools-1.60-r12/work/net-tools-1.60/ethercard-diag/pub/diag'
x86_64-pc-linux-gnu-gcc -O -Wall -Wstrict-prototypes -DLIBFLASH -DLIBMII   -c -o libflash.o libflash.c
x86_64-pc-linux-gnu-gcc -O -Wall -Wstrict-prototypes -DLIBFLASH -DLIBMII   -c -o libmii.o libmii.c
x86_64-pc-linux-gnu-gcc -O -Wall -Wstrict-prototypes -DLIBFLASH -DLIBMII    pci-config.c   -o pci-config
x86_64-pc-linux-gnu-gcc -O -Wall -Wstrict-prototypes -DLIBFLASH -DLIBMII    ether-wake.c   -o ether-wake
x86_64-pc-linux-gnu-gcc -O -Wall -Wstrict-prototypes -DLIBFLASH -DLIBMII    ne2k-pci-diag.c libflash.o   -o ne2k-pci-diag
ether-wake.c: In function 'main':
ether-wake.c:184: warning: pointer targets in initialization differ in signedness
x86_64-pc-linux-gnu-gcc -O -Wall -Wstrict-prototypes -DLIBFLASH -DLIBMII    alta-diag.c libflash.o libmii.o   -o alta-diag
x86_64-pc-linux-gnu-gcc -O -Wall -Wstrict-prototypes -DLIBFLASH -DLIBMII    eepro100-diag.c libflash.o libmii.o   -o eepro100-diag
alta-diag.c:89:27: error: asm/unaligned.h: No such file or directory
make[1]: *** [alta-diag] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/var/tmp/portage/sys-apps/net-tools-1.60-r12/work/net-tools-1.60/ethercard-diag/pub/diag'
make: *** [most] Error 2
make: Leaving directory `/var/tmp/portage/sys-apps/net-tools-1.60-r12/work/net-tools-1.60/ethercard-diag'

!!! ERROR: sys-apps/net-tools-1.60-r12 failed.
Call stack:
  ebuild.sh, line 1568:   Called dyn_compile
  ebuild.sh, line 937:   Called src_compile
  net-tools-1.60-r12.ebuild, line 56:   Called die

!!! emake ethercard-diag failed
!!! If you need support, post the topmost build error, and the call stack if relevant.

!!! This ebuild is from an overlay: '/usr/local/portage'
Comment 3 James 2006-11-30 10:19:40 UTC
This patch - net-tools_fddi-fix patch also helps my compile under gcc-3.4.6 with kernel 2.4.32-om-migshm.  THX! PLS put in portage!
Comment 4 SpanKY gentoo-dev 2006-12-02 15:15:51 UTC
fixed with 2.6.19 headers
Comment 5 John M. Drescher 2006-12-02 21:15:29 UTC
Alright, I am confused. I just installed linux-headers-2.6.19 and removed the overlay and I am back to the exact same fddi error. After applying the patch I am back to where I was before. I guess its time to go back to the stable kernel headers.

Ok, I just did that emerged linux-headers-2.6.17-r2 and then emerging net-tools-1.60-r12 now works.
Comment 6 SpanKY gentoo-dev 2006-12-03 11:19:57 UTC
*** Bug 156983 has been marked as a duplicate of this bug. ***
Comment 7 Shunichi Fuji 2006-12-06 06:46:43 UTC
for example problem occured on reiserfsprogs by exclude unaligned.h from 2.6.18.

https://launchpad.net/distros/ubuntu/+source/reiserfsprogs/+bug/65842
http://cvs.fedora.redhat.com/viewcvs/rpms/reiserfs-utils/devel/header-fix.patch?view=markup

resolved defining put_unaligned and get_unaligned by local header.(using fedora's better way)
Comment 8 Shunichi Fuji 2006-12-06 06:47:42 UTC
Created attachment 103447 [details]
local unaligned.h
Comment 9 Shunichi Fuji 2006-12-06 06:49:17 UTC
Created attachment 103448 [details]
ebuild using unaligned.h and fddi_fix.patch
Comment 10 Jakub Moc (RETIRED) gentoo-dev 2006-12-09 01:39:34 UTC
*** Bug 157564 has been marked as a duplicate of this bug. ***
Comment 11 Jakub Moc (RETIRED) gentoo-dev 2006-12-13 01:30:48 UTC
*** Bug 157994 has been marked as a duplicate of this bug. ***
Comment 12 Jakub Moc (RETIRED) gentoo-dev 2006-12-13 01:31:08 UTC
Not fixed, reopen.
Comment 13 Kevin F. Quinn (RETIRED) gentoo-dev 2006-12-16 03:37:50 UTC
Same against 2.6.19.

The problem is that __be16 is used in linux/if_fddi.h, however its definition is not included.  The definition previously came from including linux/netdevices.h at the top of linux/if_fddi.h.  Re-adding this include deals with the problem.

Obviously upstream removed the include of linux/netdevices.h for a reason - so it would be useful to find out why.
Comment 14 Kevin F. Quinn (RETIRED) gentoo-dev 2006-12-16 03:39:26 UTC
Created attachment 104122 [details, diff]
Replace the include of linux/netdevices.h in linux/if_fddi.h

Patch for linux-headers-2.6.19 (and 2.6.18 I guess).  Obviously when I mentioned upstream previously I was talking about the kernel, not nettools.
Comment 15 Kevin F. Quinn (RETIRED) gentoo-dev 2006-12-16 03:47:47 UTC
Found this: 
http://lists.netfilter.org/pipermail/netfilter-devel/2005-October/021648.html

which fixes the same problem just for netfilter, by including <linux/types.h> in the source file that includes <linux/if_fddi.h>

I don't know what the rules are for including linux headers; whether it's up to the includer to ensure all dependent headers are included, or whether it's the responsibility of the included file to pull in whatever it needs.
Comment 16 SpanKY gentoo-dev 2006-12-16 03:49:56 UTC
ive already fixed this
Comment 17 SpanKY gentoo-dev 2007-01-20 06:25:32 UTC
*** Bug 162885 has been marked as a duplicate of this bug. ***
Comment 18 Jakub Moc (RETIRED) gentoo-dev 2007-06-18 19:40:32 UTC
*** Bug 182460 has been marked as a duplicate of this bug. ***