150488 – confusing repoman error message for invalid configuration

Bug 150488 - confusing repoman error message for invalid configuration

Summary: confusing repoman error message for invalid configuration

Status:	RESOLVED FIXED

Alias:	None

Product:	Portage Development
Classification:	Unclassified
Component:	Repoman (show other bugs)
Hardware:	All Linux

Importance:	High minor (vote)
Assignee:	Portage team

URL:
Whiteboard:
Keywords:	InVCS

Depends on:
Blocks:	147007
	Show dependency tree

Reported:	2006-10-08 10:16 UTC by Marius Mauch (RETIRED)
Modified:	2006-10-10 14:41 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Marius Mauch (RETIRED) gentoo-dev

2006-10-08 10:16:22 UTC

Just tried to run repoman in a dir that's not PORTDIR nor in PORTDIR_OVERLAY by accident, repoman complained about it with

Unable to determine PORTDIR.

This is confusing at least as I even told it PORTDIR via the environment (the problem in my case was that the dir wasn't listed in PORTDIR_OVERLAY). I don't really understand the logic in the relevant code there (always disliked this automagic stuff), but the condition to show that message looks screwy by itself without comments

if not portdir_overlay:
	print darkred("Unable to determine PORTDIR.")

Comment 1 Zac Medico gentoo-dev

2006-10-09 20:41:38 UTC

Yeah, that message confuses lots of people. ;)

Here's what it says now in svn r4646:

Repoman is unable to determine PORTDIR or PORTDIR_OVERLAY from the current
working directory.

Comment 2 Zac Medico gentoo-dev

2006-10-10 14:41:44 UTC

This has been release in 2.1.2_pre2-r8.