Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 149191 - sci-libs/galib won't compile with gcc4
Summary: sci-libs/galib won't compile with gcc4
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GCC Porting (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Science Related Packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 117482
  Show dependency tree
 
Reported: 2006-09-26 09:20 UTC by Jeno I. Hajdu
Modified: 2006-09-26 16:52 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeno I. Hajdu 2006-09-26 09:20:23 UTC
GAlib won't compile with gcc4. One way to resolve the problem can be found on GAlib's mailing list: http://mailman.mit.edu/pipermail/galib/2006-June/001325.html .
Here's a patch:

--- gaconfig_old.h      2006-09-26 11:21:11.000000000 +0200
+++ gaconfig.h  2006-09-26 11:24:11.000000000 +0200
@@ -192,7 +192,9 @@

 // determine the compiler
 #if defined(__GNUG__) || defined(__GNUC__)
-#if __GNUC__ == 3
+#if __GNUC__ == 4
+#define GALIB_COMPILER "gcc4"
+#elif __GNUC__ == 3
 #define GALIB_COMPILER "gcc3"
 #elif __GNUC__ == 2
 #define GALIB_COMPILER "gcc2"
@@ -365,7 +367,7 @@
 #define GALIB_USE_PID
 #define GALIB_USE_EMPTY_TEMPLATES
 #define GALIB_NEED_INSTANTIATION_PREFIX
-#if __GNUC__ == 3
+#if __GNUC__ >= 3
 #define GALIB_USE_ANSI_HEADERS
 #define GALIB_USE_STD_NAMESPACE
 #define GALIB_USE_COMP_OPERATOR_TEMPLATES

There are still some unresolved warnings related to GAID.
Comment 1 Markus Dittrich (RETIRED) gentoo-dev 2006-09-26 15:13:56 UTC
Hi Jeno,

Thanks for your report. I'll have a look at it soon.

Best,
Markus
Comment 2 Markus Dittrich (RETIRED) gentoo-dev 2006-09-26 16:52:46 UTC
The patch works well and I just committed it to portage cvs.

Thanks again,
Markus