Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 143224 - dev-java/bsh optional servletapi dependency
Summary: dev-java/bsh optional servletapi dependency
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Java (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Java team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-08 10:44 UTC by unlord
Modified: 2015-07-11 14:31 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
bsh-2.0_beta4-r2.ebuild (bsh-2.0_beta4-r2.ebuild,1.59 KB, text/plain)
2006-08-08 10:46 UTC, unlord
Details
bsh-2.0_beta4-r2.diff (bsh-2.0_beta4-r2.diff,1.06 KB, text/plain)
2006-08-08 10:48 UTC, unlord
Details
files/bsh2-noservletapi.patch (bsh2-noservletapi.patch,398 bytes, text/plain)
2006-08-08 10:49 UTC, unlord
Details

Note You need to log in before you can comment on or make changes to this bug.
Description unlord 2006-08-08 10:44:12 UTC
Added USE flag for servletapi dependency and removed up unnecessary dependency on bsf.

This is possible because the build.xml correctly allows you to build this program excluding support for certain libraries.
Comment 1 unlord 2006-08-08 10:46:56 UTC
Created attachment 93776 [details]
bsh-2.0_beta4-r2.ebuild

Adding ebuild.
Comment 2 unlord 2006-08-08 10:48:27 UTC
Created attachment 93777 [details]
bsh-2.0_beta4-r2.diff
Comment 3 unlord 2006-08-08 10:49:01 UTC
Created attachment 93778 [details]
files/bsh2-noservletapi.patch
Comment 4 Josh Nichols (RETIRED) gentoo-dev 2006-08-08 10:59:41 UTC
You can probably pass a property to ant on the command line instead of patching, ie:

eant -Dexclude-servlet="something"

Not sure what the something needs to be though...

Comment 5 unlord 2006-08-08 12:18:20 UTC
If you look at files/bsh2-noservletapi.patch you can see what it needs to be:

eant -Dexclude-servlet="bsh/servlet/*" ...

I considered this, but wanted to prevent future ebuilds from simply bumping the version.  The patch will most likely fail if anything is changed in build.xml, forcing a new patch to be made.  This is desired so that if the particulars of -Dexclude-servlet="..." change, it cannot be overlooked.
Comment 6 Josh Nichols (RETIRED) gentoo-dev 2006-08-09 21:25:00 UTC
You should test things that depend on bsh with the abscense/precense of the servletapi. There may be cases where the dependencies are expecting bsh to be compiled with servletapi.
Comment 7 unlord 2006-08-10 01:49:19 UTC
That is an excellent point.  If there are packages that need bsh to have servletapi support, they'd need to check that this package was compiled with support for that in it, and halt the ebuild if not.

I'll look into doing that check sometime soon.
Comment 8 Dennis Schridde 2012-07-29 17:58:05 UTC
Obsolete?
Comment 9 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2014-03-08 17:30:40 UTC
Still relevant, makes the servletapi dependecy optional.
Comment 10 William L. Thomson Jr. 2015-04-10 20:39:25 UTC
The attachments are no longer valid, not based on current version in tree outdated EAPI and deps. All attachments needs to be marked as obsolete. Though the dependency could still be made as optional.
Comment 11 Patrice Clement gentoo-dev 2015-07-11 14:31:34 UTC
I wonder if we shouldn't remove bsh altogether. Last release dates back to 2005. See http://www.beanshell.org/ and https://qa-reports.gentoo.org/output/genrdeps/rindex/dev-java/bsh for a complete list of rdeps.