Added USE flag for servletapi dependency and removed up unnecessary dependency on bsf.
This is possible because the build.xml correctly allows you to build this program excluding support for certain libraries.
Created attachment 93776 [details]
Created attachment 93777 [details]
Created attachment 93778 [details]
You can probably pass a property to ant on the command line instead of patching, ie:
Not sure what the something needs to be though...
If you look at files/bsh2-noservletapi.patch you can see what it needs to be:
eant -Dexclude-servlet="bsh/servlet/*" ...
I considered this, but wanted to prevent future ebuilds from simply bumping the version. The patch will most likely fail if anything is changed in build.xml, forcing a new patch to be made. This is desired so that if the particulars of -Dexclude-servlet="..." change, it cannot be overlooked.
You should test things that depend on bsh with the abscense/precense of the servletapi. There may be cases where the dependencies are expecting bsh to be compiled with servletapi.
That is an excellent point. If there are packages that need bsh to have servletapi support, they'd need to check that this package was compiled with support for that in it, and halt the ebuild if not.
I'll look into doing that check sometime soon.
Still relevant, makes the servletapi dependecy optional.
The attachments are no longer valid, not based on current version in tree outdated EAPI and deps. All attachments needs to be marked as obsolete. Though the dependency could still be made as optional.
I wonder if we shouldn't remove bsh altogether. Last release dates back to 2005. See http://www.beanshell.org/ and https://qa-reports.gentoo.org/output/genrdeps/rindex/dev-java/bsh for a complete list of rdeps.