Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 142430 - games-rpg/bs2-demo-0.ebuild (new package)
Summary: games-rpg/bs2-demo-0.ebuild (new package)
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Default Assignee for New Packages
Whiteboard: sunrise-removal
Keywords: EBUILD, InOverlay
Depends on:
Reported: 2006-08-01 07:35 UTC by unlord
Modified: 2018-12-03 12:57 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

bs2-demo-0.ebuild (bs2-demo-0.ebuild,607 bytes, text/plain)
2006-08-01 07:35 UTC, unlord
bs2-demo-1.ebuild (bs2-demo-1.ebuild,656 bytes, text/plain)
2006-08-01 17:20 UTC, unlord
bs2-demo-1.ebuild (bs2-demo-1.ebuild,777 bytes, text/plain)
2006-08-02 01:25 UTC, Paul Bredbury

Note You need to log in before you can comment on or make changes to this bug.
Description unlord 2006-08-01 07:35:33 UTC
An ebuild for installing the interactive demo version of the Revolution Software game Broken Sword 2: The Smoking Mirror.
Comment 1 unlord 2006-08-01 07:35:59 UTC
Created attachment 93200 [details]

Adding ebuild.
Comment 2 Paul Bredbury 2006-08-01 10:24:01 UTC
Some hints:

HOMEPAGE line is missing.

Remove scummvm from DEPEND - it should only be in RDEPEND, because it's not needed for *installation*.

${GAMES_DATADIR}/${PN} is used twice, so better to define a local variable for it.

The convention for demos is for file/dir/ebuild name to end in "-demo".

If no other command-line options are appropriate, then add:
make_desktop_entry ${PN} "Broken Sword 2 (Demo)"

A version number of 1 makes more sense than 0, if no version number is apparent.
Comment 3 Paul Bredbury 2006-08-01 10:27:33 UTC
Also, doins should die on failure.
Comment 4 unlord 2006-08-01 17:02:02 UTC
Thanks for the feedback, I'll see about making the changes you suggested immediately.  I did have a few questions though:

> The convention for demos is for file/dir/ebuild name to end in "-demo".

What did you mean here?  Are you asking for me to change the game wrapper from 'bs2demo' to 'bs2-demo'?  Its an easy fix, just wondering.

> If no other command-line options are appropriate, then add:
> make_desktop_entry ${PN} "Broken Sword 2 (Demo)"

I was planning on adding desktop entries after I'd completed a few more ebuilds of scummvm games.  Would it make sense to install these games under a sub menu within the Games menu?  Maybe "Games;Revolution Software;Broken Sword 2 (Demo)" so that the other games (Broken Sword 1, Beneath a Steel Sky, Flight of the Amazon Queen, etc.) can be grouped together.

Also, some of these games have their own icons and I'd like to include those in the link.

> A version number of 1 makes more sense than 0, if no version number is

The only reason I used version 0 is because games-rpg/queen used version 0.  I can move to version 1.

I've got maybe 30 total ebuilds planned for all the scummvm games (demos and full versions).  I'm going to  work on getting this one perfect and will then go back and fix all the others.
Comment 5 unlord 2006-08-01 17:20:00 UTC
Created attachment 93241 [details]

Updated ebuild with the changes recommended.
Comment 6 Paul Bredbury 2006-08-02 01:25:22 UTC
Created attachment 93247 [details]

Tidied ebuild.

/usr/share/applications/bs2-demo-bs2-demo.desktop will contain:

So I believe it's up to the window manager to create submenus, e.g. for Gnome:
Comment 7 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-06-08 16:48:05 UTC
Hello, everyone.

It seems that at least one ebuild related to this bug exists in the Sunrise overlay at the moment. However, I have to regretfully announce that after a long inactivity period the Sunrise project has been discontinued and the related overlay will be eventually removed. For this reason, I'd like to ask you to reevaluate the ebuilds and consider moving them. If you'd like to maintain a package from Sunrise in Gentoo, please take a look at our Proxy Maintainers [1] project.

Please make sure to take ebuilds from the unreviewed developer Sunrise repository [2] rather than the -reviewed one, since the latter has not been updated for over a year. While at it, please note that:

1. Adding a package to Gentoo requires declaring yourself as an active maintainer for it. All bugs regarding the package will be assigned to you, and you will be expected to maintain it.

2. Some packages may not be suitable for addition anymore. While there's no strong rules that would prevent you from adding a package, it may be a bad idea to add old-unmaintained packages that will shortly result in a large number of bugs reported with no solution. If that is the case, please close the bug as RESOLVED/OBSOLETE to make it easier to find packages worth adding.

3. Some of the bugs were already closed as WONTFIX/OBSOLETE/... while the relevant ebuild was kept in Sunrise. If you disagree with the original decision, you still can add the ebuild via proxy-maint.

4. Pleaes note that many of the Sunrise ebuilds are old and may be buggy. If you decide to move them, please make sure to update/clean them up. The proxy-maint team will also review your ebuilds, therefore making sure they land in Gentoo in good quality.

Once again, thank you for your contribution. We hope that you will still want to contribute to Gentoo, through proxy-maint or otherwise.