Bug 141190 – net-analyzer/nagios-core-2.5 prestripped binaries

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Jakub Moc (RETIRED) 2006-07-20 09:59:12 UTC]

>>> Completed installing nagios-core-2.5 into /var/tmp/portage/nagios-core-2.5/image/

man:

QA Notice: pre-stripped files found:
/var/tmp/portage/nagios-core-2.5/image/usr/nagios/bin/nagiostats
/var/tmp/portage/nagios-core-2.5/image/usr/nagios/bin/nagios
/var/tmp/portage/nagios-core-2.5/image/usr/nagios/sbin/notifications.cgi
/var/tmp/portage/nagios-core-2.5/image/usr/nagios/sbin/statusmap.cgi
/var/tmp/portage/nagios-core-2.5/image/usr/nagios/sbin/trends.cgi
/var/tmp/portage/nagios-core-2.5/image/usr/nagios/sbin/history.cgi
/var/tmp/portage/nagios-core-2.5/image/usr/nagios/sbin/outages.cgi
/var/tmp/portage/nagios-core-2.5/image/usr/nagios/sbin/tac.cgi
/var/tmp/portage/nagios-core-2.5/image/usr/nagios/sbin/config.cgi
/var/tmp/portage/nagios-core-2.5/image/usr/nagios/sbin/extinfo.cgi
/var/tmp/portage/nagios-core-2.5/image/usr/nagios/sbin/summary.cgi
/var/tmp/portage/nagios-core-2.5/image/usr/nagios/sbin/avail.cgi
/var/tmp/portage/nagios-core-2.5/image/usr/nagios/sbin/statuswml.cgi
/var/tmp/portage/nagios-core-2.5/image/usr/nagios/sbin/statuswrl.cgi
/var/tmp/portage/nagios-core-2.5/image/usr/nagios/sbin/status.cgi
/var/tmp/portage/nagios-core-2.5/image/usr/nagios/sbin/histogram.cgi
/var/tmp/portage/nagios-core-2.5/image/usr/nagios/sbin/showlog.cgi
/var/tmp/portage/nagios-core-2.5/image/usr/nagios/sbin/cmd.cgi

[Comment 1 Lance Albertson (RETIRED) 2006-07-20 10:06:36 UTC]

Is this happening on 2.4 also?

[Comment 2 Jakub Moc (RETIRED) 2006-07-20 10:12:30 UTC]

(In reply to comment #1)
> Is this happening on 2.4 also?

Yeah, the same... Sorry if this is a dupe, haven't found anything.

>>> Completed installing nagios-core-2.4 into /var/tmp/portage/nagios-core-2.4/image/

man:

QA Notice: pre-stripped files found:
/var/tmp/portage/nagios-core-2.4/image/usr/nagios/bin/nagiostats
/var/tmp/portage/nagios-core-2.4/image/usr/nagios/bin/nagios
/var/tmp/portage/nagios-core-2.4/image/usr/nagios/sbin/notifications.cgi
/var/tmp/portage/nagios-core-2.4/image/usr/nagios/sbin/statusmap.cgi
/var/tmp/portage/nagios-core-2.4/image/usr/nagios/sbin/trends.cgi
/var/tmp/portage/nagios-core-2.4/image/usr/nagios/sbin/history.cgi
/var/tmp/portage/nagios-core-2.4/image/usr/nagios/sbin/outages.cgi
/var/tmp/portage/nagios-core-2.4/image/usr/nagios/sbin/tac.cgi
/var/tmp/portage/nagios-core-2.4/image/usr/nagios/sbin/config.cgi
/var/tmp/portage/nagios-core-2.4/image/usr/nagios/sbin/extinfo.cgi
/var/tmp/portage/nagios-core-2.4/image/usr/nagios/sbin/summary.cgi
/var/tmp/portage/nagios-core-2.4/image/usr/nagios/sbin/avail.cgi
/var/tmp/portage/nagios-core-2.4/image/usr/nagios/sbin/statuswml.cgi
/var/tmp/portage/nagios-core-2.4/image/usr/nagios/sbin/statuswrl.cgi
/var/tmp/portage/nagios-core-2.4/image/usr/nagios/sbin/status.cgi
/var/tmp/portage/nagios-core-2.4/image/usr/nagios/sbin/histogram.cgi
/var/tmp/portage/nagios-core-2.4/image/usr/nagios/sbin/showlog.cgi
/var/tmp/portage/nagios-core-2.4/image/usr/nagios/sbin/cmd.cgi
strip: i686-pc-linux-gnu-strip --strip-unneeded
   usr/nagios/bin/new_mini_epn
   usr/nagios/bin/mini_epn
   usr/nagios/bin/convertcfg

[Comment 3 Lance Albertson (RETIRED) 2006-07-20 10:21:49 UTC]

Where is this QA violation documented? I'm not familiar with it and the usual fixes for it. That would be very helpful other than saying "plsfixkthxbye".

Thanks-

[Comment 4 Jakub Moc (RETIRED) 2006-07-20 11:15:22 UTC]

(In reply to comment #3)
> Where is this QA violation documented? I'm not familiar with it and the usual
> fixes for it. That would be very helpful other than saying "plsfixkthxbye".
> 
> Thanks-

Well, portage should strip the binaries when requested (to not hinder debugging  etc. with FEATURES="nostrip" etc.)

A simple patch:

--- nagios-core-2.5.ebuild.orig	2006-07-18 19:10:04.000000000 +0200
+++ nagios-core-2.5.ebuild	2006-07-20 20:07:02.000000000 +0200
@@ -52,6 +52,8 @@
 	unpack ${A}
 	cd ${S}
 	epatch ${FILESDIR}/2.x-series-nsca.patch
+	local strip="$(echo '$(MAKE) strip-post-install')"
+	sed -i -e "s:${strip}::" {cgi,base}/Makefile.in || die "sed failed in Makefile.in"
 	# ppc64 needs this
 	gnuconfig_update
 }


Now you get:
>>> Completed installing nagios-core-2.5 into /var/tmp/portage/nagios-core-2.5/image/

man:
strip: i686-pc-linux-gnu-strip --strip-unneeded
   usr/nagios/bin/new_mini_epn
   usr/nagios/bin/nagiostats
   usr/nagios/bin/mini_epn
   usr/nagios/bin/nagios
   usr/nagios/bin/convertcfg
   usr/nagios/sbin/notifications.cgi
   usr/nagios/sbin/statusmap.cgi
   usr/nagios/sbin/trends.cgi
   usr/nagios/sbin/history.cgi
   usr/nagios/sbin/outages.cgi
   usr/nagios/sbin/tac.cgi
   usr/nagios/sbin/config.cgi
   usr/nagios/sbin/extinfo.cgi
   usr/nagios/sbin/summary.cgi
   usr/nagios/sbin/avail.cgi
   usr/nagios/sbin/statuswml.cgi
   usr/nagios/sbin/statuswrl.cgi
   usr/nagios/sbin/status.cgi
   usr/nagios/sbin/histogram.cgi
   usr/nagios/sbin/showlog.cgi
   usr/nagios/sbin/cmd.cgi

[Comment 5 Lance Albertson (RETIRED) 2006-07-20 11:47:39 UTC]

Thanks! I'll give that a shot in a few days.

[Comment 6 Tobias Scherbaum (RETIRED) 2007-05-08 21:39:21 UTC]

Fixed in nagios-core-2.9.