Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 139214 - dev-java/commons-el-1.0 j2se 1.5
Summary: dev-java/commons-el-1.0 j2se 1.5
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Java team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 139215
  Show dependency tree
 
Reported: 2006-07-04 11:14 UTC by Alon Bar-Lev (RETIRED)
Modified: 2006-07-05 08:59 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
commons-el-1.0-jdk15.patch (commons-el-1.0-jdk15.patch,1.88 KB, patch)
2006-07-04 11:14 UTC, Alon Bar-Lev (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alon Bar-Lev (RETIRED) gentoo-dev 2006-07-04 11:14:02 UTC
Simple patch to make it work.
Comment 1 Alon Bar-Lev (RETIRED) gentoo-dev 2006-07-04 11:14:42 UTC
Created attachment 90872 [details, diff]
commons-el-1.0-jdk15.patch
Comment 2 Josh Nichols (RETIRED) gentoo-dev 2006-07-04 12:40:01 UTC
This isn't necessary, because it is accomplished by the new Java system, by using -source 1.4.
Comment 3 Alon Bar-Lev (RETIRED) gentoo-dev 2006-07-04 12:42:17 UTC
But it is better to patch than using the source.
This way we can work with upstream to fully solve the issues.
Comment 4 Alon Bar-Lev (RETIRED) gentoo-dev 2006-07-04 12:45:02 UTC
Just another comment...
Why did you close the bug without making any modification... Patch or move into the new build system?
Comment 5 Josh Nichols (RETIRED) gentoo-dev 2006-07-04 12:54:46 UTC
Yes, ideally upstream would update their build.xml to use <javac source="1.4" target="1.4">. But as it is, we don't to take any action to address the problem from our perspective.

But by all means, please do file a bug upstream. I would do it myself, but I am currently overloaded working on porting everything to the new Java system.
Comment 6 Alon Bar-Lev (RETIRED) gentoo-dev 2006-07-04 12:58:04 UTC
I think that the idle solution is not to update the build.xml, but fix the source...

But still... I don't understand why you close this bug without fixing the problem... Choose to apply the patch to the sources or fix the build.xml... But why you closed the bug?
Comment 7 Josh Nichols (RETIRED) gentoo-dev 2006-07-04 13:05:10 UTC
Like, I said, using the new Java system to rewrite the build.xml is the preferred way of addressing the problem. Therefore, no change is changes are need, so it's not really a bug, so there's nothing to fix. Hence, I closed the bug.
Comment 8 Alon Bar-Lev (RETIRED) gentoo-dev 2006-07-04 13:09:21 UTC
I am truly sorry...
But I don't get it...
It does not work for me...

From what I understood from you guys is that the ebuild should be modified in order to work with the new ebuild system...

Currently it have:
inherit java-pkg eutils

So it uses the old build system, right?

Am I missing something?
Anyway, it does not work AS-IS...
Comment 9 Josh Nichols (RETIRED) gentoo-dev 2006-07-04 13:19:03 UTC
It would work if you are using a 1.4 JDK as a generation-1 system VM. To use a 1.5 JDK is not supported as a generation-1 system VM because of you'd encounter problems like this, and others.

Currently, it is a generation-1 ebuild. So, using a 1.4 JDK, the package works as is.
When the package is migrated to generation-2, it will handle using >1.4, by using the mechanism of source="1.4" target="1.4" without any further hassle.

I am working on migrating packages as fast as I can, but you will have to be patient because there are some 400+ Java packages, and I am the only developer doing the migration at this time.
Comment 10 Alon Bar-Lev (RETIRED) gentoo-dev 2006-07-04 13:23:31 UTC
OK, thanks...
But we have discussed this in bug#138174.

When I say not compile with jdk 1.5 I mean with ONLY jdk 1.5...

I am willing to help to do the conversion... But I need a good example first...
Please convert tomcat, which is a good test case... Then I will submit some more patches.

But this bug isn't solved... I am reopening it until we have a proper fix.
Comment 11 Josh Nichols (RETIRED) gentoo-dev 2006-07-04 13:41:32 UTC
Fixed in CVS to use new Java system. Happy now?
Comment 12 Alon Bar-Lev (RETIRED) gentoo-dev 2006-07-04 22:05:42 UTC
Sure!
Thanks.
Comment 13 Alon Bar-Lev (RETIRED) gentoo-dev 2006-07-05 02:36:07 UTC
But you did not apply the patch, nor I saw that you tell the build system to apply source of 1.4.
Comment 14 Alon Bar-Lev (RETIRED) gentoo-dev 2006-07-05 03:03:45 UTC
I don't get it... You automatically compile all classes to meet 1.4 source level?
So how do you compile a native 1.5 application?
I thought that I will see somekind of variable specifying a source level.
I see it is a function of the dependencies... But it should not be this way... Since you will not be able to compile 1.5 with 1.4 dependencies.

Do you have any documentation regarding these new eclasses?

Comment 15 Josh Nichols (RETIRED) gentoo-dev 2006-07-05 08:59:13 UTC
Chances are it hadn't propogated to your rsync mirror. It certainly should have by now. It is dev-java/commons-el-1.0-r1.

Documentation is available at:
http://www.gentoo.org/proj/en/java/java-devel.xml

Please take further questions and discussion to the gentoo-java mailing list, as this is a bit beyond the scope of this bug, not to mention there are more people on the list than get bug notifications. Details should be on our project page:
http://www.gentoo.org/proj/en/java/