Bug 137498 – graphicsmagick fails to compile with libpng-1.2.10

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Robert Marmorstein 2006-06-21 10:01:18 UTC]

When trying to compile graphicsmagick with libpng-1.2.10, compilation fails with 
"png_ptr" undeclared.

My emerge info:

Gentoo Base System version 1.12.0_pre18
Portage 2.1_pre9-r4 (default-linux/x86/2006.0, gcc-4.1.0, glibc-2.4-r1, 2.6.16-ck2 i686)
=================================================================
System uname: 2.6.16-ck2 i686 AMD Athlon(tm) XP 2200+
distcc 2.18.3 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled]
ccache version 2.4 [enabled]
dev-lang/python:     2.3.5-r2, 2.4.2-r1
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.59-r7
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2
sys-devel/binutils:  2.16.1-r2
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.11-r5
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=athlon-xp -pipe -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.
5/shutdown /usr/kde/3/share/config /usr/lib/mozilla/defaults/pref /usr/share/X11/xkb /usr/share/con
fig /var/bind /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/eselect/compiler /etc/gconf /etc/revdep-rebuild /etc/terminfo /etc/texmf/
web2c /etc/env.d"
CXXFLAGS="-O2 -march=athlon-xp -pipe -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig ccache distlocks gentrip metadata-transfer sandbox sfperms strict"
GENTOO_MIRRORS="http://distfiles.gentoo.org http://distro.ibiblio.org/pub/linux/distributions/gento
o"
LINGUAS="en he grc"
MAKEOPTS=""
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="x86 3dnow X Xaw3d aalib acpi ada aim alsa apache apache2 apm asf audiofile avi berkdb bidi bin
dist bitmap-fonts browserplugin bzip2 calendar cdr cli crypt cscope ctype cups curl curlwrappers db
a dedicated dga dio divx4linux doc dri dvd dvdr eds emboss encode esd fastcgi ffmpeg fftw firefox f
lac flash flatfile foomatic foomaticdb fortran ftp gb gcj gd gdbm ggi gif gmp gphoto2 gpm gstreamer
 gtk gtk2 hal iconv icq imagemagick imap imlib ipv6 isdnlog jabber jack java jikes jpeg kde kdexdel
tas ladcca lcms libg++ libwww mad mbox mcal memlimit mikmod mime ming mmap mmx mng motif mozcalenda
r mozilla mp3 mpeg mysql mysqli nas ncurses network new-login nls nocd nptl nptlonly nsplugin objc
ogg oggvorbis openal opengl oscar oss pam pcntl pcre pda pdf pdflib perl pie plotutils plugin png p
osix postgres ppds pppd python qt quicktime quotes readline reflection scanner sdl session shared s
lang sockets softmmu speex spell spl sse ssl svg sysvipc szip tcltk tcpd tetex theora tidy tiff tru
etype truetype-fonts type1-fonts udev unicode usb v4l v4l2 videos vorbis win32codecs wmf wxwindows
xcomposite xine xinerama xml xml2 xmms xorg xpm xscreensaver xsl xv xvid yahoo zlib elibc_glibc inp
ut_devices_keyboard input_devices_mouse kernel_linux linguas_en linguas_he linguas_grc userland_GNU
 video_cards_nvidia"
Unset:  ASFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, LDFLAGS

[Comment 1 Robert Marmorstein 2006-06-21 10:05:15 UTC]

Created attachment 89739 [details, diff]
Patch to make graphicsmagick compile with latest version of libpng

This allows graphicsmagick to compile, but I'm not sure everything works correctly.  Someone should probably test this on some pngs (with MMX turned on) before committing.

[Comment 2 Daniel Black (RETIRED) 2006-06-29 06:14:34 UTC]

note libpng security bug 138433 that will probably result in a rapid stabilization.

[Comment 3 David Nadlinger 2006-06-30 00:56:32 UTC]

(In reply to comment #1)
> Created an attachment (id=89739) [edit]
> Patch to make graphicsmagick compile with latest version of libpng
> 
> This allows graphicsmagick to compile, but I'm not sure everything works
> correctly.  Someone should probably test this on some pngs (with MMX turned on)
> before committing.
> 

Patch seems correct to me.
See bug 136452 (imagemagick having the same probem) for further information - libpng is (maybe) also broken.

[Comment 4 [e-mail] 2006-07-07 14:34:48 UTC]

Created attachment 91168 [details]
graphicsmagick-1.1.7-r1.ebuild

Ebuild to apply the above patch.

Patch builds fine on my x86 box.

[Comment 5 Martin von Gagern 2006-07-20 12:44:14 UTC]

(In reply to comment #4)
> graphicsmagick-1.1.7-r1.ebuild

No need for a revision bump, as this is a compile time issue. No need for users to update if compilation worked for them.

> Patch builds fine on my x86 box.

Same here, thanks.

[Comment 6 Bryan Østergaard (RETIRED) 2006-08-05 12:17:55 UTC]

Finally committed to cvs. Thanks for the patch and testing.

[Comment 7 Max Warnock 2006-08-09 10:40:30 UTC]

1.1.7-r1 and latest patch do not appear after emerge-webrsync, still using 1.1.7 and choking on the png libraries

[Comment 8 Jakub Moc (RETIRED) 2006-08-21 12:37:47 UTC]

*** Bug 144682 has been marked as a duplicate of this bug. ***

[Comment 9 Jakub Moc (RETIRED) 2006-09-01 15:14:29 UTC]

*** Bug 145906 has been marked as a duplicate of this bug. ***