Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 135945 - since Portage 2.1 setting RDEPEND is mandatory, ebuild policy needs to be updated
Summary: since Portage 2.1 setting RDEPEND is mandatory, ebuild policy needs to be upd...
Status: RESOLVED FIXED
Alias: None
Product: [OLD] Docs on www.gentoo.org
Classification: Unclassified
Component: Other documents (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Community Relations Team
URL: http://www.gentoo.org/proj/en/devrel/...
Whiteboard:
Keywords:
: 137629 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-06-07 10:06 UTC by Carsten Lohrke (RETIRED)
Modified: 2006-08-28 07:28 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Carsten Lohrke (RETIRED) gentoo-dev 2006-06-07 10:06:52 UTC
The first paragraphs of the "1.e. Variables" section including code listing 5 are incorrect. RDEPEND="${DEPEND}" is mandatory, now.


http://thread.gmane.org/gmane.linux.gentoo.devel/29509/
Comment 1 Łukasz Damentko (RETIRED) gentoo-dev 2006-06-07 10:50:19 UTC
It's not GDP who maintain Developer Handbook, but Developer Relations. GDP cares only for doc/ content. Reassigning.
Comment 2 Alec Warner (RETIRED) archtester gentoo-dev Security 2006-06-07 13:29:09 UTC
#turn off glob expansion from here on in to prevent *'s and ? in the DEPEND
#syntax from getting expanded :)
#check eclass rdepends also.
set -f
if [ "${RDEPEND-unset}" == "unset" ] && [ "${E_RDEPEND-unset}" == "unset" ] ; then
        export RDEPEND="${DEPEND} ${E_DEPEND}"
        debug-print "RDEPEND: not set... Setting to: ${DEPEND}"
fi

looks like it's in 2.1 to me...
Comment 3 Carsten Lohrke (RETIRED) gentoo-dev 2006-06-07 13:44:30 UTC
Lukasz: Sorry, can't extract that from the enter_bug.cgi information.

Alec: see e.g. bug 134555
Comment 4 Alec Warner (RETIRED) archtester gentoo-dev Security 2006-06-07 13:46:13 UTC
(In reply to comment #0)
> The first paragraphs of the "1.e. Variables" section including code listing 5
> are incorrect. RDEPEND="${DEPEND}" is mandatory, now.
> 
> 
> http://thread.gmane.org/gmane.linux.gentoo.devel/29509/
> 

Guessing you are getting nailed by an eclass that sets E_RDEPEND, in which case the setting IS required, see related bugs about depend.apache.eclass
Comment 5 Zac Medico gentoo-dev 2006-06-07 13:48:39 UTC
(In reply to comment #2)
> looks like it's in 2.1 to me...

The same code goes back at least as far as 2.0.53.  Portage will set RDEPEND="${DEPEND}" automatically for an ebuild (not for an eclass) if RDEPEND
is not set by the ebuild *and* not set by *any* inherited eclasses.  This behavior should not be relied on and therefore ebuilds should set RDEPEND="${DEPEND}" explicity when necessary.
Comment 6 Zac Medico gentoo-dev 2006-06-10 11:29:42 UTC
Please let us know if any more information is needed.
Comment 7 Petteri Räty (RETIRED) gentoo-dev 2006-06-22 11:24:59 UTC
*** Bug 137629 has been marked as a duplicate of this bug. ***
Comment 8 SpanKY gentoo-dev 2006-06-22 15:13:04 UTC
current documentation is correct ... that section of documentation is talking about ebuilds, not eclasses
Comment 9 Zac Medico gentoo-dev 2006-06-22 21:47:37 UTC
It says "Never set RDEPEND to DEPEND yourself in an ebuild" and that rule is incorrect.


Comment 10 SpanKY gentoo-dev 2006-06-24 00:34:00 UTC
removed the 'never' sentence
Comment 11 Petteri Räty (RETIRED) gentoo-dev 2006-06-24 01:43:37 UTC
(In reply to comment #10)
> removed the 'never' sentence
> 

Not really enough as for example this is still there:

# Not acceptable:
RDEPEND="${DEPEND}"

What Zac said in comment #5 should be added to the document. 
Comment 12 Bryan Østergaard (RETIRED) gentoo-dev 2006-08-14 14:43:49 UTC
Fixed in cvs. Patch reviewed by Zac.
Comment 13 SpanKY gentoo-dev 2006-08-19 06:54:18 UTC
except that portage is still fucked up and needs to be resolved on the mailing lists
Comment 14 Zac Medico gentoo-dev 2006-08-28 07:28:41 UTC
(In reply to comment #13)
> except that portage is still fucked up and needs to be resolved on the mailing
> lists

AFAIK, portage works fine when RDEPEND is set explicitly.  Any change in implicit behavior changes the behavior of the entire tree and requires an EAPI bump.