currently prepstrip script has broken handling of RESTRICT=strict: if hasq nostrip ${FEATURES} ${RESTRICT} || \ hasq strip RESTRICT then exit 0 fi this should instead be if hasq nostrip ${FEATURES} ${RESTRICT} || \ hasq strip ${RESTRICT} then exit 0 fi of course :)
me love you long time, fixed in r3403
prepstrip should not have any calls to hasq.. Who is breaking my scripts?
This has been released in 2.1_rc2-r1.
(In reply to comment #2) > prepstrip should not have any calls to hasq.. Who is breaking my scripts? i guess that's me. i thought it would be better to use hasq in terms of readability, that's why i replaced it quite some time ago. why shouldn't it use hasq though (willing to learn ;))?
(In reply to comment #4) > (In reply to comment #2) > > prepstrip should not have any calls to hasq.. Who is breaking my scripts? > > i guess that's me. i thought it would be better to use hasq in terms of > readability, that's why i replaced it quite some time ago. why shouldn't it use > hasq though (willing to learn ;))? Well in terms of readability the hasq exists and does make it eaiser to understand (sorta). But we are already pretty deep within loops and the hasq function introduces yet another loop (read slower). If you do timing tests of [[ *" foo "* ]] vs hasq the [[ ]] should win everytime. (granted we are probably only talking nanoseconds on a modern box) Sorry I'm a wee bit territorial with the the ELF handling. So in the future if you could please try to poke me or vapier before making changes to our code. (thanks)
